summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <git@the-compiler.org>2018-06-11 14:00:02 +0200
committerFlorian Bruhin <git@the-compiler.org>2018-06-11 14:02:26 +0200
commitf61662fa52299f3adb25ee3842d0e642bd365e41 (patch)
treedae083647816411604637660d61682f7412931ae
parente9b4c2a66e126e169b3031046f5d0152fd1cf5b4 (diff)
downloadqutebrowser-f61662fa52299f3adb25ee3842d0e642bd365e41.tar.gz
qutebrowser-f61662fa52299f3adb25ee3842d0e642bd365e41.zip
Only consider visible render widgets for lost focusProxy
Otherwise, when commenting out the focusProxy way above, and using "foo !npm" with DuckDuckGo, we get two children (one visible, one invisible). (cherry picked from commit b63e06561de5d442a8ce84e167b874a788bef63d)
-rw-r--r--qutebrowser/browser/webengine/webview.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/qutebrowser/browser/webengine/webview.py b/qutebrowser/browser/webengine/webview.py
index bd8ce65ba..84caceedd 100644
--- a/qutebrowser/browser/webengine/webview.py
+++ b/qutebrowser/browser/webengine/webview.py
@@ -74,7 +74,11 @@ class WebEngineView(QWebEngineView):
# This should only find the RenderWidgetHostViewQtDelegateWidget,
# but not e.g. a QMenu
- children = self.findChildren(QQuickWidget)
+ children = [c for c in self.findChildren(QQuickWidget)
+ if c.isVisible()]
+
+ log.webview.debug("Found possibly lost focusProxy: {}"
+ .format(children))
if not children:
return None