diff options
| author | Florian Bruhin <git@the-compiler.org> | 2018-05-23 09:44:44 +0200 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2018-05-28 07:44:36 +0200 |
| commit | 749056ff906435cf990f993d39af251276232478 (patch) | |
| tree | 675c08c02031e4c83f177e65d26ff9c4cecf89fe | |
| parent | e7b00ace7312d23fc0f2ee549ca4bd07d98973c5 (diff) | |
| download | qutebrowser-749056ff906435cf990f993d39af251276232478.tar.gz qutebrowser-749056ff906435cf990f993d39af251276232478.zip | |
Use functools instead of a lambda for QTimer
It reads nicer, and this is also speculative fix for #3896 as PyQt5 is
hopefully better at disconnecting partial-objects from dead objects than it is
with lambdas.
(cherry picked from commit 7162f15348219d3736a8d17785d9b6e2dff49f8f)
| -rw-r--r-- | qutebrowser/browser/webengine/webenginetab.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index a7b1446e1..a7ec618ed 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -1026,8 +1026,9 @@ class WebEngineTab(browsertab.AbstractTab): log.config.debug( "Loading {} again because of config change".format( self._reload_url.toDisplayString())) - QTimer.singleShot(100, lambda url=self._reload_url: - self.openurl(url, predict=False)) + QTimer.singleShot(100, functools.partial(self.openurl, + self._reload_url, + predict=False)) self._reload_url = None if not qtutils.version_check('5.10', compiled=False): |