diff options
| author | Florian Bruhin <git@the-compiler.org> | 2018-03-14 18:12:29 +0100 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2018-03-14 18:18:15 +0100 |
| commit | 4b6bfd066c34c413cc77ba6c60eeaa31d85d17d7 (patch) | |
| tree | 5c44a18efb373df7d902248d941f5e8215a6d9bd | |
| parent | d49e6d0229aa66245bd93849ee72e0bc897ae18e (diff) | |
| download | qutebrowser-4b6bfd066c34c413cc77ba6c60eeaa31d85d17d7.tar.gz qutebrowser-4b6bfd066c34c413cc77ba6c60eeaa31d85d17d7.zip | |
Don't emit predicted_navigation for reloads at all
When we reload a page because of a config change, we won't get another
titleChanged signal (at least sometimes).
Also, the predicted_navigation signal is worthless when reloading anyways, as
we're going to load the same URL and not something different.
Fixes #3718
(cherry picked from commit 0418a865c17c26720219e33a67c88410a6ac7181)
| -rw-r--r-- | qutebrowser/browser/webengine/webenginetab.py | 3 | ||||
| -rw-r--r-- | qutebrowser/browser/webkit/webkittab.py | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 6206a7774..fceec9074 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -706,9 +706,6 @@ class WebEngineTab(browsertab.AbstractTab): self._widget.shutdown() def reload(self, *, force=False): - if self.url().isValid(): - self.predicted_navigation.emit(self.url()) - if force: action = QWebEnginePage.ReloadAndBypassCache else: diff --git a/qutebrowser/browser/webkit/webkittab.py b/qutebrowser/browser/webkit/webkittab.py index 934fdb3c3..ac2610f5f 100644 --- a/qutebrowser/browser/webkit/webkittab.py +++ b/qutebrowser/browser/webkit/webkittab.py @@ -701,9 +701,6 @@ class WebKitTab(browsertab.AbstractTab): self._widget.shutdown() def reload(self, *, force=False): - if self.url().isValid(): - self.predicted_navigation.emit(self.url()) - if force: action = QWebPage.ReloadAndBypassCache else: |