summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2020-10-12 11:29:32 +0200
committerFlorian Bruhin <me@the-compiler.org>2020-10-12 11:29:32 +0200
commitf627f4e7ae32bae570447b0d8004787199a1d962 (patch)
tree63af64a59def805899af5f011de9672a3e1cc84c
parentb70054a74da84c69f7c72f26c5be6753ac29c74d (diff)
downloadqutebrowser-f627f4e7ae32bae570447b0d8004787199a1d962.tar.gz
qutebrowser-f627f4e7ae32bae570447b0d8004787199a1d962.zip
mypy: Improve/fix QIODevice types
-rw-r--r--qutebrowser/utils/qtutils.py11
1 files changed, 7 insertions, 4 deletions
diff --git a/qutebrowser/utils/qtutils.py b/qutebrowser/utils/qtutils.py
index b21fda4dc..97742a968 100644
--- a/qutebrowser/utils/qtutils.py
+++ b/qutebrowser/utils/qtutils.py
@@ -361,11 +361,11 @@ class PyQIODevice(io.BufferedIOBase):
def readable(self) -> bool:
return self.dev.isReadable()
- def readline(self, size: int = -1) -> bytes:
+ def readline(self, size: typing.Optional[int] = -1) -> bytes:
self._check_open()
self._check_readable()
- if size < 0:
+ if size is None or size < 0:
qt_size = 0 # no maximum size
elif size == 0:
return b''
@@ -375,7 +375,7 @@ class PyQIODevice(io.BufferedIOBase):
buf = None # type: typing.Union[QByteArray, bytes, None]
if self.dev.canReadLine():
buf = self.dev.readLine(qt_size)
- elif size < 0:
+ elif size is None or size < 0:
buf = self.dev.readAll()
else:
buf = self.dev.read(size)
@@ -401,7 +401,10 @@ class PyQIODevice(io.BufferedIOBase):
def writable(self) -> bool:
return self.dev.isWritable()
- def write(self, data: typing.Union[bytes, bytearray]) -> int:
+ def write( # type: ignore[override]
+ self,
+ data: typing.Union[bytes, bytearray]
+ ) -> int:
self._check_open()
self._check_writable()
num = self.dev.write(data)