summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2020-10-13 18:01:39 +0200
committerFlorian Bruhin <me@the-compiler.org>2020-10-13 18:05:25 +0200
commita4d1b883481224571b0c348b301c241b97643ed3 (patch)
tree09aaa6c5872d24925b5c544d16db33cdde64b7a5
parent779af13764ae694af907145901727f7b730bfc49 (diff)
downloadqutebrowser-a4d1b883481224571b0c348b301c241b97643ed3.tar.gz
qutebrowser-a4d1b883481224571b0c348b301c241b97643ed3.zip
tests: Don't set iframe.src in test_appendchild.js
The test file was taken from acid3, which does actually serve documents for those locations. For us, those documents never were available (as we're using `setHtml` which uses a `data` URL internally), but the test does work just fine without them. It was intended to test `appendChild` with different tags, see the original commit (6c241f96ed626f600911cac77f357ba8eb131e0c) as well as #2723 for details. So far, them being there wasn't a problem, but with Qt 5.15.2 (or rather the underlying Chromium 83), we get errors logged like this one: "Invalid relative frame source URL (xhtml.3) within data URL.", source: (47) So let's just not set them at all. See #5752.
-rw-r--r--tests/unit/javascript/stylesheet/test_appendchild.js14
1 files changed, 7 insertions, 7 deletions
diff --git a/tests/unit/javascript/stylesheet/test_appendchild.js b/tests/unit/javascript/stylesheet/test_appendchild.js
index d1deadba6..aa1294cb3 100644
--- a/tests/unit/javascript/stylesheet/test_appendchild.js
+++ b/tests/unit/javascript/stylesheet/test_appendchild.js
@@ -9,37 +9,37 @@ var iframe, object;
// svg iframe
iframe = document.createElement('iframe');
iframe.onload = function () { kungFuDeathGrip.title += '1' };
-iframe.src = "svg.xml";
+// iframe.src = "svg.xml";
kungFuDeathGrip.appendChild(iframe);
// object iframe
object = document.createElement('object');
object.onload = function () { kungFuDeathGrip.title += '2' };
-object.data = "svg.xml";
+// object.data = "svg.xml";
kungFuDeathGrip.appendChild(object);
// xml iframe
iframe = document.createElement('iframe');
iframe.onload = function () { kungFuDeathGrip.title += '3' };
-iframe.src = "empty.xml";
+// iframe.src = "empty.xml";
kungFuDeathGrip.appendChild(iframe);
// html iframe
iframe = document.createElement('iframe');
iframe.onload = function () { kungFuDeathGrip.title += '4' };
-iframe.src = "empty.html";
+// iframe.src = "empty.html";
kungFuDeathGrip.appendChild(iframe);
// html iframe
iframe = document.createElement('iframe');
iframe.onload = function () { kungFuDeathGrip.title += '5' };
-iframe.src = "xhtml.1";
+// iframe.src = "xhtml.1";
kungFuDeathGrip.appendChild(iframe);
// html iframe
iframe = document.createElement('iframe');
iframe.onload = function () { kungFuDeathGrip.title += '6' };
-iframe.src = "xhtml.2";
+// iframe.src = "xhtml.2";
kungFuDeathGrip.appendChild(iframe);
// html iframe
iframe = document.createElement('iframe');
iframe.onload = function () { kungFuDeathGrip.title += '7' };
-iframe.src = "xhtml.3";
+// iframe.src = "xhtml.3";
kungFuDeathGrip.appendChild(iframe);
// add the lot to the document