diff options
| author | Florian Bruhin <me@the-compiler.org> | 2020-05-22 22:42:53 +0200 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2020-05-22 22:42:53 +0200 |
| commit | ea9f2fcf49fb16ce90422096cd097cd54b2592f8 (patch) | |
| tree | 1c4e691985d1c0b072391a1f61ae08a085ac56aa | |
| parent | 1463fc4e35910defe3ddb30ae292c9db37dbe4d4 (diff) | |
| download | qutebrowser-ea9f2fcf49fb16ce90422096cd097cd54b2592f8.tar.gz qutebrowser-ea9f2fcf49fb16ce90422096cd097cd54b2592f8.zip | |
Handle None in _toggle_sel_translate
This is the equivalent of the previous:
TypeError: AbstractCaret.selection_toggled[bool].emit(): argument 1 has unexpected type 'NoneType'
When e.g. doing:
qutebrowser --temp-basedir ':later 100 enter-mode caret' ':later 110 toggle-selection'
Handle this case and show an error instead of crashing.
| -rw-r--r-- | qutebrowser/browser/webengine/webenginetab.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index cd305d11a..709c5c1b5 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -531,6 +531,9 @@ class WebEngineCaret(browsertab.AbstractCaret): self._tab.run_js_async(code, callback) def _toggle_sel_translate(self, state_str): + if state_str is None: + message.error("Error toggling caret selection") + return state = browsertab.SelectionState[state_str] self.selection_toggled.emit(state) |