summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2020-05-27 16:06:46 +0200
committerFlorian Bruhin <me@the-compiler.org>2020-05-27 16:08:48 +0200
commit6657d1bfe35c5c2f7626cc4559cfaa2eea4a9e33 (patch)
treeb4c5fc6c259468b8f766ccb5f39bbf01758c792a
parent20c7613932ec4769e3f5b65b62548dabf76946da (diff)
downloadqutebrowser-6657d1bfe35c5c2f7626cc4559cfaa2eea4a9e33.tar.gz
qutebrowser-6657d1bfe35c5c2f7626cc4559cfaa2eea4a9e33.zip
tests: Ensure consistency for configdata float values
See #5394
-rw-r--r--tests/unit/config/test_configdata.py11
1 files changed, 9 insertions, 2 deletions
diff --git a/tests/unit/config/test_configdata.py b/tests/unit/config/test_configdata.py
index 3dd6a588f..321135994 100644
--- a/tests/unit/config/test_configdata.py
+++ b/tests/unit/config/test_configdata.py
@@ -47,10 +47,17 @@ def test_data(config_stub):
# https://github.com/qutebrowser/qutebrowser/issues/3104
# For lists/dicts, don't use None as default
if isinstance(option.typ, (configtypes.Dict, configtypes.List)):
- assert option.default is not None
+ assert option.default is not None, option
# For ListOrValue, use a list as default
if isinstance(option.typ, configtypes.ListOrValue):
- assert isinstance(option.default, list)
+ assert isinstance(option.default, list), option
+
+ # Make sure floats also have floats for defaults/bounds
+ if isinstance(option.typ, configtypes.Float):
+ for value in [option.default,
+ option.typ.minval,
+ option.typ.maxval]:
+ assert value is None or isinstance(value, float), option
def test_init_benchmark(benchmark):