summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2020-06-01 14:43:14 +0200
committerFlorian Bruhin <me@the-compiler.org>2020-06-01 14:47:44 +0200
commit4787b30f96c8832797fcc3c56457400d3ebb9893 (patch)
tree1b5135edb5f2dd43691945f130322ed9af554d6e
parent41a7db811108fa698687bff4dbb085f6af29018f (diff)
downloadqutebrowser-4787b30f96c8832797fcc3c56457400d3ebb9893.tar.gz
qutebrowser-4787b30f96c8832797fcc3c56457400d3ebb9893.zip
Fix lint
-rw-r--r--qutebrowser/misc/backendproblem.py4
-rw-r--r--qutebrowser/utils/utils.py2
-rw-r--r--qutebrowser/utils/version.py10
3 files changed, 13 insertions, 3 deletions
diff --git a/qutebrowser/misc/backendproblem.py b/qutebrowser/misc/backendproblem.py
index 5c8e1002d..6e2bd1866 100644
--- a/qutebrowser/misc/backendproblem.py
+++ b/qutebrowser/misc/backendproblem.py
@@ -57,7 +57,7 @@ class _Button:
text = attr.ib() # type: str
setting = attr.ib() # type: str
- value = attr.ib() # type: str
+ value = attr.ib() # type: typing.Any
default = attr.ib(default=False) # type: bool
@@ -255,7 +255,7 @@ class _BackendProblemChecker:
raise utils.Unreachable
- def _xwayland_options(self) -> typing.Tuple[typing.List[_Button], str]:
+ def _xwayland_options(self) -> typing.Tuple[str, typing.List[_Button]]:
"""Get buttons/text for a possible XWayland solution."""
buttons = []
text = "<p>You can work around this in one of the following ways:</p>"
diff --git a/qutebrowser/utils/utils.py b/qutebrowser/utils/utils.py
index 39d46add8..ccae5a5d3 100644
--- a/qutebrowser/utils/utils.py
+++ b/qutebrowser/utils/utils.py
@@ -780,7 +780,7 @@ def ceil_log(number: int, base: int) -> int:
return result
-def libgl_workaround():
+def libgl_workaround() -> None:
"""Work around QOpenGLShaderProgram issues, especially for Nvidia.
See https://bugs.launchpad.net/ubuntu/+source/python-qt4/+bug/941826
diff --git a/qutebrowser/utils/version.py b/qutebrowser/utils/version.py
index 8dc4ec593..9c8c8f9e8 100644
--- a/qutebrowser/utils/version.py
+++ b/qutebrowser/utils/version.py
@@ -517,6 +517,16 @@ class OpenGLInfo:
@classmethod
def parse(cls, *, vendor: str, version: str) -> 'OpenGLInfo':
+ """Parse OpenGL version info from a string.
+
+ The arguments should be the strings returned by OpenGL for GL_VENDOR
+ and GL_VERSION, respectively.
+
+ According to the OpenGL reference, the version string should have the
+ following format:
+
+ <major>.<minor>[.<release>] <vendor-specific info>
+ """
if ' ' not in version:
log.misc.warning("Failed to parse OpenGL version (missing space): "
"{}".format(version))