summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Scherer <philip.luca.scherer@gmail.com>2020-04-16 18:52:16 +0200
committerPhilip Scherer <philip.luca.scherer@gmail.com>2020-04-16 18:52:16 +0200
commitfa8298789f339893636fc002cbcbd44fbb65a0e6 (patch)
tree6b8838f85f46dbbc44b0d14702aeefadf39dec6c
parent88efad3df0e48c28dfa78c0ba9950923338ea3ff (diff)
downloadqutebrowser-fa8298789f339893636fc002cbcbd44fbb65a0e6.tar.gz
qutebrowser-fa8298789f339893636fc002cbcbd44fbb65a0e6.zip
Fix version check happening late in wrap handler
-rw-r--r--qutebrowser/browser/webengine/webenginetab.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py
index 88085188a..5641b98f8 100644
--- a/qutebrowser/browser/webengine/webenginetab.py
+++ b/qutebrowser/browser/webengine/webenginetab.py
@@ -176,14 +176,14 @@ class _WebEngineSearchWrapHandler:
self.flag_wrap = True
self._nowrap_available = False
- def connect_signal(self, signal):
- """Connect the given findTextFinished signal to the internal handler.
+ def connect_signal(self, page):
+ """Connect to the findTextFinished signal of the page.
Args:
- signal: A findTextFinished signal to connect to.
+ page: The QtWebEnginePage to connect to this handler.
"""
if qtutils.version_check("5.14"):
- signal.connect(self._store_match_data)
+ page.findTextFinished.connect(self._store_match_data)
self._nowrap_available = True
def _store_match_data(self, result):
@@ -252,7 +252,7 @@ class WebEngineSearch(browsertab.AbstractSearch):
self._wrap_handler = _WebEngineSearchWrapHandler()
def connect_signals(self):
- self._wrap_handler.connect_signal(self._widget.page().findTextFinished)
+ self._wrap_handler.connect_signal(self._widget.page())
def _find(self, text, flags, callback, caller):
"""Call findText on the widget."""