diff options
| author | Florian Bruhin <git@the-compiler.org> | 2018-01-20 18:50:17 +0100 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2018-01-20 18:54:53 +0100 |
| commit | 501e4dba9c7cdccd408c8d1f26b50b7a5bae1875 (patch) | |
| tree | d9f5d073c58028c17d319ae2c38c67e99bcb2503 | |
| parent | de147b5a9327cc1d856900d493bc9e093b9d42f1 (diff) | |
| download | qutebrowser-501e4dba9c7cdccd408c8d1f26b50b7a5bae1875.tar.gz qutebrowser-501e4dba9c7cdccd408c8d1f26b50b7a5bae1875.zip | |
Fix crash when getting signals for closed tabs
Fixes #3498
(cherry picked from commit 748de85ba2cc7bd8557a87fce88aab0ac3f3ad27)
| -rw-r--r-- | qutebrowser/browser/browsertab.py | 4 | ||||
| -rw-r--r-- | qutebrowser/browser/webengine/webenginetab.py | 3 |
2 files changed, 7 insertions, 0 deletions
diff --git a/qutebrowser/browser/browsertab.py b/qutebrowser/browser/browsertab.py index eb0e55c4b..86ebfe7b6 100644 --- a/qutebrowser/browser/browsertab.py +++ b/qutebrowser/browser/browsertab.py @@ -749,6 +749,10 @@ class AbstractTab(QWidget): @pyqtSlot(bool) def _on_load_finished(self, ok): + if sip.isdeleted(self._widget): + # https://github.com/qutebrowser/qutebrowser/issues/3498 + return + sess_manager = objreg.get('session-manager') sess_manager.save_autosave() diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 9328698bc..bf3567423 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -597,6 +597,9 @@ class WebEngineTab(browsertab.AbstractTab): @pyqtSlot() def _restore_zoom(self): + if sip.isdeleted(self._widget): + # https://github.com/qutebrowser/qutebrowser/issues/3498 + return if self._saved_zoom is None: return self.zoom.set_factor(self._saved_zoom) |