summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <git@the-compiler.org>2017-10-06 10:17:13 +0200
committerFlorian Bruhin <git@the-compiler.org>2017-10-06 10:17:13 +0200
commitf3eb5dbb667090fbdc3bc52f9e0d2180177dea14 (patch)
tree4fed9083b6c4b204375b91fad7456224f17986b5
parent3eaad092b888751012ab3ef80505c0fa7100a842 (diff)
downloadqutebrowser-f3eb5dbb667090fbdc3bc52f9e0d2180177dea14.tar.gz
qutebrowser-f3eb5dbb667090fbdc3bc52f9e0d2180177dea14.zip
Revert "Only emit perc_changed signal when the percentage actually changed"
This reverts commit 3eaad092b888751012ab3ef80505c0fa7100a842. This breaks various end2end test relying on getting log messages for scrolling.
-rw-r--r--CHANGELOG.asciidoc3
-rw-r--r--qutebrowser/browser/webengine/webenginetab.py5
2 files changed, 2 insertions, 6 deletions
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 89d1811b2..06e2b25a7 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -25,9 +25,6 @@ Fixes
- Fixed printing on macOS.
- Closing a pinned tab via mouse now also prompts for confirmation.
- The "try again" button on error pages works correctly again.
-- :spawn -u -d is now disallowed.
-- :spawn -d shows error messages correctly now.
-- Performance improvements for smooth scrolling
v0.11.0
-------
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py
index 75a9dbcd3..e4b5eba09 100644
--- a/qutebrowser/browser/webengine/webenginetab.py
+++ b/qutebrowser/browser/webengine/webenginetab.py
@@ -345,10 +345,9 @@ class WebEngineScroller(browsertab.AbstractScroller):
perc_y = min(100, round(100 / dy * jsret['px']['y']))
self._at_bottom = math.ceil(jsret['px']['y']) >= dy
+ self._pos_perc = perc_x, perc_y
- if self._pos_perc != (perc_x, perc_y):
- self._pos_perc = perc_x, perc_y
- self.perc_changed.emit(*self._pos_perc)
+ self.perc_changed.emit(*self._pos_perc)
js_code = javascript.assemble('scroll', 'pos')
self._tab.run_js_async(js_code, update_pos_cb)