diff options
| author | Florian Bruhin <me@the-compiler.org> | 2024-04-30 20:34:50 +0200 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2024-04-30 20:34:50 +0200 |
| commit | a8f4feabb7dbf907745a838b731fd1c63847bfe3 (patch) | |
| tree | d40fccdbaa9e39887d99cdcab41ba505ce361110 | |
| parent | 3d96fc2656b372474c4f302617333bf2bb3e9cde (diff) | |
| download | qutebrowser-a8f4feabb7dbf907745a838b731fd1c63847bfe3.tar.gz qutebrowser-a8f4feabb7dbf907745a838b731fd1c63847bfe3.zip | |
Exit command mode in editor tests
Similarly to 24d01ad25729458f0584a35c6b4d9a36f0b5e580, failing Qt 5.15 tests
showed some evidence of us being stuck in command mode in the next test file
(hints.feature). On the first test there ("Scenario: Using :hint-follow outside
of hint mode (issue 1105)"):
17:38:51.073 ERROR message message:error:63 hint-follow: This command
is only allowed in hint mode, not command.
but:
end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting
for {'category': 'message', 'loglevel': 40, 'message': 'hint-follow: This
command is only allowed in hint mode, not normal.'}.
I agree with what has been said: This should never happen, because we restart
the qutebrowser process between test files. I did some of the mentioned "more
examination" but also don't have an explanation.
To avoid more flaky tests, let's roll with another bandaid solution.
| -rw-r--r-- | tests/end2end/features/editor.feature | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/end2end/features/editor.feature b/tests/end2end/features/editor.feature index 9ca855d27..018d65b9f 100644 --- a/tests/end2end/features/editor.feature +++ b/tests/end2end/features/editor.feature @@ -188,6 +188,8 @@ Feature: Opening external editors And I run :cmd-edit Then the error "command must start with one of :/?" should be shown And "Leaving mode KeyMode.command *" should not be logged + And I run :mode-leave + And "Leaving mode KeyMode.command *" should be logged ## select single file |