summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoofar <toofar@spalge.com>2023-02-06 19:20:50 +1300
committertoofar <toofar@spalge.com>2023-02-06 19:50:22 +1300
commitce134c96621fa23974e6ea1f2baa08b9bf48e6f8 (patch)
treef4d0de5f6acdf7ef5bb34ec0c0160855dcf0e3a2
parent9ec6d449101251ada24cb0155cbf2b371a6d81ba (diff)
downloadqutebrowser-ce134c96621fa23974e6ea1f2baa08b9bf48e6f8.tar.gz
qutebrowser-ce134c96621fa23974e6ea1f2baa08b9bf48e6f8.zip
lint: superfluous-parens and useless-suppression
Unnecessary parens after '=' keyword
-rw-r--r--qutebrowser/browser/browsertab.py2
-rw-r--r--tests/end2end/test_invocations.py6
-rw-r--r--tests/unit/browser/webengine/test_spell.py2
-rw-r--r--tests/unit/misc/test_sessions.py2
-rw-r--r--tests/unit/utils/test_standarddir.py2
5 files changed, 7 insertions, 7 deletions
diff --git a/qutebrowser/browser/browsertab.py b/qutebrowser/browser/browsertab.py
index 81915e11c..86c373a9a 100644
--- a/qutebrowser/browser/browsertab.py
+++ b/qutebrowser/browser/browsertab.py
@@ -490,7 +490,7 @@ class AbstractZoom(QObject):
raise ValueError("Can't zoom to factor {}!".format(factor))
default_zoom_factor = float(config.val.zoom.default) / 100
- self._default_zoom_changed = (factor != default_zoom_factor)
+ self._default_zoom_changed = factor != default_zoom_factor
self._zoom_factor = factor
self._set_factor_internal(factor)
diff --git a/tests/end2end/test_invocations.py b/tests/end2end/test_invocations.py
index f3fdbbfba..042089859 100644
--- a/tests/end2end/test_invocations.py
+++ b/tests/end2end/test_invocations.py
@@ -204,9 +204,9 @@ def test_misconfigured_user_dirs(request, server, temp_basedir_env,
home = tmp_path / 'home'
home.mkdir()
temp_basedir_env['HOME'] = str(home)
- config_userdir_dir = (tmp_path / 'config')
+ config_userdir_dir = tmp_path / 'config'
config_userdir_dir.mkdir(parents=True)
- config_userdir_file = (tmp_path / 'config' / 'user-dirs.dirs')
+ config_userdir_file = tmp_path / 'config' / 'user-dirs.dirs'
config_userdir_file.touch()
assert temp_basedir_env['XDG_CONFIG_HOME'] == str(tmp_path / 'config')
@@ -307,7 +307,7 @@ def test_webengine_download_suffix(request, quteproc_new, tmp_path):
(tmp_path / 'user-dirs.dirs').write_text(
'XDG_DOWNLOAD_DIR={}'.format(download_dir))
env = {'XDG_CONFIG_HOME': str(tmp_path)}
- args = (['--temp-basedir'] + _base_args(request.config))
+ args = ['--temp-basedir'] + _base_args(request.config)
quteproc_new.start(args, env=env)
quteproc_new.set_setting('downloads.location.prompt', 'false')
diff --git a/tests/unit/browser/webengine/test_spell.py b/tests/unit/browser/webengine/test_spell.py
index 2218b5c31..859f4209b 100644
--- a/tests/unit/browser/webengine/test_spell.py
+++ b/tests/unit/browser/webengine/test_spell.py
@@ -34,7 +34,7 @@ def test_version(message_mock, caplog):
with caplog.at_level(logging.WARNING):
assert spell.version('malformed_filename') is None
msg = message_mock.getmsg(usertypes.MessageLevel.warning)
- expected = ("Found a dictionary with a malformed name: malformed_filename")
+ expected = "Found a dictionary with a malformed name: malformed_filename"
assert msg.text == expected
diff --git a/tests/unit/misc/test_sessions.py b/tests/unit/misc/test_sessions.py
index f77982e5f..ecd04572a 100644
--- a/tests/unit/misc/test_sessions.py
+++ b/tests/unit/misc/test_sessions.py
@@ -286,7 +286,7 @@ class FakeWebView:
def load_history(self, data):
self.loaded_history = data
if self.raise_error is not None:
- raise self.raise_error # pylint: disable=raising-bad-type
+ raise self.raise_error
@pytest.fixture
diff --git a/tests/unit/utils/test_standarddir.py b/tests/unit/utils/test_standarddir.py
index 0ca635ae2..dcb863d1d 100644
--- a/tests/unit/utils/test_standarddir.py
+++ b/tests/unit/utils/test_standarddir.py
@@ -281,7 +281,7 @@ class TestArguments:
def test_basedir_relative(self, tmpdir):
"""Test --basedir with a relative path."""
- basedir = (tmpdir / 'basedir')
+ basedir = tmpdir / 'basedir'
basedir.ensure(dir=True)
with tmpdir.as_cwd():
args = types.SimpleNamespace(basedir='basedir')