summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2021-12-02 17:43:45 +0100
committerFlorian Bruhin <me@the-compiler.org>2021-12-02 17:43:45 +0100
commit100e87ff0e9e80ef517be2af757a6f875a15334f (patch)
tree33504876df34863912cc7f3d4933ae9ff3ad8608
parent42d41096bc969cd0802ce7c9e884669b9b2d522c (diff)
downloadqutebrowser-100e87ff0e9e80ef517be2af757a6f875a15334f.tar.gz
qutebrowser-100e87ff0e9e80ef517be2af757a6f875a15334f.zip
pylint: Remove now-useless suppressions
-rw-r--r--qutebrowser/keyinput/keyutils.py2
-rw-r--r--qutebrowser/utils/message.py4
-rw-r--r--tests/end2end/fixtures/quteprocess.py5
-rw-r--r--tests/helpers/fixtures.py2
-rw-r--r--tests/unit/api/test_cmdutils.py3
5 files changed, 5 insertions, 11 deletions
diff --git a/qutebrowser/keyinput/keyutils.py b/qutebrowser/keyinput/keyutils.py
index 6bd8c99b8..f74c59aa7 100644
--- a/qutebrowser/keyinput/keyutils.py
+++ b/qutebrowser/keyinput/keyutils.py
@@ -656,7 +656,6 @@ class KeySequence:
@classmethod
def parse(cls, keystr: str) -> 'KeySequence':
"""Parse a keystring like <Ctrl-x> or xyz and return a KeySequence."""
- # pylint: disable=protected-access
new = cls()
strings = list(_parse_keystring(keystr))
for sub in utils.chunk(strings, cls._MAX_LEN):
@@ -666,6 +665,5 @@ class KeySequence:
if keystr:
assert new, keystr
- # pylint: disable=protected-access
new._validate(keystr)
return new
diff --git a/qutebrowser/utils/message.py b/qutebrowser/utils/message.py
index 50a438637..3097cb4dc 100644
--- a/qutebrowser/utils/message.py
+++ b/qutebrowser/utils/message.py
@@ -125,7 +125,7 @@ def ask(*args: Any, **kwargs: Any) -> Any:
Return:
The answer the user gave or None if the prompt was cancelled.
"""
- question = _build_question(*args, **kwargs) # pylint: disable=missing-kwoa
+ question = _build_question(*args, **kwargs)
global_bridge.ask(question, blocking=True)
answer = question.answer
question.deleteLater()
@@ -174,7 +174,7 @@ def confirm_async(*, yes_action: _ActionType,
The question object.
"""
kwargs['mode'] = usertypes.PromptMode.yesno
- question = _build_question(**kwargs) # pylint: disable=missing-kwoa
+ question = _build_question(**kwargs)
question.answered_yes.connect(yes_action)
if no_action is not None:
question.answered_no.connect(no_action)
diff --git a/tests/end2end/fixtures/quteprocess.py b/tests/end2end/fixtures/quteprocess.py
index 3cbea01ad..e1e4f8f50 100644
--- a/tests/end2end/fixtures/quteprocess.py
+++ b/tests/end2end/fixtures/quteprocess.py
@@ -609,8 +609,7 @@ class QuteProc(testprocess.Process):
self.wait_for(category='webview',
message='Scroll position changed to ' + point)
- def wait_for(self, timeout=None, # pylint: disable=arguments-differ
- **kwargs):
+ def wait_for(self, timeout=None, **kwargs):
"""Extend wait_for to add divisor if a test is xfailing."""
__tracebackhide__ = (lambda e:
e.errisinstance(testprocess.WaitForTimeout))
@@ -716,7 +715,7 @@ class QuteProc(testprocess.Process):
target_arg)
self._wait_for_ipc()
- def start(self, *args, **kwargs): # pylint: disable=arguments-differ
+ def start(self, *args, **kwargs):
try:
super().start(*args, **kwargs)
except testprocess.ProcessExited:
diff --git a/tests/helpers/fixtures.py b/tests/helpers/fixtures.py
index cd3778b8a..dd902eb7d 100644
--- a/tests/helpers/fixtures.py
+++ b/tests/helpers/fixtures.py
@@ -186,7 +186,7 @@ def testdata_scheme(qapp):
pass
@qutescheme.add_handler('testdata')
- def handler(url): # pylint: disable=unused-variable
+ def handler(url):
file_abs = os.path.abspath(os.path.dirname(__file__))
filename = os.path.join(file_abs, os.pardir, 'end2end',
url.path().lstrip('/'))
diff --git a/tests/unit/api/test_cmdutils.py b/tests/unit/api/test_cmdutils.py
index 77e648eed..b6650078c 100644
--- a/tests/unit/api/test_cmdutils.py
+++ b/tests/unit/api/test_cmdutils.py
@@ -17,8 +17,6 @@
# You should have received a copy of the GNU General Public License
# along with qutebrowser. If not, see <https://www.gnu.org/licenses/>.
-# pylint: disable=unused-variable
-
"""Tests for qutebrowser.api.cmdutils."""
import sys
@@ -292,7 +290,6 @@ class TestRegister:
class Enum(enum.Enum):
- # pylint: disable=invalid-name
x = enum.auto()
y = enum.auto()