diff options
| author | Florian Bruhin <me@the-compiler.org> | 2023-06-05 12:58:35 +0200 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2023-06-05 12:58:35 +0200 |
| commit | a7ad16daefd99a448961218638dc6a997bd627f4 (patch) | |
| tree | b86c8a3fa94b743d817aeb9102a820321e9ca607 | |
| parent | 648d990a6c3a2ee1633d658d83ae2866883ac0b8 (diff) | |
| download | qutebrowser-a7ad16daefd99a448961218638dc6a997bd627f4.tar.gz qutebrowser-a7ad16daefd99a448961218638dc6a997bd627f4.zip | |
notifications: Fix invalid version number construction
File "/usr/lib/python3.11/site-packages/qutebrowser/browser/webengine/notification.py", line 859, in _find_quirks
if utils.VersionNumber.parse(ver) < utils.VersionNumber(2, 0):
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/qutebrowser/utils/utils.py", line 96, in __init__
raise ValueError(
ValueError: Refusing to construct non-normalized version from (2, 0) (normalized: (2,)).
| -rw-r--r-- | doc/changelog.asciidoc | 1 | ||||
| -rw-r--r-- | qutebrowser/browser/webengine/notification.py | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index ce366153f..d8d2399a0 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -167,6 +167,7 @@ Fixed asciidoc rather than requiring a system-wide installation. - Crash with some notification servers when the server is quitting. - Crash when using QtWebKit with PAC and the file has an invalid encoding. +- Crash with the "tiramisu" notification server. [[v2.5.4]] v2.5.4 (2023-03-13) diff --git a/qutebrowser/browser/webengine/notification.py b/qutebrowser/browser/webengine/notification.py index 8b67570a4..fc47277c3 100644 --- a/qutebrowser/browser/webengine/notification.py +++ b/qutebrowser/browser/webengine/notification.py @@ -813,7 +813,7 @@ class DBusNotificationAdapter(AbstractNotificationAdapter): # https://github.com/sboli/twmn/pull/96 return _ServerQuirks(spec_version="0") elif (name, vendor) == ("tiramisu", "Sweets"): - if utils.VersionNumber.parse(ver) < utils.VersionNumber(2, 0): + if utils.VersionNumber.parse(ver) < utils.VersionNumber(2): # https://github.com/Sweets/tiramisu/issues/20 return _ServerQuirks(skip_capabilities=True) elif (name, vendor) == ("lxqt-notificationd", "lxqt.org"): |