diff options
| author | Florian Bruhin <me@the-compiler.org> | 2021-01-14 11:58:30 +0100 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2021-01-14 12:05:38 +0100 |
| commit | 5526dce6c36042f711cdb80f6b1b342cd6b0628c (patch) | |
| tree | 6aae2481fbe95087388576c46b7d5ca7e4193ce3 | |
| parent | fb5e105c1998350cd89512323c641be0d5d9d1b5 (diff) | |
| download | qutebrowser-5526dce6c36042f711cdb80f6b1b342cd6b0628c.tar.gz qutebrowser-5526dce6c36042f711cdb80f6b1b342cd6b0628c.zip | |
Fix lint
| -rw-r--r-- | qutebrowser/browser/history.py | 4 | ||||
| -rw-r--r-- | qutebrowser/misc/sql.py | 11 |
2 files changed, 8 insertions, 7 deletions
diff --git a/qutebrowser/browser/history.py b/qutebrowser/browser/history.py index 8fe7edb64..eaeb274f3 100644 --- a/qutebrowser/browser/history.py +++ b/qutebrowser/browser/history.py @@ -240,8 +240,8 @@ class WebHistory(sql.SqlTable): accordingly as well. """ return ( - url.scheme() in ['data', 'view-source'] or - (url.scheme() == 'qute' and url.host() in ['back', 'pdfjs']) + url.scheme() in {'data', 'view-source'} or + (url.scheme() == 'qute' and url.host() in {'back', 'pdfjs'}) ) def _cleanup_history(self): diff --git a/qutebrowser/misc/sql.py b/qutebrowser/misc/sql.py index b14c96c14..c71ac6eaa 100644 --- a/qutebrowser/misc/sql.py +++ b/qutebrowser/misc/sql.py @@ -39,9 +39,9 @@ class UserVersion: Instead, we now (ab)use the fact that the user_version in sqlite is a 32-bit integer to store both a major and a minor part. If only the minor part changed, we can deal - with it (there are only new URLs to clean up or somesuch). If the major part changed, - there are backwards-incompatible changes in how the database works, so newer - databases are not compatible with older qutebrowser versions. + with it (there are only new URLs to clean up or somesuch). If the major part + changed, there are backwards-incompatible changes in how the database works, so + newer databases are not compatible with older qutebrowser versions. """ major: int = attr.ib() @@ -182,8 +182,8 @@ def init(db_path): raise_sqlite_error(msg, error) global db_user_version - version = Query('pragma user_version').run().value() - db_user_version = UserVersion.from_int(version) + version_int = Query('pragma user_version').run().value() + db_user_version = UserVersion.from_int(version_int) if db_user_version.major > USER_VERSION.major: raise KnownError( @@ -307,6 +307,7 @@ class Query: return self.query.record().value(0) def rows_affected(self): + """Return how many rows were affected by a non-SELECT query.""" assert not self.query.isSelect(), self assert self.query.isActive(), self rows = self.query.numRowsAffected() |