summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoofar <toofar@spalge.com>2023-07-23 20:49:32 +1200
committertoofar <toofar@spalge.com>2023-10-28 08:47:34 +1300
commiteab1cbe8db0cc3982e8211bc66c2f37f51c1b317 (patch)
treeaee1e2853730c6e784d981ec5615bef54a342c64
parentc5902c4541a1cac79d18493e56019bb00e895016 (diff)
downloadqutebrowser-eab1cbe8db0cc3982e8211bc66c2f37f51c1b317.tar.gz
qutebrowser-eab1cbe8db0cc3982e8211bc66c2f37f51c1b317.zip
Revert "Print stdout/err on debug build smoke tests too."
This reverts commit 23979c147fae27e32af8812346a56bef18d89c3e.
-rwxr-xr-xscripts/dev/build_release.py14
1 files changed, 7 insertions, 7 deletions
diff --git a/scripts/dev/build_release.py b/scripts/dev/build_release.py
index a2ec58a49..7547bf843 100755
--- a/scripts/dev/build_release.py
+++ b/scripts/dev/build_release.py
@@ -183,6 +183,10 @@ def smoke_test(executable: pathlib.Path, debug: bool, qt5: bool) -> None:
])
proc = _smoke_test_run(executable)
+ if debug:
+ print("Skipping output check for debug build")
+ proc.check_returncode()
+ return
stdout = '\n'.join(_filter_whitelisted(proc.stdout, stdout_whitelist))
stderr = '\n'.join(_filter_whitelisted(proc.stderr, stderr_whitelist))
@@ -191,13 +195,9 @@ def smoke_test(executable: pathlib.Path, debug: bool, qt5: bool) -> None:
print(
f"Unexpected output, running with --debug (returncode={proc.returncode})"
)
- if debug:
- debug_stdout = None
- debug_stderr = None
- else:
- proc = _smoke_test_run(executable, '--debug')
- debug_stdout = proc.stdout.decode('utf-8')
- debug_stderr = proc.stderr.decode('utf-8')
+ proc = _smoke_test_run(executable, '--debug')
+ debug_stdout = proc.stdout.decode('utf-8')
+ debug_stderr = proc.stderr.decode('utf-8')
lines = [
"Unexpected output!",