summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoofar <toofar@spalge.com>2023-07-23 19:29:26 +1200
committertoofar <toofar@spalge.com>2023-10-28 08:47:34 +1300
commitc5902c4541a1cac79d18493e56019bb00e895016 (patch)
treef3e8190d76661f005e094fd22b3fa456505c4c95
parentca5e39d7003b1d3d5928b1690d7c5ed8cd1e55b2 (diff)
downloadqutebrowser-c5902c4541a1cac79d18493e56019bb00e895016.tar.gz
qutebrowser-c5902c4541a1cac79d18493e56019bb00e895016.zip
Print stdout/err on debug build smoke tests too.
-rwxr-xr-xscripts/dev/build_release.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/scripts/dev/build_release.py b/scripts/dev/build_release.py
index 50f27720a..a2ec58a49 100755
--- a/scripts/dev/build_release.py
+++ b/scripts/dev/build_release.py
@@ -182,11 +182,7 @@ def smoke_test(executable: pathlib.Path, debug: bool, qt5: bool) -> None:
r'module could not be found. \(0x7E\)'),
])
- proc = _smoke_test_run(executable, capture_output=not debug)
- if debug:
- print("Skipping output check for debug build")
- proc.check_returncode()
- return
+ proc = _smoke_test_run(executable)
stdout = '\n'.join(_filter_whitelisted(proc.stdout, stdout_whitelist))
stderr = '\n'.join(_filter_whitelisted(proc.stderr, stderr_whitelist))
@@ -195,9 +191,13 @@ def smoke_test(executable: pathlib.Path, debug: bool, qt5: bool) -> None:
print(
f"Unexpected output, running with --debug (returncode={proc.returncode})"
)
- proc = _smoke_test_run(executable, '--debug')
- debug_stdout = proc.stdout.decode('utf-8')
- debug_stderr = proc.stderr.decode('utf-8')
+ if debug:
+ debug_stdout = None
+ debug_stderr = None
+ else:
+ proc = _smoke_test_run(executable, '--debug')
+ debug_stdout = proc.stdout.decode('utf-8')
+ debug_stderr = proc.stderr.decode('utf-8')
lines = [
"Unexpected output!",