summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJimmy <jimmy@spalge.com>2022-04-16 16:19:50 +1200
committerJimmy <jimmy@spalge.com>2022-04-30 17:47:17 +1200
commit802ef377dbddac79016824a161cba97345895790 (patch)
tree310202250af2cbbd0a9eead76d03a2fbfa4204ad
parent1378c09aa5de0eb2edd8966c783c204c4de52dce (diff)
downloadqutebrowser-802ef377dbddac79016824a161cba97345895790.tar.gz
qutebrowser-802ef377dbddac79016824a161cba97345895790.zip
Restore "unused" imports after pyqt wrapper re-write
Some test imports that didn't have the things there were importing used got dropped by the rename tool. This restores them. Found by searching in the diff for eg `import qutebrowser.qt$` and `import qutebrowser.qt ` Relates to #995
-rw-r--r--qutebrowser/config/configfiles.py6
-rw-r--r--tests/conftest.py20
2 files changed, 13 insertions, 13 deletions
diff --git a/qutebrowser/config/configfiles.py b/qutebrowser/config/configfiles.py
index f86f47b07..0553ef59f 100644
--- a/qutebrowser/config/configfiles.py
+++ b/qutebrowser/config/configfiles.py
@@ -39,7 +39,7 @@ from qutebrowser.config import (configexc, config, configdata, configutils,
configtypes)
from qutebrowser.keyinput import keyutils
from qutebrowser.utils import standarddir, utils, qtutils, log, urlmatch, version
-from qutebrowser.qt import QtCore
+from qutebrowser.qt import QtWebEngineWidgets, QtCore
if TYPE_CHECKING:
from qutebrowser.misc import savemanager
@@ -117,9 +117,7 @@ class StateConfig(configparser.ConfigParser):
Note that it's too early to use objects.backend here...
"""
- try:
- import qutebrowser.qt # pylint: disable=unused-import
- except ImportError:
+ if not QtWebEngineWidgets:
return 'no'
return str(version.qtwebengine_versions(avoid_init=True).webengine)
diff --git a/tests/conftest.py b/tests/conftest.py
index 0b8a6cd3a..0d3f5b9bb 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -248,11 +248,12 @@ def _select_backend(config):
backend = backend_arg or backend_env or _auto_select_backend()
# Fail early if selected backend is not available
- # pylint: disable=unused-import
if backend == 'webkit':
- import qutebrowser.qt
+ from qutebrowser.qt import QtWebKitWidgets
+ assert QtWebKitWidgets is not None
elif backend == 'webengine':
- import qutebrowser.qt
+ from qutebrowser.qt import QtWebEngineWidgets
+ assert QtWebEngineWidgets is not None
else:
raise utils.Unreachable(backend)
@@ -260,17 +261,18 @@ def _select_backend(config):
def _auto_select_backend():
- # pylint: disable=unused-import
- try:
- # Try to use QtWebKit as the default backend
- import qutebrowser.qt
+ # Try to use QtWebKit as the default backend
+ from qutebrowser.qt import QtWebKitWidgets
+ if QtWebKitWidgets:
return 'webkit'
- except ImportError:
+ from qutebrowser.qt import QtWebEngineWidgets
+ if QtWebEngineWidgets:
# Try to use QtWebEngine as a fallback and fail early
# if that's also not available
- import qutebrowser.qt
return 'webengine'
+ return None
+
def pytest_report_header(config):
if config.webengine: