summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2021-03-17 17:23:45 +0100
committerFlorian Bruhin <me@the-compiler.org>2021-03-17 17:23:45 +0100
commitb062d7364cc9cae43cc25762517fb8fc3d1e97ba (patch)
tree03a2ed252e8f908be883d5d2f56b35e0d7a127b9
parent7b24ac9df77a5601836ceecb1cc39bd54f7792f8 (diff)
downloadqutebrowser-b062d7364cc9cae43cc25762517fb8fc3d1e97ba.tar.gz
qutebrowser-b062d7364cc9cae43cc25762517fb8fc3d1e97ba.zip
Warn about mismatching QtWebEngine versions
See https://github.com/flathub/org.qutebrowser.qutebrowser/issues/11
-rw-r--r--qutebrowser/browser/webengine/webenginesettings.py12
1 files changed, 11 insertions, 1 deletions
diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py
index 830c818fc..090cdfd4c 100644
--- a/qutebrowser/browser/webengine/webenginesettings.py
+++ b/qutebrowser/browser/webengine/webenginesettings.py
@@ -38,7 +38,7 @@ from qutebrowser.browser.webengine import (spell, webenginequtescheme, cookies,
from qutebrowser.config import config, websettings
from qutebrowser.config.websettings import AttributeInfo as Attr
from qutebrowser.utils import (standarddir, qtutils, message, log,
- urlmatch, usertypes, objreg)
+ urlmatch, usertypes, objreg, version)
if TYPE_CHECKING:
from qutebrowser.browser.webengine import interceptor
@@ -374,7 +374,17 @@ def _init_default_profile():
default_profile = QWebEngineProfile.defaultProfile()
+ assert parsed_user_agent is None # avoid earlier profile initialization
+ non_ua_version = version.qtwebengine_versions(avoid_init=True)
+
init_user_agent()
+ ua_version = version.qtwebengine_versions()
+ if ua_version.webengine != non_ua_version.webengine:
+ log.init.warning(
+ "QtWebEngine version mismatch - unexpected behavior might occur, "
+ "please open a bug about this.\n"
+ f" Early version: {non_ua_version}\n"
+ f" Real version: {ua_version}")
default_profile.setCachePath(
os.path.join(standarddir.cache(), 'webengine'))