pylint: Fix new unnecessary-lambda-assignment

5 files changed, 30 insertions, 15 deletions

diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py
index 15729ccdc..adafcd10d 100644
--- a/qutebrowser/browser/webengine/webenginetab.py
+++ b/qutebrowser/browser/webengine/webenginetab.py
@@ -95,7 +95,8 @@ class WebEnginePrinting(browsertab.AbstractPrinting):
 
     def to_printer(self, printer, callback=None):
         if callback is None:
-            callback = lambda _ok: None
+            def callback(_ok):
+                return None
         self._widget.page().print(printer, callback)
 
 
diff --git a/qutebrowser/completion/models/configmodel.py b/qutebrowser/completion/models/configmodel.py
index 7c8473b3f..6c85fbb29 100644
--- a/qutebrowser/completion/models/configmodel.py
+++ b/qutebrowser/completion/models/configmodel.py
@@ -44,16 +44,22 @@ def customized_option(*, info):
 
 def list_option(*, info):
     """A CompletionModel filled with settings whose values are lists."""
-    predicate = lambda opt: (isinstance(info.config.get_obj(opt.name),
-                                        list) and not opt.no_autoconfig)
-    return _option(info, "List options", predicate)
+    return _option(
+        info,
+        "List options",
+        lambda opt: (isinstance(info.config.get_obj(opt.name), list) and
+            not opt.no_autoconfig)
+    )
 
 
 def dict_option(*, info):
     """A CompletionModel filled with settings whose values are dicts."""
-    predicate = lambda opt: (isinstance(info.config.get_obj(opt.name),
-                                        dict) and not opt.no_autoconfig)
-    return _option(info, "Dict options", predicate)
+    return _option(
+        info,
+        "Dict options",
+        lambda opt: (isinstance(info.config.get_obj(opt.name), dict) and
+            not opt.no_autoconfig)
+    )
 
 
 def _option(info, title, predicate):
diff --git a/scripts/dev/run_pylint_on_tests.py b/scripts/dev/run_pylint_on_tests.py
index 28c6e32c9..e044de976 100644
--- a/scripts/dev/run_pylint_on_tests.py
+++ b/scripts/dev/run_pylint_on_tests.py
@@ -64,6 +64,8 @@ def main():
         'import-error',
         # tests/helpers imports
         'wrong-import-order',
+        # __tracebackhide__
+        'unnecessary-lambda-assignment',
     ]
 
     toxinidir = sys.argv[1]
diff --git a/scripts/dev/src2asciidoc.py b/scripts/dev/src2asciidoc.py
index febd2bf8a..1267a278a 100755
--- a/scripts/dev/src2asciidoc.py
+++ b/scripts/dev/src2asciidoc.py
@@ -176,13 +176,15 @@ def _get_setting_quickref():
 
 def _get_configtypes():
     """Get configtypes classes to document."""
-    predicate = lambda e: (
-        inspect.isclass(e) and
-        # pylint: disable=protected-access
-        e not in [configtypes.BaseType, configtypes.MappingType,
-                  configtypes._Numeric, configtypes.FontBase] and
-        # pylint: enable=protected-access
-        issubclass(e, configtypes.BaseType))
+    def predicate(e):
+        return (
+            inspect.isclass(e) and
+            # pylint: disable=protected-access
+            e not in [configtypes.BaseType, configtypes.MappingType,
+                      configtypes._Numeric, configtypes.FontBase] and
+            # pylint: enable=protected-access
+            issubclass(e, configtypes.BaseType)
+        )
     yield from inspect.getmembers(configtypes, predicate)
 
 
diff --git a/tests/unit/utils/test_version.py b/tests/unit/utils/test_version.py
index 7b616d8b7..64df0ece2 100644
--- a/tests/unit/utils/test_version.py
+++ b/tests/unit/utils/test_version.py
@@ -1463,7 +1463,11 @@ def test_uptime(monkeypatch, qapp):
     monkeypatch.setattr(qapp, "launch_time", launch_time, raising=False)
 
     class FakeDateTime(datetime.datetime):
-        now = lambda x=datetime.datetime(1, 1, 1, 1, 1, 1, 2): x
+
+        @classmethod
+        def now(cls, tz=None):
+            return datetime.datetime(1, 1, 1, 1, 1, 1, 2)
+
     monkeypatch.setattr(datetime, 'datetime', FakeDateTime)
 
     uptime_delta = version._uptime()