diff options
| author | brightonanc <brightonanc@gmail.com> | 2022-03-30 19:17:03 -0400 |
|---|---|---|
| committer | brightonanc <brightonanc@gmail.com> | 2023-09-03 14:19:16 -0400 |
| commit | ba58ef4d5517b5f067528b9a567c72c23b5fb576 (patch) | |
| tree | f568ebd263aa80a3d99f0291469c41ffbd4f2619 | |
| parent | a1842e0226613d67ae8ebe8dd288277be3ad300b (diff) | |
| download | qutebrowser-ba58ef4d5517b5f067528b9a567c72c23b5fb576.tar.gz qutebrowser-ba58ef4d5517b5f067528b9a567c72c23b5fb576.zip | |
Fixing two instances of timers accumulating duplicate slots over time
| -rw-r--r-- | qutebrowser/browser/webengine/webenginetab.py | 4 | ||||
| -rw-r--r-- | qutebrowser/keyinput/modeparsers.py | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 54c576ebf..0e97f3505 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -816,6 +816,8 @@ class WebEngineAudio(browsertab.AbstractAudio): page.recentlyAudibleChanged.connect(self._delayed_recently_audible_changed) self._tab.url_changed.connect(self._on_url_changed) config.instance.changed.connect(self._on_config_changed) + self._silence_timer.timeout.connect(functools.partial( + self.recently_audible_changed.emit, False)) # WORKAROUND for recentlyAudibleChanged being emitted without delay from the moment # that audio is dropped. @@ -831,8 +833,6 @@ class WebEngineAudio(browsertab.AbstractAudio): # Ignore all subsequent calls while the tab is muted with an active timer if timer.isActive(): return - timer.timeout.connect( - functools.partial(self.recently_audible_changed.emit, recently_audible)) timer.start() def set_muted(self, muted: bool, override: bool = False) -> None: diff --git a/qutebrowser/keyinput/modeparsers.py b/qutebrowser/keyinput/modeparsers.py index fdb085a1f..7db169097 100644 --- a/qutebrowser/keyinput/modeparsers.py +++ b/qutebrowser/keyinput/modeparsers.py @@ -84,6 +84,7 @@ class NormalKeyParser(CommandKeyParser): self._inhibited = False self._inhibited_timer = usertypes.Timer(self, 'normal-inhibited') self._inhibited_timer.setSingleShot(True) + self._inhibited_timer.timeout.connect(self._clear_inhibited) def __repr__(self) -> str: return utils.get_repr(self) @@ -113,7 +114,6 @@ class NormalKeyParser(CommandKeyParser): timeout)) self._inhibited = True self._inhibited_timer.setInterval(timeout) - self._inhibited_timer.timeout.connect(self._clear_inhibited) self._inhibited_timer.start() @pyqtSlot() |