summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoofar <toofar@spalge.com>2023-12-21 14:07:52 +1300
committertoofar <toofar@spalge.com>2023-12-21 15:21:19 +1300
commitdff25d10bcc8a398a77ef260c33e51ec5c70f482 (patch)
tree38481cac572dc7d701862581be7e522dbce6d3dc
parentdbd0bfbe8e19b173e39b1536a52907eb28557773 (diff)
downloadqutebrowser-dff25d10bcc8a398a77ef260c33e51ec5c70f482.tar.gz
qutebrowser-dff25d10bcc8a398a77ef260c33e51ec5c70f482.zip
Ignore mesa "error" logs
Mesa upgraded from 23.2.1-2 to 23.3.1-1 a couple of days ago. Since then there has been some non-fatal InvalidLine errors in the CI jobs (eg https://github.com/qutebrowser/qutebrowser/actions/runs/7281982007/job/19843511920) Based on https://gitlab.freedesktop.org/mesa/mesa/-/issues/10293 I'm assuming these log messages don't actually indicate errors and the tests pass when they are ignore. Weirdly, I'm only seeing these errors related to the `tests/end2end/test_invocations.py::test_misconfigured_user_dirs` test, I'm not sure why. It doesn't look much different from the ones around it. Possibly we could ignore these lines just for that test, or maybe play round with it more to find out why it is different. But since the lines are non fatal I'll just ignore them everywhere. I'm a little worried about that because they are quite generic, but at least they are still logged when they are ignored. They might change these error logs messages to be warning log messages based on that issue. But it'll probably still fail the tests since we match on all log lines? The "always try zink" change was introduced in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25640 It looks like there might be a `LIBGL_KOPPER_DISABLE` which may skip this behaviour. Not I'm not sure, the commit message says: > don't load non-sw zink without dri3 support > this is going to be broken, so don't bother trying > also add LIBGL_KOPPER_DRI2 so people can continue to footgun if they > really really want to I assume we aren't trying to run with non-sw zink but with non-zink sw? idk Maybe we should be setting force_software_rendering=software-opengl or LIBGL_ALWAYS_SOFTWARE instead so that it never tries to use the vulkan backed zink?
-rw-r--r--tests/end2end/fixtures/quteprocess.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/tests/end2end/fixtures/quteprocess.py b/tests/end2end/fixtures/quteprocess.py
index de9b490ca..0f7204115 100644
--- a/tests/end2end/fixtures/quteprocess.py
+++ b/tests/end2end/fixtures/quteprocess.py
@@ -68,6 +68,12 @@ def is_ignored_lowlevel_message(message):
'driver_name = (null)'
),
'libva error: vaGetDriverNames() failed with unknown libva error',
+
+ # Mesa 23.3
+ # See https://gitlab.freedesktop.org/mesa/mesa/-/issues/10293
+ 'MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER)',
+ 'glx: failed to create drisw screen',
+ 'failed to load driver: zink',
]
return any(testutils.pattern_match(pattern=pattern, value=message)
for pattern in ignored_messages)