diff options
| author | toofar <toofar@spalge.com> | 2023-10-14 15:04:24 +1300 |
|---|---|---|
| committer | toofar <toofar@spalge.com> | 2023-10-14 15:22:09 +1300 |
| commit | a7a2420f02661020bcdea8728a1f846a868f4d56 (patch) | |
| tree | 4dbd9d211dd202b6fa0dc34e95d94480322ecbeb | |
| parent | 2edce1244ae9703950b9bb2a14b6d42c73bbd1a0 (diff) | |
| download | qutebrowser-a7a2420f02661020bcdea8728a1f846a868f4d56.tar.gz qutebrowser-a7a2420f02661020bcdea8728a1f846a868f4d56.zip | |
Bump slack UA quirk for latest update
Slack now requires chrome 112+. At least one user says it still works
with 108 based. Although they did just do a UI refresh so I wouldn't be
surprised if something was broken with older versions.
Note that I'm not 100% sure that slack is actually doing a strict check
for 112, but based on their prior behaviour I assume so (they are
definitely checking for >99 so our old quirk is unhelpful at this
point).
Since I've told people to add ua-slack to their disabled quirks, should
I change the name of it now to make sure it gets re-enabled? Eh, they
can manage their own quirks.
| -rw-r--r-- | doc/changelog.asciidoc | 2 | ||||
| -rw-r--r-- | qutebrowser/browser/webengine/webenginesettings.py | 7 |
2 files changed, 5 insertions, 4 deletions
diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index 8c305350d..cec2f2b84 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -56,6 +56,8 @@ Fixed canvas feature which defaults to enabled on affected Qt versions. (#7489) - The download dialog should no longer freeze when browsing to directories with many files. (#7925) +- The app.slack.com User-Agent quirk now targets chromium 112 on Qt versions + lower than 6.6.0 (previously it always targets chromium 99) (#7951) [[v3.0.0]] v3.0.0 (2023-08-18) diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py index 07324538f..d0b6b5beb 100644 --- a/qutebrowser/browser/webengine/webenginesettings.py +++ b/qutebrowser/browser/webengine/webenginesettings.py @@ -459,10 +459,9 @@ def _init_site_specific_quirks(): # Needed because Slack adds an error which prevents using it relatively # aggressively, despite things actually working fine. - # September 2020: Qt 5.12 works, but Qt <= 5.11 shows the error. - # FIXME:qt6 Still needed? - # https://github.com/qutebrowser/qutebrowser/issues/4669 - ("ua-slack", 'https://*.slack.com/*', maybe_newer_chrome_ua(99)), + # October 2023: Slack claims they only support 112+. On #7951 at least + # one user claims it still works fine on 108 based Qt versions. + ("ua-slack", 'https://*.slack.com/*', maybe_newer_chrome_ua(112)), ] for name, pattern, ua in user_agents: |