summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoofar <toofar@spalge.com>2023-09-25 19:25:39 +1300
committertoofar <toofar@spalge.com>2023-09-27 18:59:27 +1300
commit65bfefe9260ca5a31ef8cae970aaddbf11d6509c (patch)
tree18c775300c13a905d505ad8528406385fa6159b8
parent7b603dd6bf195e3e723ce08ff64a82b406e3f6b6 (diff)
downloadqutebrowser-65bfefe9260ca5a31ef8cae970aaddbf11d6509c.tar.gz
qutebrowser-65bfefe9260ca5a31ef8cae970aaddbf11d6509c.zip
Use mocker fixture instead of mock.patch
I forgot about that fixture.
-rw-r--r--tests/unit/browser/webengine/test_webview.py14
1 files changed, 8 insertions, 6 deletions
diff --git a/tests/unit/browser/webengine/test_webview.py b/tests/unit/browser/webengine/test_webview.py
index 0bc5a8706..7eeec3158 100644
--- a/tests/unit/browser/webengine/test_webview.py
+++ b/tests/unit/browser/webengine/test_webview.py
@@ -7,7 +7,6 @@ import dataclasses
import mimetypes
import pytest
-from unittest import mock
webview = pytest.importorskip('qutebrowser.browser.webengine.webview')
from qutebrowser.qt.webenginecore import QWebEnginePage
@@ -114,17 +113,20 @@ def test_suffixes_workaround_extras_returned(suffix_mocks, before, extra):
@pytest.mark.parametrize("before, extra", EXTRA_SUFFIXES_PARAMS)
-@mock.patch("qutebrowser.browser.webengine.webview.super") # mock super() calls!
def test_suffixes_workaround_choosefiles_args(
- mocked_super,
+ mocker,
suffix_mocks,
config_stub,
before,
extra,
):
- # We can pass the class as "self" because we are only calling a static
- # method of it. That saves us having to initilize the class and mock all
- # the stuff required for __init__()
+ # mock super() to avoid calling into the base class' chooseFiles()
+ # implementation.
+ mocked_super = mocker.patch("qutebrowser.browser.webengine.webview.super")
+
+ # We can pass None as "self" because we aren't actually using anything from
+ # "self" for this test. That saves us having to initialize the class and
+ # mock all the stuff required for __init__()
webview.WebEnginePage.chooseFiles(
None,
QWebEnginePage.FileSelectionMode.FileSelectOpen,