summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2020-12-22 16:59:58 +0100
committerFlorian Bruhin <me@the-compiler.org>2020-12-22 18:19:42 +0100
commit908e891ecc3a8c78e5e1d079b262b1367de9de55 (patch)
treec69e4886071d002721553b406e3ef3d653d17eb4
parent478f0e8f88258fd1d0258177cf45a72e04c44788 (diff)
downloadqutebrowser-908e891ecc3a8c78e5e1d079b262b1367de9de55.tar.gz
qutebrowser-908e891ecc3a8c78e5e1d079b262b1367de9de55.zip
tests: Improve test_version
Test a bit more in test_outdated_adblock, and make sure test_existing_attributes work without `adblock` installed.
-rw-r--r--tests/unit/utils/test_version.py17
1 files changed, 11 insertions, 6 deletions
diff --git a/tests/unit/utils/test_version.py b/tests/unit/utils/test_version.py
index 9f6028a0e..a0aba8bdf 100644
--- a/tests/unit/utils/test_version.py
+++ b/tests/unit/utils/test_version.py
@@ -671,16 +671,21 @@ class TestModuleVersions:
def test_outdated_adblock(self, import_fake):
"""Test that warning is shown when adblock module is outdated."""
- min_version = version.MODULE_INFO["adblock"].min_version
+ mod_info = version.MODULE_INFO["adblock"]
fake_version = "0.1.0"
# Needed after mocking version attribute
- version.MODULE_INFO["adblock"]._reset_cache()
+ mod_info._reset_cache()
- assert min_version is not None
- assert fake_version < min_version
+ assert mod_info.min_version is not None
+ assert fake_version < mod_info.min_version
import_fake.version = fake_version
- expected = f"adblock: {fake_version} (< {min_version}, outdated)"
+
+ assert mod_info.is_installed()
+ assert mod_info.is_outdated()
+ assert not mod_info.is_usable()
+
+ expected = f"adblock: {fake_version} (< {mod_info.min_version}, outdated)"
assert version._module_versions()[6] == expected
@pytest.mark.parametrize('attribute, expected_modules', [
@@ -737,7 +742,7 @@ class TestModuleVersions:
name: The name of the module to check.
has_version: Whether a __version__ attribute is expected.
"""
- module = importlib.import_module(name)
+ module = pytest.importorskip(name)
assert hasattr(module, '__version__') == has_version
def test_existing_sip_attribute(self):