summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoofar <toofar@spalge.com>2022-09-11 12:02:14 +1200
committertoofar <toofar@spalge.com>2022-09-11 17:22:50 +1200
commit5be5b6bb41684cd7620f7168cfe212d0bf6328db (patch)
tree2d428b9e72afc8c0747086016bc14960672c9507
parentdb8cb25bd3bec028b2cc4b2ffa74f408e6bfcd89 (diff)
downloadqutebrowser-5be5b6bb41684cd7620f7168cfe212d0bf6328db.tar.gz
qutebrowser-5be5b6bb41684cd7620f7168cfe212d0bf6328db.zip
mypy: defer to machinery for conditional: QDownloadItem
-rw-r--r--qutebrowser/browser/webengine/webenginedownloads.py11
1 files changed, 5 insertions, 6 deletions
diff --git a/qutebrowser/browser/webengine/webenginedownloads.py b/qutebrowser/browser/webengine/webenginedownloads.py
index 363feeb57..ffacfe8dd 100644
--- a/qutebrowser/browser/webengine/webenginedownloads.py
+++ b/qutebrowser/browser/webengine/webenginedownloads.py
@@ -23,6 +23,7 @@ import re
import os.path
import functools
+from qutebrowser.qt import machinery
from qutebrowser.qt.core import pyqtSlot, Qt, QUrl, QObject
from qutebrowser.qt.webenginecore import QWebEngineDownloadRequest
@@ -44,10 +45,9 @@ class DownloadItem(downloads.AbstractDownloadItem):
parent: QObject = None) -> None:
super().__init__(manager=manager, parent=manager)
self._qt_item = qt_item
- try:
- # Qt 5
+ if machinery.IS_QT5:
qt_item.downloadProgress.connect(self.stats.on_download_progress)
- except AttributeError:
+ else:
# Qt 6
qt_item.receivedBytesChanged.connect(
lambda: self.stats.on_download_progress(
@@ -106,10 +106,9 @@ class DownloadItem(downloads.AbstractDownloadItem):
"{}".format(state_name))
def _do_die(self):
- try:
- # Qt 5
+ if machinery.IS_QT5:
self._qt_item.downloadProgress.disconnect()
- except AttributeError:
+ else:
# Qt 6
self._qt_item.receivedBytesChanged.disconnect()
self._qt_item.totalBytesChanged.disconnect()