summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2022-06-21 19:05:49 +0200
committerFlorian Bruhin <me@the-compiler.org>2022-08-23 18:31:42 +0200
commitb4b5c1d7555bb0eb0f8f62277322a30c437557f3 (patch)
tree33c7914387137950f54552539ef91a8a397f7321
parent7f4f0726291e2af7f57098736280fe3073abbc2c (diff)
downloadqutebrowser-b4b5c1d7555bb0eb0f8f62277322a30c437557f3.tar.gz
qutebrowser-b4b5c1d7555bb0eb0f8f62277322a30c437557f3.zip
build-release: Reenable partial macOS symlinking
See #7252
-rwxr-xr-xscripts/dev/build_release.py19
1 files changed, 10 insertions, 9 deletions
diff --git a/scripts/dev/build_release.py b/scripts/dev/build_release.py
index 189570f8a..975b75c3c 100755
--- a/scripts/dev/build_release.py
+++ b/scripts/dev/build_release.py
@@ -260,18 +260,9 @@ def patch_mac_app(qt6: bool) -> None:
resources_path = contents_path / 'Resources'
pyqt_path = macos_path / f'PyQt{ver}'
- # FIXME:qt6 Bring this back and upstream?
- if qt6:
- return
-
# Replace some duplicate files by symlinks
framework_path = pyqt_path / f'Qt{ver}' / 'lib' / 'QtWebEngineCore.framework'
- core_lib = framework_path / 'Versions' / ('A' if qt6 else '5') / 'QtWebEngineCore'
- core_lib.unlink()
- core_target = pathlib.Path(*[os.pardir] * 7, 'MacOS', 'QtWebEngineCore')
- core_lib.symlink_to(core_target)
-
framework_resource_path = framework_path / 'Resources'
for file_path in framework_resource_path.iterdir():
target = pathlib.Path(*[os.pardir] * 5, file_path.name)
@@ -281,6 +272,16 @@ def patch_mac_app(qt6: bool) -> None:
file_path.unlink()
file_path.symlink_to(target)
+ if qt6:
+ # Symlinking QtWebEngineCore.framework does not seem to work with Qt 6.
+ # Also, the symlinking/moving before signing doesn't seem to be required.
+ return
+
+ core_lib = framework_path / 'Versions' / '5' / 'QtWebEngineCore'
+ core_lib.unlink()
+ core_target = pathlib.Path(*[os.pardir] * 7, 'MacOS', 'QtWebEngineCore')
+ core_lib.symlink_to(core_target)
+
# Move stuff around to make things signable on macOS
# See https://github.com/pyinstaller/pyinstaller/issues/6612
pyqt_path_dest = resources_path / pyqt_path.name