diff options
| author | Florian Bruhin <me@the-compiler.org> | 2020-11-13 10:32:28 +0100 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2020-11-13 10:59:43 +0100 |
| commit | d5ac552f201a85dacf511daab98eb928c4c45f0b (patch) | |
| tree | 6edf5f0b3b85bee88704248406f20f6a0fd4a8da | |
| parent | e2ed55ec2a362b258078a9925368d8515a639b31 (diff) | |
| download | qutebrowser-d5ac552f201a85dacf511daab98eb928c4c45f0b.tar.gz qutebrowser-d5ac552f201a85dacf511daab98eb928c4c45f0b.zip | |
Remove deprecated :inspector
| -rw-r--r-- | doc/changelog.asciidoc | 2 | ||||
| -rw-r--r-- | qutebrowser/components/misccommands.py | 7 | ||||
| -rw-r--r-- | tests/end2end/features/keyinput.feature | 4 | ||||
| -rw-r--r-- | tests/end2end/features/misc.feature | 8 |
4 files changed, 8 insertions, 13 deletions
diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index 20b3e85f7..ceb0e15c9 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -53,6 +53,8 @@ Removed - The `--old` flag for `:config-diff` has been removed. It used to show customized options for the old pre-v1.0 config files (in order to aid migration to v1.0). +- The `:inspector` command which was deprecated in v1.13.0 (in favor of + `:devtools`) is now removed. Changed ~~~~~~~ diff --git a/qutebrowser/components/misccommands.py b/qutebrowser/components/misccommands.py index 19ad126c1..f553fce3b 100644 --- a/qutebrowser/components/misccommands.py +++ b/qutebrowser/components/misccommands.py @@ -343,10 +343,3 @@ def devtools_focus(tab: apitypes.Tab) -> None: tab.data.splitter.cycle_focus() except apitypes.InspectorError as e: raise cmdutils.CommandError(e) - - -@cmdutils.register(deprecated='Use :devtools instead') -@cmdutils.argument('tab', value=cmdutils.Value.cur_tab) -def inspector(tab: apitypes.Tab) -> None: - """Toggle the web inspector.""" - devtools(tab) diff --git a/tests/end2end/features/keyinput.feature b/tests/end2end/features/keyinput.feature index 5dd6ef79d..aa9009f7c 100644 --- a/tests/end2end/features/keyinput.feature +++ b/tests/end2end/features/keyinput.feature @@ -41,10 +41,10 @@ Feature: Keyboard input @no_xvfb @posix @qtwebengine_skip Scenario: :fake-key sending key to the website with other window focused When I open data/keyinput/log.html - And I run :inspector + And I run :devtools And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log And I run :fake-key x - And I run :inspector + And I run :devtools And I wait for "Focus object changed: <qutebrowser.browser.webkit.webview.WebView *>" in the log Then the error "No focused webview!" should be shown diff --git a/tests/end2end/features/misc.feature b/tests/end2end/features/misc.feature index c2733fce7..06dc0b805 100644 --- a/tests/end2end/features/misc.feature +++ b/tests/end2end/features/misc.feature @@ -173,18 +173,18 @@ Feature: Various utility commands. @no_xvfb @posix @qtwebengine_skip Scenario: Inspector smoke test - When I run :inspector + When I run :devtools And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log - And I run :inspector + And I run :devtools And I wait for "Focus object changed: *" in the log Then no crash should happen # Different code path as an inspector got created now @no_xvfb @posix @qtwebengine_skip Scenario: Inspector smoke test 2 - When I run :inspector + When I run :devtools And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log - And I run :inspector + And I run :devtools And I wait for "Focus object changed: *" in the log Then no crash should happen |