aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-11use floating_from="auto" or "user" (and tiling_from) syntaxorestisfl/A_I3_FLOATING_WINDOWMichael Stapelberg
2020-04-10Extend tiling/floating criteria with optional auto/user valuesOrestis Floros
The default `tiling` and `floating` behavior is preserved and matches both cases. Adds a new handler to `remanage_window` on A_I3_FLOATING_WINDOW change. Mainly in order to `run_assignments`, this makes `for_window [floating]` directives to work for windows which where initially opened as tiling. Now, when floating is enabled, `for_window` will trigger correctly. Same applies to `for_window [tiling]`. The obvious solution of `run_assignments` after `floating_{enable,disable}` doesn't work because `run_assignments` modifies the parser state in src/assignments.c:51. Fixes #3588
2020-04-10Merge pull request #4004 from orestisfl/i3bar-segfaultIngo Bürk
Fix SEGFAULT when i3bar receives invalid input
2020-04-10Merge pull request #4003 from orestisfl/update_desktop_properties_on_moveIngo Bürk
Update EWMH properties on workspace move
2020-04-10Merge pull request #4002 from orestisfl/DLOG_CHILDIngo Bürk
i3bar: Add a macro to log child info
2020-04-10Makefile: add bear target for using clangd/ccls language servers (#3953)Michael Stapelberg
After installing clangd and/or ccls (Emacs eglot defaults to ccls), run e.g. make bear -j32 and restart your editor (or just its language server).
2020-04-10Merge pull request #3954 from xzfc/floating-tiling-resizeOrestis Floros
Make floating-tiling resize code consistent with plain tiling resize
2020-04-10Merge pull request #3816 from sandsmark/martin/empty-matchesOrestis Floros
Match empty window properties (e. g. no title set) #3308
2020-04-10Fix SEGFAULT when i3bar receives invalid inputOrestis Floros
Fixes #3844
2020-04-10Update EWMH properties on workspace moveOrestis Floros
Closes #3965 Fixes #4001
2020-04-10Merge pull request #3995 from xzfc/refactor-property-handlersOrestis Floros
Refactor property handlers
2020-04-10i3bar: Add a macro to log child infoOrestis Floros
Mentioned in #3242
2020-04-09Merge pull request #4000 from orestisfl/revert-3983-resize-behind-fullscreenIngo Bürk
Correctly handle mouse resize in fullscreen containers
2020-04-09handle_button_press and route_click do not need to return intOrestis Floros
2020-04-09Do not propagate $mod+right click to clientsOrestis Floros
2020-04-09Avoid resizing fullscreen container with non-fullscreenOrestis Floros
Another option is to modify resize_find_tiling_participants but this would also affect resizing of tiling containers in scripts, so I chose to make this change specific to resizing with the mouse. Follow-up after #3983 Fixes #3980
2020-04-09Revert "Avoid resizing fullscreen container"Orestis Floros
This reverts commit 1a2882d740ecc01312cf26ea5fac608077af7386. As mentioned in https://github.com/i3/i3/issues/3980#issuecomment-611515497, this disables resizing children of fullscreen containers.
2020-04-09Merge pull request #3999 from orestisfl/cmd_focus_sibling_workspace_crashIngo Bürk
cmd_focus_sibling: Fix crash on workspace level
2020-04-09cmd_focus_sibling: Fix crash on workspace levelOrestis Floros
Fixes #3997
2020-04-09Call cont_child() more liberally (#3996)Orestis Floros
Following the reproduction instructions from https://github.com/i3/i3/issues/3242#issuecomment-436175346 For me, #3242 happened when the following sequence executed: 1. Fullscreening window correctly calls `stop_child()` in https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L685 2. Xrandr change, `reconfig_windows()` is called and `output->visible` is set to `true` in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L1791 3. When the window's fullscreen is disabled, `handle_visibility_notify()` returns in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L677 because previously `output->visible` was set to `true` To fix this, I call `cont_child()` more leniently since it is a no-op when the child is not stopped. Fixes #3242 Closes #3761
2020-04-08handlers.c: cb_property_handler_t: take Con instead of xcb_window_tAlbert Safin
Since every handler calls con_by_window_id() and checks for NULL, it is better to move this call into property_notify().
2020-04-08handlers.c: property_notify(): DLOG and return in case of an errorAlbert Safin
2020-04-08handlers.c: remove redundant property fetchingAlbert Safin
Some property handlers trying to fetch property again if `prop == NULL`. This is redundant since these properties are either fetched by property_notify() just before or deleted.
2020-04-08handlers.c: remove unused arguments from cb_property_handler_tAlbert Safin
Also, use `conn` global variable instead of passing it as an argument.
2020-04-07Merge pull request #3985 from orestisfl/userguide-button6-7Orestis Floros
userguide: Add button{6,7}
2020-04-07userguide: Add button{6,7}Orestis Floros
Related to #3984
2020-04-07Merge pull request #3994 from stapelberg/lintianIngo Bürk
check-spelling: update to new Lintian::Profile API
2020-04-07check-spelling: update to new Lintian::Profile APIMichael Stapelberg
This changed between Lintian 2.62.0 and 2.64.0.
2020-03-31Merge pull request #3983 from orestisfl/resize-behind-fullscreenIngo Bürk
Avoid resizing fullscreen container
2020-03-31Avoid resizing fullscreen containerOrestis Floros
Fixes #3980
2020-03-09Merge pull request #3970 from ianyfan/ipcIngo Bürk
ipc: always include marks property in TREE reply
2020-03-07ipc: always include marks property in TREE replyIan Fan
2020-03-01Merge pull request #3964 from ammgws/_PATH_BSHELLIngo Bürk
Use _PATH_BSHELL in nagbar script as well
2020-03-01Fix error messageJason Nader
2020-03-01Use _PATH_BSHELL in nagbar script as wellJason Nader
2020-03-01Merge pull request #3960 from ammgws/patch-2Ingo Bürk
Remove comment referencing old source code
2020-03-01Merge pull request #3961 from ammgws/patch-1Ingo Bürk
i3-nagbar: Use _PATH_BSHELL
2020-03-01Remove comment referencing old source codeJason
Behaviour was changed in f691a55923850a4d315450925fc98733d07b69c9
2020-03-01Use _PATH_BSHELLJason
Possibly overlooked in f691a55923850a4d315450925fc98733d07b69c9?
2020-02-24Assume xcb_cursor_context_new never fails (#3955)xzfc
According to libxcb-cursor code, the only condition in which xcb_cursor_context_new() returns a non-zero result is a memory allocation failure[1]. Thus, it is safe to assume that xcursor_supported is always true, and remove dead code. [1]: https://gitlab.freedesktop.org/xorg/lib/libxcb-cursor/blob/0.1.3/cursor/cursor.c#L131-132
2020-02-22Make floating-tiling resize code consistent with plain tiling resizeAlbert Safin
Now dragging an inner border of a floating split triggers a tiling resize (as expected) instead of a floating resize.
2020-02-22Makefile.am: respect configure --program-suffix (#3944)Michael Stapelberg
related to #3838
2020-02-22Fix test case 180-fd-leaks when running on Fedora (#3911)Joseph
2020-02-21Merge pull request #3950 from xzfc/small-fixesOrestis Floros
Small fixes
2020-02-21Merge pull request #3951 from txtor/nextIngo Bürk
typo
2020-02-21typoFrancesc Hervada-Sala
2020-02-21i3 --moreversion: erase the line before writing overAlbert Safin
The trailing part of the line (`abort…)`) has often been appearing in bug reports.
2020-02-21Limit workspace numbers within 0..INT32_MAXAlbert Safin
Before this commit, large workspace numbers treated oddly: $ i3-msg 'rename workspace to 1234567890' # displayed in i3bar as `0` $ i3-msg 'rename workspace to 4294967200' $ i3-msg -t get_workspaces | jq '.[]|select(.focused).num' -96 # int32_t overflow $ i3-msg 'rename workspace to 99999999999999999999' $ i3-msg -t get_workspaces | jq '.[]|select(.focused).num' -1 # treated as unnumbered This commit puts a consistent limit on workspace numbers. Now workspaces with numbers beyond INT32_MAX are treated as unnumbered.
2020-02-21Code style: fix misaligned and trailing whitespacesAlbert Safin
2020-02-19Merge pull request #3949 from xzfc/overlapOrestis Floros
Sanitize window dimensions and handle decoration overlap