aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Stapelberg <stapelberg@users.noreply.github.com>2022-10-16 16:53:15 +0200
committerMichael Stapelberg <michael@stapelberg.de>2022-10-24 21:12:51 +0200
commite12d2f6a1de3f811bb8b478c55000f727207a66d (patch)
tree98a4bfcae144eedc3fca6f55bed0d278cff0bfb1
parentb88ca36a5a08a895c1565b4d381d599d1ebdf67d (diff)
downloadi3-e12d2f6a1de3f811bb8b478c55000f727207a66d.tar.gz
i3-e12d2f6a1de3f811bb8b478c55000f727207a66d.zip
tiling drag: fix cursor (wrong argument passed) (#5207)
Currently, the cursor is XCURSOR_CURSOR_TOP_RIGHT_CORNER (== BORDER_TOP), but the intended cursor was XCURSOR_CURSOR_MOVE. noticed this as part of https://github.com/i3/i3/issues/5198
-rw-r--r--release-notes/bugfixes/3-drag-cursor1
-rw-r--r--src/tiling_drag.c3
2 files changed, 3 insertions, 1 deletions
diff --git a/release-notes/bugfixes/3-drag-cursor b/release-notes/bugfixes/3-drag-cursor
new file mode 100644
index 00000000..1902dc28
--- /dev/null
+++ b/release-notes/bugfixes/3-drag-cursor
@@ -0,0 +1 @@
+fix tiling drag cursor: should be “move”, accidentally was “top right corner”
diff --git a/src/tiling_drag.c b/src/tiling_drag.c
index cce91f29..6e2a3a31 100644
--- a/src/tiling_drag.c
+++ b/src/tiling_drag.c
@@ -283,7 +283,8 @@ void tiling_drag(Con *con, xcb_button_press_event_t *event) {
xcb_window_t indicator = 0;
const struct callback_params params = {&indicator, &target, &direction, &drop_type};
- drag_result_t drag_result = drag_pointer(con, event, XCB_NONE, BORDER_TOP, XCURSOR_CURSOR_MOVE, drag_callback, &params);
+ const bool use_threshold = true;
+ drag_result_t drag_result = drag_pointer(con, event, XCB_NONE, XCURSOR_CURSOR_MOVE, use_threshold, drag_callback, &params);
/* Dragging is done. We don't need the indicator window any more. */
xcb_destroy_window(conn, indicator);