diff options
author | Reyk Floeter <reyk@esdenera.com> | 2015-01-03 21:06:57 +0100 |
---|---|---|
committer | Reyk Floeter <reyk@esdenera.com> | 2015-01-03 21:06:57 +0100 |
commit | 4f5dd228f08c132afdef71c1a5a124595905d8ae (patch) | |
tree | 653146e322b074f6a796a7b247b8113edcc943df /config.c | |
parent | 461ae7b2ed14e4c38ecf78d791138922a6c050f3 (diff) | |
download | httpd-4f5dd228f08c132afdef71c1a5a124595905d8ae.tar.gz httpd-4f5dd228f08c132afdef71c1a5a124595905d8ae.zip |
In the parent, only open a socket once per unique listen statement.
Fixes possible file descriptor exhaustion on configuration load time.
Diffstat (limited to 'config.c')
-rw-r--r-- | config.c | 15 |
1 files changed, 9 insertions, 6 deletions
@@ -200,7 +200,9 @@ config_setserver(struct httpd *env, struct server *srv) n = -1; proc_range(ps, id, &n, &m); for (n = 0; n < m; n++) { - if ((fd = dup(srv->srv_s)) == -1) + if (srv->srv_s == -1) + fd = -1; + else if ((fd = dup(srv->srv_s)) == -1) return (-1); proc_composev_imsg(ps, id, n, IMSG_CFG_SERVER, fd, iov, c); @@ -211,9 +213,6 @@ config_setserver(struct httpd *env, struct server *srv) } } - close(srv->srv_s); - srv->srv_s = -1; - return (0); } @@ -356,8 +355,12 @@ config_getserver(struct httpd *env, struct imsg *imsg) if ((srv = server_byaddr((struct sockaddr *) &srv_conf.ss, srv_conf.port)) != NULL) { /* Add "host" to existing listening server */ - if (imsg->fd != -1) - close(imsg->fd); + if (imsg->fd != -1) { + if (srv->srv_s == -1) + srv->srv_s = imsg->fd; + else + close(imsg->fd); + } return (config_getserver_config(env, srv, imsg)); } |