aboutsummaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2014-07-01codereview: update name of the a+c toolBrad Fitzpatrick
LGTM=rsc R=rsc, minux CC=golang-codereviews https://golang.org/cl/105480043
2014-06-12lib/codereview: fix doc/go1.*.txt exceptionRuss Cox
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/108950046
2014-06-12codereview: no LGTM needed for doc/go1.x.txtRuss Cox
Rob asked for this change to make maintaining go1.4.txt easier. If you are not sure of a change, it is still okay to send for review. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/109880044
2014-06-05codereview: do not add defaultcc for private CLsRuss Cox
LGTM=r R=r, 0xjnml, bradfitz, iant CC=golang-codereviews https://golang.org/cl/103070046
2014-06-01lib/timezone: update to IANA 2014dRob Pike
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/102040045
2014-05-16lib/time/zoneinfo.zip: update to IANA release 2014cRob Pike
LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://golang.org/cl/93420046
2014-04-29lib/time: update time zone info to v.2014bRobert Hencke
Fixes #7412. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/92850043
2014-02-24codereview: remove unused upload_options.revisionPatrick Mézard
LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/60640052
2014-02-14codereview: fix for Mercurial 2.9Anthony Martin
The branchtags method was removed but we should've been using branchmap all along. http://selenic.com/hg/rev/4274eda143cb LGTM=franciscossouza, r R=golang-codereviews, franciscossouza, r CC=golang-codereviews https://golang.org/cl/57500045
2014-02-13codereview: warn about 'hg upload' not uploadingRuss Cox
This seems to be what causes the 'chunk mismatch' errors. I don't know why the server tells us there's nothing to upload, but at the least we can warn that it did, so that the user will try again. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/62840043
2014-02-10lib/codereview: allow addca CLs without LGTMRuss Cox
LGTM=gri R=golang-codereviews, gri CC=golang-codereviews https://golang.org/cl/61610043
2014-01-23lib/codereview: add LGTM= line to commit messagesRuss Cox
The R= is populated by Rietveld, so it's basically anyone who replied to the CL. The LGTM= is meant to record who actually signed off on the CL. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/55390043
2013-12-20codereview: switch defaultcc to golang-codereviewsRuss Cox
See this thread for background: https://groups.google.com/forum/#!topic/golang-dev/xG7vPi21r8g R=golang-codereviews, gobot, golang-dev, dsymonds CC=golang-codereviews, golang-dev https://golang.org/cl/44450043
2013-10-23plan9: correct create permissions with union directoryJeff Sickel
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/15360045
2013-10-10lib/codereview: return an empty list when CONTRIBUTORS is not found instead ↵Francesc Campoy
of None. R=adg, campoy, r CC=golang-dev https://golang.org/cl/14419059
2013-10-10codereview: fix hg sync closing of CLs for subrepositoriesDominik Honnef
The regexp for closing CLs that were sent by you but committed by someone else only matched messages for the main repository, because of the added &repo=... for subrepositories. R=golang-dev, r CC=golang-dev https://golang.org/cl/14512045
2013-10-08lib/time: update time zone files to version 2013gRob Pike
This dataset is current as of Sep 30, 2013. Fixes #6524 R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14570044
2013-10-07codereview: move dotfiles out of user home director to something sane.Jeff Sickel
See Rob Pike's lesson on shortcuts, https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp R=golang-dev, r, rsc CC=aram.h, golang-dev https://golang.org/cl/14374045
2013-09-06codereview: update use of promptchoice for Mercurial 2.7Anthony Martin
Fixes #6186. R=golang-dev, bradfitz, remyoudompheng, rsc CC=golang-dev https://golang.org/cl/13112043
2013-08-01cmd/godoc: delete from core repositoryAndrew Gerrand
The godoc command now lives at code.google.com/p/go.tools/cmd/godoc. R=golang-dev, r CC=golang-dev https://golang.org/cl/12206044
2013-07-30doc: don't block page load on JavaScript fetchAndrew Gerrand
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/12050045
2013-07-02cmd/godoc: set up playground for examples that are already visibleAndrew Gerrand
This fixes an issue where linking directly to an example makes it not runnable and visible only in a tiny window. To see the bug in action, visit this link: http://golang.org/pkg/strings/#example_Map R=golang-dev, r CC=golang-dev https://golang.org/cl/10679050
2013-06-25codereview: force hg update after hg pull -u during hg syncRuss Cox
If you hg update your client to an earlier CL, then hg sync will move you back to tip if it pulls anything in, but it will leave you where you are if it doesn't pull anything in. That's confusing: make hg sync always update to tip. R=golang-dev, bradfitz, r, dsymonds CC=golang-dev https://golang.org/cl/10456044
2013-06-07godoc: always use local jQuery scriptAndrew Gerrand
Fixes #5075. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/10084044
2013-06-04codereview: don't warn about secret commitsAnthony Martin
Normally the codereview plugin disables adding new commits when not using the submit command. Unfortunately this makes it impossible to use the Mercurial Queues extension at the same time. A feature called "Phases" was introduced in Mercurial 2.1 that allows marking commits as being secret; this means they will never be pushed to the upstream repository. We can take advantage of this feature to allow the use of Mercurial Queues if the mq.secret option has been set in hgrc(5) and a recent version of Mercurial is used. R=golang-dev, rsc, minux.ma CC=golang-dev https://golang.org/cl/7398055
2013-05-22codereview.py: improve error message when user is not a committerFrancesc Campoy
R=adg, bradfitz, r CC=golang-dev https://golang.org/cl/9626045
2013-04-22lib/time: update to IANA 2013cRob Pike
This should do it for the release. There was a new data set pushed out a couple of days ago. Fixes #4553. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8621044
2013-04-02lib/time: update time zone to IANA version 2013bRob Pike
Update #4553. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8293043
2013-04-02cmd/godoc: don't linkify index entriesRobert Griesemer
Fixes #5186. R=bradfitz CC=golang-dev https://golang.org/cl/8267044
2013-03-28cmd/godoc: provide a link from notes to source locationRobert Griesemer
R=golang-dev, r CC=golang-dev https://golang.org/cl/8122043
2013-03-28cmd/godoc: cleanupsRobert Griesemer
- removed gratuitous empty lines that creeped into command line output - changed comment color to a dark green so that links don't visually melt into them - removed some TODOs - updated doc.go R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8108044
2013-03-26godoc: pass *PageInfos instead of *token.FileSets in templatesRobert Griesemer
- convert all formatters that require a *token.FileSet to consistenly use a *PageInfo as first argument instead - adjust templates correspondingly - fix outstanding bug from previous CL 8005044 Going forward, with this change the affected functions have access to the full page "context" (PageInfo), not just the respective file set. This will permit better context-dependent formatting in the future. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7860049
2013-03-26lib/codereview/codereview.py: fix crash when hg gofmt has no filesRob Pike
The gofmt function was returning a string, which isn't the right type. Three cheers for dynamic typing. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7917044
2013-03-19go/doc, godoc: improved note readingRobert Griesemer
- A note doesn't have to be in the first comment of a comment group anymore, and several notes may appear in the same comment group (e.g., it is fairly common to have a TODO(uid) note immediately following another comment). - Define a doc.Note type which also contains note uid and position info. - Better formatting in godoc output. The position information is not yet used, but could be used to locate the note in the source text if desired. Fixes #4843. R=r, cnicolaou CC=gobot, golang-dev https://golang.org/cl/7496048
2013-03-19lib/godoc: convert indentation to tabs.Oling Cat
R=golang-dev, dsymonds, rsc CC=golang-dev https://golang.org/cl/7497048
2013-03-15codereview: re-enable 15-second status printsRuss Cox
Also print all status changes when using hg -v. The start_status_thread call was lost during the refactoring in https://golang.org/cl/5395044/diff/6006/lib/codereview/codereview.py Oops. R=golang-dev, r CC=golang-dev https://golang.org/cl/7834044
2013-03-13cmd/godoc: fix BUGS heading in text modeRuss Cox
All the headings are CAPS not Title. Fixes #4843. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7792043
2013-03-11cmd/godoc: only show package documentation for commandsRobert Griesemer
Fixed package.txt and adjusted package.html to match structure (swapped if branches). Fixes #4861. R=golang-dev, adg, rsc CC=golang-dev https://golang.org/cl/7714043
2013-03-11lib/time: update link in README; draft now an RFCRuss Cox
R=golang-dev, minux.ma, bradfitz CC=golang-dev https://golang.org/cl/7704043
2013-02-25cmd/godoc: add support for display Notes parsed by pkg/go/docCosmos Nicolaou
pkg/go/doc: move BUG notes from Package.Bugs to the general Package.Notes field. Removing .Bugs would break existing code so it's left in for now. R=gri, gri, gary.burd, dsymonds, rsc, kevlar CC=golang-dev https://golang.org/cl/7341053
2013-02-25cmd/godoc: show examples in text modeVolker Dobler
Added the command line flag -ex to godoc to print examples in text output. Samples from the generated output: $ godoc -ex strings Index ... func Index(s, sep string) int Index returns the index of the first instance of sep in s, or -1 if sep is not present in s. Example: fmt.Println(strings.Index("chicken", "ken")) fmt.Println(strings.Index("chicken", "dmr")) // Output: // 4 // -1 ... $ godoc -ex container/heap ... package heap import "container/heap" Package heap provides heap operations for any type that implements heap.Interface. A heap is a tree with the property that each node is the minimum-valued node in its subtree. Example: // This example demonstrates an integer heap built using the heap interface. package heap_test import ( "container/heap" "fmt" ... Example: // This example demonstrates a priority queue built using the heap interface. package heap_test import ( "container/heap" "fmt" ) ... Fixes #3587. R=golang-dev, minux.ma, adg, rsc, gri CC=golang-dev https://golang.org/cl/7356043
2013-02-19cmd/godoc: use go/build to determine package and example filesRobert Griesemer
Also: - faster code for example extraction - simplify handling of command documentation: all "main" packages are treated as commands - various minor cleanups along the way For commands written in Go, any doc.go file containing documentation must now be part of package main (rather then package documentation), otherwise the documentation won't show up in godoc (it will still build, though). For commands written in C, documentation may still be in doc.go files defining package documentation, but the recommended way is to explicitly ignore those files with a +build ignore constraint to define package main. Fixes #4806. R=adg, rsc, dave, bradfitz CC=golang-dev https://golang.org/cl/7333046
2013-02-19codereview: give up on http fetch after 30 secondsRuss Cox
If Python blocks in the SSL handshake it seems to be completely uninterruptible, and I've been seeing it block for at least hours recently. I don't know if the problem is on the client side or the server side or somewhere in the network, but setting the timeout at least means you're guaranteed a new shell prompt (after printing some errors). R=golang-dev, bradfitz, minux.ma CC=golang-dev https://golang.org/cl/7337048
2013-02-14cmd/godoc: add support for doc.Package.NotesCosmos Nicolaou
Add support for displaying the notes of the form 'MARKER(userid): comment' now collected by the go/doc package. Any two or more uppercase letters are recognised as a marker. R=gri, rsc, bradfitz CC=golang-dev https://golang.org/cl/7334044
2013-02-07codereview: use hgapplydiff instead of hgpatchRuss Cox
Depends on https://golang.org/cl/7308067 R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7312064
2013-01-29codereview: show 'not lgtms' in hg p output (with lgtms)Russ Cox
R=golang-dev, iant CC=golang-dev https://golang.org/cl/7245043
2013-01-18lib/godoc: link to Projects wiki page instead of dashboardAndrew Gerrand
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/7139057
2012-12-13lib/godoc/example.html: htmlify the play codeShenghou Ma
Fixes #4539. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6942043
2012-12-11lib/codereview: suggest argument to hg mail / hg submitRuss Cox
R=golang-dev, iant CC=golang-dev https://golang.org/cl/6924050
2012-12-10godoc: move example list into index sectionRuss Cox
Putting it before the Index (where it is now) is wrong: we don't even know what's in the package yet. Fixes #4484. R=adg, dsymonds CC=golang-dev https://golang.org/cl/6868071