aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-01-16weekly.2012-01-15weekly.2012-01-15Andrew Gerrand
R=golang-dev, dsymonds, r, n13m3y3r CC=golang-dev https://golang.org/cl/5543049
2012-01-15exp/terminal: still trying to unbreak non-Linux builds.Adam Langley
R=golang-dev CC=golang-dev https://golang.org/cl/5542050
2012-01-15exp/terminal: add to level Makefile for the (non-Linux?) systems that need it.Adam Langley
R=golang-dev CC=golang-dev https://golang.org/cl/5528102
2012-01-15exp/ssh: patching in the last change lost that a file was deleted.Adam Langley
R=golang-dev CC=golang-dev https://golang.org/cl/5541060
2012-01-15exp/ssh: remove duplicated terminal code.Adam Langley
The terminal code in exp/terminal was forked from the code in exp/ssh. This change removes the duplicated code from exp/ssh in favour of using exp/terminal. R=rsc CC=golang-dev https://golang.org/cl/5375064
2012-01-15http: Allow cookies with negative Max-Age attribute as these areVolker Dobler
allowed by RFC 6265 sec 5.2.2. R=golang-dev, adg CC=golang-dev https://golang.org/cl/5533083
2012-01-15net: platform-dependent default socket optionsMikio Hara
This CL revises existing platform-dependent default socket options to make it possible to accomodate multiple multicast datagram listeners on a single service port. Also removes unnecessary SO_REUSEADDR, SO_REUSEPORT socket options from unicast datagram sockets by default. Fixes #1692. R=devon.odell, alex.brainman, rsc CC=golang-dev https://golang.org/cl/5538052
2012-01-14go/doc: print only one newline between paragraphsRob Pike
Fixes #2595. R=golang-dev, gri CC=golang-dev https://golang.org/cl/5544068
2012-01-14doc: fix comments referring to removed API funcsShenghou Ma
The strconv package has removed Atob, AtoF{64,32} and Ftoa. R=golang-dev, r CC=golang-dev https://golang.org/cl/5540057
2012-01-14gc: do not compile switch on interface values into a binary search.Rémy Oudompheng
Fixes #2672. R=golang-dev, lvd CC=golang-dev, remy https://golang.org/cl/5543058
2012-01-14exp/terminal: add SetPrompt and handle large pastes.Adam Langley
(This was missing in the last change because I uploaded it from the wrong machine.) Large pastes previously misbehaved because the code tried reading from the terminal before checking whether an line was already buffered. Large pastes can cause multiples lines to be read at once from the terminal. R=bradfitz CC=golang-dev https://golang.org/cl/5542049
2012-01-14exp/proxy: new packageAdam Langley
exp/proxy provides client support for tunneling connections through various proxies. This is an initial, incomplete sketch of the code to lay down an API. R=golang-dev, r, r, bradfitz, rsc CC=golang-dev https://golang.org/cl/5490062
2012-01-14net: make use of the kernel state to listen on TCP, UnixMikio Hara
R=golang-dev, dave, minux.ma CC=golang-dev https://golang.org/cl/5545044
2012-01-13cmd/gofmt: fix simplify.go by running gofmt on cmd/gofmtOlivier Duperray
R=golang-dev CC=golang-dev https://golang.org/cl/5539061
2012-01-13go/doc: remove duplicate package commentScott Lawrence
R=golang-dev, gri CC=golang-dev https://golang.org/cl/5528101
2012-01-13pkg/go/doc: fix undefined: doc.NewPackageDoc in headscan.goOlivier Duperray
R=golang-dev, bradfitz, gri CC=golang-dev https://golang.org/cl/5539059
2012-01-13exp/sql: add time.Time supportBrad Fitzpatrick
Fixes #2694 R=golang-dev, r CC=golang-dev https://golang.org/cl/5541057
2012-01-13go/ast: fix typoScott Lawrence
R=golang-dev, r, bradfitz CC=golang-dev https://golang.org/cl/5543056
2012-01-13exp/sql: fix statement leakBrad Fitzpatrick
Also verified in external test suite that this fixes MySQL resource exhaustion problems, and also exposed a double-free bug in the gosqlite3 driver (where gosqlite3 either got lucky before, or was working around this bug) R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5544057
2012-01-13strconv: faster FormatFloat(x, *, -1, 64) using Grisu3 algorithm.Rémy Oudompheng
The implementation is similar to the one from the double-conversion library used in the Chrome V8 engine. old ns/op new ns/op speedup BenchmarkAppendFloatDecimal 591 480 1.2x BenchmarkAppendFloat 2956 486 6.1x BenchmarkAppendFloatExp 10622 503 21.1x BenchmarkAppendFloatNegExp 40343 483 83.5x BenchmarkAppendFloatBig 2798 664 4.2x See F. Loitsch, ``Printing Floating-Point Numbers Quickly and Accurately with Integers'', Proceedings of the ACM, 2010. R=rsc CC=golang-dev, remy https://golang.org/cl/5502079
2012-01-13template: for range on a map, sort the keys if feasible.Rob Pike
Fixes #2696. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5543055
2012-01-14src: make use of runtime.GOOS, GOARCH instead of syscall.OS, ARCHMikio Hara
R=rsc, r CC=golang-dev https://golang.org/cl/5545048
2012-01-13spec: change the wording regarding select statement choiceRob Pike
s/pseudo-random fair/uniform pseudo-random/ This careful word choice soothes the theoretically inclined. R=golang-dev, rsc, gri CC=golang-dev https://golang.org/cl/5528098
2012-01-13bytes: make Write and WriteString code look the sameBrad Fitzpatrick
R=golang-dev, r CC=golang-dev https://golang.org/cl/5540056
2012-01-13time: delete unused buffer.WriteByte methodRob Pike
R=golang-dev, bradfitz, r, rsc CC=golang-dev https://golang.org/cl/5539056
2012-01-13cmd/go: fix data race during buildDmitriy Vyukov
Fixes #2695. R=golang-dev, mpimenov, minux.ma, rsc CC=golang-dev https://golang.org/cl/5545052
2012-01-13godoc: make ?m=src mode deterministicRobert Griesemer
Merge package files in the go/ast MergePackageFiles function always in the same order (sorted by filename) instead of map iteration order to obtain the same package file each time. This functionality is used by godoc when displaying packages in ?m=src mode. Also: minor cleanup in godoc.go. R=rsc CC=golang-dev https://golang.org/cl/5540054
2012-01-13xml: major Go 1 fixupGustavo Niemeyer
This CL improves the xml package in the following ways: - makes its interface match established conventions - brings Marshal and Unmarshal closer together - fixes a large number of bugs and adds tests - improves speed significantly - organizes and simplifies the code Fixes #2426. Fixes #2406. Fixes #1989. What follows is a detailed list of those changes. - All matching is case sensitive without special processing to the field name or xml tag in an attempt to match them. Customize the field tag as desired to match the correct XML elements. - Flags are ",flag" rather than "flag". The names "attr", "chardata", etc, may be used to name actual XML elements. - Overriding of attribute names is possible with "name,attr". - Attribute fields are marshalled properly if they have non-string types. Previously they were unmarshalled, but were ignored at marshalling time. - Comment fields tagged with ",comment" are marshalled properly, rather than being marshalled as normal fields. - The handling of the Any field has been replaced by the ",any" flag to avoid unexpected results when using the field name for other purposes, and has also been fixed to interact properly with name paths. Previously the feature would not function if any field in the type had a name path in its tag. - Embedded struct support fixed and cleaned so it works when marshalling and also when using field paths deeper than one level. - Conflict reporting on field names have been expanded to cover all fields. Previously it'd catch only conflicts of paths deeper than one level. Also interacts correctly with embedded structs now. - A trailing '>' is disallowed in xml tags. It used to be supported for removing the ambiguity between "attr" and "attr>", but the marshalling support for that was broken, and it's now unnecessary. Use "name" instead of "name>". - Fixed docs to point out that a XMLName doesn't have to be an xml.Name (e.g. a struct{} is a good fit too). The code was already working like that. - Fixed asymmetry in the precedence of XML element names between marshalling and unmarshalling. Marshal would consider the XMLName of the field type before the field tag, while unmarshalling would do the opposite. Now both respect the tag of the XMLName field first, and a nice error message is provided in case an attempt is made to name a field with its tag in a way that would conflict with the underlying type's XMLName field. - Do not marshal broken "<???>" tags when in doubt. Use the type name, and error out if that's not possible. - Do not break down unmarshalling if there's an interface{} field in a struct. - Significant speed boost due to caching of type metadata and overall allocation clean ups. The following timings reflect processing of the the atom test data: Old: BenchmarkMarshal 50000 48798 ns/op BenchmarkUnmarshal 5000 357174 ns/op New: BenchmarkMarshal 100000 19799 ns/op BenchmarkUnmarshal 10000 128525 ns/op R=cw, gustavo, kevlar, adg, rogpeppe, fullung, christoph, rsc CC=golang-dev https://golang.org/cl/5503078
2012-01-12godoc: fix missing name changeRobert Griesemer
Fixes godoc text mode (i.e., URL?m=text). R=golang-dev, adg CC=golang-dev https://golang.org/cl/5545043
2012-01-12go/doc: streamlined go/doc APIRobert Griesemer
- the main changes are removing the Doc suffix from the exported types, so instead of doc.TypeDoc one will have doc.Type, etc. - All exported types now have a Name (or Names) field. For Values, the Names field lists all declared variables or constants. - Methods have additional information about where they are coming from. - There's a mode field instead of a bool to control the package's operation, which makes it easier to extend w/o API changes. Except for the partially implemented new Method type, this is based on existing code. A clean rewrite is in progress based on this new API. R=rsc, kevlar CC=golang-dev https://golang.org/cl/5528060
2012-01-12go/doc: initial testing supportRobert Griesemer
R=rsc, adg CC=golang-dev https://golang.org/cl/5533082
2012-01-12go/doc: don't ignore anonymous non-exported fieldsRobert Griesemer
- remove wrapper.go from testing package (not needed anymore) Fixes #1000. R=rsc, golang-dev, n13m3y3r CC=golang-dev https://golang.org/cl/5502074
2012-01-12go/parser: Remove unused Parse* functions. Simplified ParseExpr signature.Robert Griesemer
Only ParseFile, ParseDir, and ParseExpr are used in the tree. If partial parsing of code is required, it is fairly simple to wrap the relevant piece of code into a dummy package for parsing (see parser.ParseExpr). Also: minor cleanups. R=rsc CC=golang-dev https://golang.org/cl/5535055
2012-01-12go/ast: remove unnecessary result value from ast.Fprint/PrintRobert Griesemer
These functions are mostly of interest for debugging; the number of bytes written is uninteresting. R=r, bradfitz CC=golang-dev https://golang.org/cl/5540046
2012-01-12cmd/go: use relative paths in go fix, go fmt, go vet outputRuss Cox
Fixes #2686. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/5528089
2012-01-12cmd/go: handle path to cmd directoryRuss Cox
Now it works to run 'go install' (no args) in cmd/go. Fixes #2679. R=golang-dev, r CC=golang-dev https://golang.org/cl/5543046
2012-01-12fix buildRuss Cox
TBR=gri CC=golang-dev https://golang.org/cl/5528090
2012-01-12cmd/go: handle cgo pkg-config pragmasRuss Cox
Fixes #2681. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5540047
2012-01-12cgo: write _cgo_export.h to object directory, not source dirRuss Cox
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5540048
2012-01-12build: don't use a fixed filename in tempBrad Fitzpatrick
Fixes #2688 R=golang-dev, gri, rsc CC=golang-dev https://golang.org/cl/5539050
2012-01-12json: better error messages when the ,string option is misusedBrad Fitzpatrick
Fixes #2331 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5544045
2012-01-12go/build: pass CgoLDFLAGS at end of link commandRuss Cox
By the time a Unix linker gets to the end of the command line it has forgotten what you told it at the beginning of the command line, so you have to put library arguments (like -lm) at the end. R=golang-dev, r, bradfitz CC=golang-dev https://golang.org/cl/5541043
2012-01-12net/http: don't ignore Request.Write's Flush errorBrad Fitzpatrick
Pointed out by nekotaroh in issue 2645 R=golang-dev, gri CC=golang-dev https://golang.org/cl/5539045
2012-01-12strconv: implement fast path for rounding already short numbers.Rémy Oudompheng
benchmark old ns/op new ns/op delta BenchmarkFormatFloatDecimal 3765 1386 -63% R=rsc CC=golang-dev, remy https://golang.org/cl/5494060
2012-01-12go/doc: move CommentText to ast.CommentGroup's Text methodRuss Cox
Now only godoc imports go/doc. R=gri CC=golang-dev https://golang.org/cl/5541045
2012-01-12strconv: fix round up corner caseRuss Cox
Comment described the correct condition but the code did not implement it. Fixes #2625. R=remyoudompheng CC=golang-dev https://golang.org/cl/5530082
2012-01-12sql: fix potential corruption in QueryRow.Scan into a *[]byteBrad Fitzpatrick
Fixes #2622 R=golang-dev, adg CC=golang-dev https://golang.org/cl/5533077
2012-01-12dashboard: add deployment comment to app.yamlRuss Cox
Also update default app and version to be correct. R=golang-dev, r CC=golang-dev https://golang.org/cl/5541044
2012-01-12go/build: allow colon in #cgo flagsRuss Cox
This makes it possible to say -I c:/foo on Windows. Fixes #2683 comment #3. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5540043
2012-01-12dashboard: use build.golang.org as the domainRob Pike
The domain returned by appengine.DefaultVersionHostname isn't the one we want. This change has been uploaded to build.golang.org R=golang-dev, rsc, r CC=golang-dev https://golang.org/cl/5539043