Age | Commit message (Collapse) | Author |
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5447067
|
|
- scan all comments not just the package documentation
- declutter output so that false positives are more easily spotted
- count the number of headings to quickly see differences
- minor tweaks
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5450061
|
|
Fixes #2512.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5449057
|
|
This covers the lack of IsRegular comfortably:
if stat.Mode()&os.ModeType == 0 { ... }
R=golang-dev, r, rsc, r, gustavo
CC=golang-dev
https://golang.org/cl/5440075
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5449056
|
|
R=dave, agl, rsc, golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5450059
|
|
R=adg, rogpeppe, r, cw
CC=golang-dev
https://golang.org/cl/5450050
|
|
To structure larger sections of comments in html output headings
are detected in comments and formated as h3 in the generated html.
A simple heuristic is used to detect headings in comments:
A heading is a non-blank, non-indented line preceded by a blank
line. It is followed by a blank and a non-blank, non-indented line.
A heading must start with an uppercase letter and end with a letter,
digit or a colon. A heading may not contain punctuation characters.
R=jan.mercl, gri, adg, rsc, r
CC=golang-dev
https://golang.org/cl/5437056
|
|
- correct syscall.CertEnumCertificatesInStore so it returns error
- remove "reflect" dependency
R=hectorchu, agl, rsc
CC=golang-dev, krautz
https://golang.org/cl/5441052
|
|
This is the result of running `gofix -r hashsum` over the tree, changing
the hash function implementations by hand and then fixing a couple of
instances where gofix didn't catch something.
The changed implementations are as simple as possible while still
working: I'm not trying to optimise in this CL.
R=rsc, cw, rogpeppe
CC=golang-dev
https://golang.org/cl/5448065
|
|
This fix adds an output argument to hash.Sum.
Tree changes in https://golang.org/cl/5448065
R=rsc
CC=golang-dev
https://golang.org/cl/5450051
|
|
Makes it clear we're adding exactly one tree and creating a
new template for it.
R=rsc
CC=golang-dev
https://golang.org/cl/5448077
|
|
R=rsc
CC=golang-dev
https://golang.org/cl/5451050
|
|
R=gustav.paul, cw, agl, rsc, n13m3y3r
CC=golang-dev
https://golang.org/cl/5433080
|
|
R=adg
CC=golang-dev
https://golang.org/cl/5447060
|
|
R=r
CC=golang-dev
https://golang.org/cl/5448068
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5448067
|
|
R=rsc
CC=golang-dev
https://golang.org/cl/5440071
|
|
The problem is that execution can modify the template, so it needs
interlocking to have the same thread-safe guarantee as text/template.
Fixes #2439.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5450056
|
|
Pass the tests in tests4.dat.
R=nigeltao
CC=golang-dev
https://golang.org/cl/5447055
|
|
Fixes #2509.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5451055
|
|
Not quite done yet but enough is here to review.
Embedding is eliminated so clients can't accidentally reach
methods of text/template.Template that would break the
invariants.
TODO later: Add and Clone are unimplemented.
TODO later: address issue 2349
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5434077
|
|
Remove the accidentally exported net.Listener
««« original CL description
exp/ssh: remove unused forwarding methods in Server Listener
R=agl, rsc
CC=golang-dev
https://golang.org/cl/5436056
»»»
R=agl, rsc
CC=golang-dev
https://golang.org/cl/5437090
|
|
fixes #2506
R=rsc, iant
CC=golang-dev
https://golang.org/cl/5440066
|
|
TBR=brainman
CC=golang-dev
https://golang.org/cl/5447057
|
|
Sincos via sincos.go is 35.4 ns/op, via sincos_amd64.s is 37.4 ns/op on 2.53 GHz Intel Core 2 Duo (Mac OS X).
R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5447045
|
|
This is not the right fix, but it is what used to happen
before the FileInfo conversion, and it should get the
build working again (at least that part).
TBR=brainman
CC=golang-dev
https://golang.org/cl/5434090
|
|
time.Parse uses time.Local if it has the right zone offset,
otherwise it calls time.FixedZone. The test's use of reflect.DeepEqual
meant that the test expected time.FixedZone always, failing
when the local time zone really would have used -0700 for
that time. The fix is to format the time to display only the
pieces we intend to test.
R=golang-dev, agl, iant
CC=golang-dev
https://golang.org/cl/5437088
|
|
TBR=brainman
CC=golang-dev
https://golang.org/cl/5449048
|
|
This code would panic:
z := big.NewInt(1)
z.SetBit(big.NewInt(0), 2, 1)
if z.Cmp(big.NewInt(1<<2)) != 0 {
panic("fail")
}
R=rsc, gri
CC=golang-dev
https://golang.org/cl/5437081
|
|
R=golang-dev, r, r, gri, bradfitz, iant, iant, nigeltao, n13m3y3r
CC=golang-dev
https://golang.org/cl/5416060
|
|
R=bradfitz, gri, r, dsymonds
CC=golang-dev
https://golang.org/cl/5390042
|
|
R=r, bradfitz, gri, dsymonds, iant
CC=golang-dev
https://golang.org/cl/5392041
|
|
R=andybalholm
CC=golang-dev
https://golang.org/cl/5440064
|
|
Pass tests5.dat, test 10:
<p><xmp></xmp>
| <html>
| <head>
| <body>
| <p>
| <xmp>
Also pass the remaining tests in tests5.dat.
R=nigeltao
CC=golang-dev
https://golang.org/cl/5440062
|
|
Pass tests5.dat, test 4:
<iframe> <!---> </iframe>x
| <html>
| <head>
| <body>
| <iframe>
| " <!---> "
| "x"
Also pass tests through test 9:
<style> <!</-- </style>x
R=nigeltao
CC=golang-dev
https://golang.org/cl/5450044
|
|
R=gri, rsc
CC=golang-dev
https://golang.org/cl/5327053
|
|
Exec to Run.
Exec() has been renamed to Run() in keeping with the os/exec API.
Added func (*Session) Start(cmd string) which starts a remote process but unlike Run() doesn't wait for it to finish before returning.
Run() has been refactored to use Start internally. Its really just a refactoring, no new code but some extra functionality was won.
Also added func (*Session) Signal(sig signal) which sends a UNIX signal to a remote process. This is espcially useful in conjunction with Start() as the two allow you to start a remote process, monitor its stdout/stderr, and send it a TERM/HUP/etc signal when you want it to close.
R=dave, rsc, agl, bradfitz, n13m3y3r, gustavo
CC=golang-dev
https://golang.org/cl/5437058
|
|
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5437079
|
|
R=rsc
CC=golang-dev
https://golang.org/cl/5447043
|
|
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5441053
|
|
R=andybalholm
CC=golang-dev
https://golang.org/cl/5445049
|
|
R=golang-dev
CC=golang-dev
https://golang.org/cl/5445052
|
|
(fixes build)
R=golang-dev, vcc.163
CC=golang-dev
https://golang.org/cl/5445051
|
|
Pass tests3.dat, test 23:
<p><table></table>
| <html>
| <head>
| <body>
| <p>
| <table>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5446043
|
|
Fixes #2251.
R=golang-dev, rsc
CC=golang-dev, jp
https://golang.org/cl/5440050
|
|
goinstall: better error handling and reporting
R=r, r, rsc, mattn.jp
CC=golang-dev
https://golang.org/cl/5421051
|
|
This should make CL 5431046 a little simpler.
R=ken2
CC=golang-dev
https://golang.org/cl/5444048
|
|
R=rsc, golang-dev, r
CC=golang-dev
https://golang.org/cl/5445046
|
|
openChan was only being called by NewSession, Dial has
its own version.
R=gustav.paul, agl, rsc
CC=golang-dev
https://golang.org/cl/5435071
|