aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-11-19weekly.2011-11-18weekly.2011-11-18Andrew Gerrand
R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/5416045
2011-11-18codereview: put message back in post-commit mailsRuss Cox
R=golang-dev, r CC=golang-dev https://golang.org/cl/5417049
2011-11-18syscall: fix env routines for Plan 9Lucio De Re
R=golang-dev CC=ality, golang-dev, rsc https://golang.org/cl/5364063
2011-11-18codereview: undo last night's rollbackRuss Cox
Update version check from 1.4 to 1.9. Suggest 2.0. R=golang-dev, r, r CC=golang-dev https://golang.org/cl/5413046
2011-11-18exp/ssh: Add support for (most) of the ciphers from RFC4253, RFC4344 and ↵John Beisley
RFC4345. R=dave, agl, taruti, rsc, r CC=golang-dev https://golang.org/cl/5342057
2011-11-18Add huin@google.com to the CONTRIBUTORSAdam Langley
R=r CC=golang-dev https://golang.org/cl/5413049
2011-11-18exp/terminal: fix Makefile formatting for deps.bashDmitriy Vyukov
deps.bash does not understand current format, so make.bash fails (with MAKEFLAGS=-j20). R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5410046
2011-11-18undo CL 5395044 / d88e746d3785Andrew Gerrand
Breaks with hg 1.6.4. Roll back until it's fixed. ««« original CL description codereview: cleanup + basic tests R=adg, bradfitz CC=golang-dev https://golang.org/cl/5395044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/5410047
2011-11-17text/template: refactor set parsingRob Pike
Parse {{define}} blocks during template parsing rather than separately as a set-specific thing. This cleans up set parse significantly, and enables the next step, if we want, to unify the API for templates and sets. Other than an argument change to parse.Parse, which is in effect an internal function and unused by client code, there is no API change and no spec change yet. R=golang-dev, rsc, r CC=golang-dev https://golang.org/cl/5393049
2011-11-18codereview: cleanup + basic testsRuss Cox
R=adg, bradfitz CC=golang-dev https://golang.org/cl/5395044
2011-11-18doc: link to Chinese translation of A Tour of GoAndrew Gerrand
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5415046
2011-11-18exp/terminal: fix build after os.Errno changesGustavo Niemeyer
Also include exp/terminal in linux build so such failures are noticed. R=rsc CC=golang-dev https://golang.org/cl/5416044
2011-11-17runtime: add nanotime for Plan 9Anthony Martin
R=paulzhol, rsc, dave, rminnich CC=golang-dev https://golang.org/cl/5327063
2011-11-18html: fix doc after Err method name changeGustavo Niemeyer
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5411045
2011-11-18mime: remove ".wav" from tests (to fix build)Alex Brainman
It looks like not all computers have mime type for .wav extension. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5415045
2011-11-17misc/windows packager development intermediate check-inJoe Poirier
The installer now: allows a user to select an alternative install directory, it now adds a Go folder to the Programs Menu, and it places two shortcuts on the user's desktop. The Program Menu folder contains shortcuts to the uninstaller and two batch files, go.bat and godoc.bat. The desktop shortcuts also point to go.bat and godoc.bat. go.bat sets the Go environment, including Path, and spawns a Window's shell. godoc.bat starts the godoc server at localhost:6060 then spawns a browser window pointing to the document server. Setting the environment temporarily and spawning a shell, via go.bat, should be safer than messing with the system's environment and it makes the user experience a bit more streamlined. The packager does work in its current state but it still needs some polishing. And yes, the plan is to add a dialogue to allow the user to decline the desktop shortcuts. R=rsc, alex.brainman, tjyang2001 CC=golang-dev https://golang.org/cl/5399042
2011-11-18mime: implement TypeByExtension for windowsAlex Brainman
Fixes #2071. R=golang-dev, hcwfrichter, pascal, rsc CC=golang-dev https://golang.org/cl/5369056
2011-11-17godoc: provide mode for flat (non-indented) directory listingsRobert Griesemer
This feature should make it easier to look at very large directory trees. - a new mode (URL: /pkg/?m=flat) shows directory listings w/o indentation and entries with full path (html and text mode) - in text mode, hierarchical (non-flat) directory listings are now presented with indentation (/pkg/?m=text) - in html mode, hierarchical (non-flat) directory listings are presented with slightly less indentation - there is an internal hook for programmatic control of the display mode (for specialized versions of godoc). R=bradfitz CC=golang-dev, rsc https://golang.org/cl/5410043
2011-11-18os: re-enable hostname test on openbsdJoel Sing
Now that Sysctl() works, re-enable the hostname test. R=golang-dev, mikioh.mikioh CC=golang-dev https://golang.org/cl/5408042
2011-11-18syscall: hostname/domainname fix for openbsdJoel Sing
Work around a bug that was fixed after OpenBSD 5.0 - a request for kern.hostname or kern.domainname with a nil value for oldp will result in a length of zero being returned. If we hit this case use a length of MAXHOSTNAMELEN (256). R=golang-dev, mikioh.mikioh CC=golang-dev https://golang.org/cl/5408041
2011-11-17syscall: implement nametomib for openbsd.Joel Sing
Move the existing darwin/freebsd specific nametomib implementation into the respective operating system dependent files. Provide a nametomib implementation for openbsd, which operates on a sysctl MIB that has been pre-generated from the various system headers by mksysctl_openbsd.pl. R=rsc CC=golang-dev https://golang.org/cl/4935044
2011-11-17html: parse <isindex>Andrew Balholm
Pass tests2.dat, test 42: <isindex test=x name=x> | <html> | <head> | <body> | <form> | <hr> | <label> | "This is a searchable index. Enter search keywords: " | <input> | name="isindex" | test="x" | <hr> R=nigeltao CC=golang-dev https://golang.org/cl/5399049
2011-11-17http: fix serving from CWD with http.ServeFileAndrew Gerrand
http: make Dir("") equivalent to Dir(".") Fixes #2471. R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/5370061
2011-11-17exp/ssh: change test listen address, also exit test if failsAlex Brainman
R=golang-dev, rsc CC=dave, golang-dev https://golang.org/cl/5364061
2011-11-16reflect: make Value an opaque structRuss Cox
Making Value opaque means we can drop the interface kludges in favor of a significantly simpler and faster representation. v.Kind() will be a prime candidate for inlining too. On a Thinkpad X201s using -benchtime 10: benchmark old ns/op new ns/op delta json.BenchmarkCodeEncoder 284391780 157415960 -44.65% json.BenchmarkCodeMarshal 286979140 158992020 -44.60% json.BenchmarkCodeDecoder 717175800 388288220 -45.86% json.BenchmarkCodeUnmarshal 734470500 404548520 -44.92% json.BenchmarkCodeUnmarshalReuse 707172280 385258720 -45.52% json.BenchmarkSkipValue 24630036 18557062 -24.66% benchmark old MB/s new MB/s speedup json.BenchmarkCodeEncoder 6.82 12.33 1.81x json.BenchmarkCodeMarshal 6.76 12.20 1.80x json.BenchmarkCodeDecoder 2.71 5.00 1.85x json.BenchmarkCodeUnmarshal 2.64 4.80 1.82x json.BenchmarkCodeUnmarshalReuse 2.74 5.04 1.84x json.BenchmarkSkipValue 77.92 103.42 1.33x I cannot explain why BenchmarkSkipValue gets faster. Maybe it is one of those code alignment things. R=iant, r, gri, r CC=golang-dev https://golang.org/cl/5373101
2011-11-16gofmt: do not stop test.sh after 1 errorRuss Cox
Fix bug377.go to be gofmt-compliant. R=gri, r, r CC=golang-dev https://golang.org/cl/5400045
2011-11-17html: parse </optgroup> and </option>Andrew Balholm
Pass tests2.dat, test 35: <!DOCTYPE html><select><optgroup><option></optgroup><option><select><option> | <!DOCTYPE html> | <html> | <head> | <body> | <select> | <optgroup> | <option> | <option> | <option> Also pass tests through test 41: <!DOCTYPE html><!-- XXX - XXX - XXX --> R=nigeltao, rsc CC=golang-dev https://golang.org/cl/5395045
2011-11-16exp/ssh: fix test?Russ Cox
Fixes use of c after Dial failure (causes crash). May fix Dial failure by listening to 127.0.0.1:0 instead of 0.0.0.0:0 (tests should only listen on localhost). R=golang-dev, gri CC=golang-dev https://golang.org/cl/5395052
2011-11-16go/printer: make //line formatting idempotentRuss Cox
Fixes "test.sh" (long test) in src/cmd/gofmt. R=gri CC=golang-dev https://golang.org/cl/5307081
2011-11-16syscall, os, time: fix Plan 9 buildLucio De Re
R=rsc, bradfitz CC=golang-dev https://golang.org/cl/5371092
2011-11-16exp/ssh: add to pkg MakefileChristopher Wedgwood
R=rsc, dave CC=golang-dev https://golang.org/cl/5399045
2011-11-16gc: support for building with Plan 9 yaccAnthony Martin
I've modified Plan 9's yacc to work with the grammar in go.y. These are the only changes necessary on the Go side. R=rsc CC=golang-dev https://golang.org/cl/5375104
2011-11-16go/ast: remove unused receiver names (cleanup)Robert Griesemer
R=iant, iant CC=golang-dev https://golang.org/cl/5393047
2011-11-16cov: fix for Plan 9 buildLucio De Re
R=golang-dev CC=golang-dev, rsc https://golang.org/cl/5374086
2011-11-16net/http: fix EOF handling on response bodyGustavo Niemeyer
http.Response is currently returning 0, nil on EOF. R=golang-dev, bradfitz, bradfitz CC=golang-dev https://golang.org/cl/5394047
2011-11-16fcgi: fix server capability discoveryBrad Fitzpatrick
The wrong length was being sent, and two parameters were also transposed. Made the record type be a type and made the constants typed, to prevent that sort of bug in the future. Fixes #2469 R=golang-dev, edsrzf CC=golang-dev https://golang.org/cl/5394046
2011-11-16html/template: indirect top-level values before printingRob Pike
text/template does this (in an entirely different way), so make html/template do the same. Before this fix, the template {{.}} given a pointer to a string prints its address instead of its value. R=mikesamuel, r CC=golang-dev https://golang.org/cl/5370098
2011-11-16exp/ssh: fix unmarshal testDave Cheney
Ensure that empty NameLists always return a zero length []string, not nil. In practice NameLists are only used in a few message types and always consumed by a for range function so the difference between nil and []string{} is not significant. Also, add exp/ssh to pkg/Makefile as suggested by rsc. R=rsc, agl CC=golang-dev https://golang.org/cl/5400042
2011-11-16html: parse <optgroup> tagsAndrew Balholm
Pass tests2.dat, test 34: <!DOCTYPE html><select><option><optgroup> | <!DOCTYPE html> | <html> | <head> | <body> | <select> | <option> | <optgroup> R=nigeltao CC=golang-dev https://golang.org/cl/5393045
2011-11-16html: parse <caption> elementsAndrew Balholm
Pass tests2.dat, test 33: <!DOCTYPE html><table><caption>test TEST</caption><td>test | <!DOCTYPE html> | <html> | <head> | <body> | <table> | <caption> | "test TEST" | <tbody> | <tr> | <td> | "test" R=nigeltao CC=golang-dev https://golang.org/cl/5371099
2011-11-15exp/sql: NumInput() allow -1 to ignore checking.Yasuhiro Matsumoto
Some database driver can't get number of parameters. For example: http://support.microsoft.com/kb/240205/en-us So, added way to ignore checking number of parameters with return -1. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5376091
2011-11-15sql: document that for drivers, io.EOF means no more rowsBrad Fitzpatrick
This was used in the sql package + tests, but never documented. R=golang-dev, gri CC=golang-dev https://golang.org/cl/5372107
2011-11-16net, syscall: add missing copyright noticesMikio Hara
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5375099
2011-11-15os: fix comment per CL 5370091Russ Cox
Made the edit in the wrong client before submitting. TBR=r CC=golang-dev https://golang.org/cl/5374091
2011-11-15os: fix windows buildRuss Cox
TBR=brainman CC=golang-dev https://golang.org/cl/5373105
2011-11-15encoding/json: make BenchmarkSkipValue more consistentRuss Cox
Move scanner allocation out of loop. It's the only allocation in the test so it dominates when it triggers a garbage collection. R=golang-dev, r CC=golang-dev https://golang.org/cl/5369117
2011-11-15misc/emacs: add delete builtinBobby Powers
R=golang-dev, mpimenov, gri CC=golang-dev https://golang.org/cl/5370101
2011-11-15testing: print test results to standard outputRuss Cox
Errors in the code under test go to standard output. Errors in testing or its usage go to standard error. R=r CC=golang-dev https://golang.org/cl/5374090
2011-11-15misc/benchcmp: benchmark comparison scriptRuss Cox
I've been using this since April and posted it on the mailing list, but it seems worth having in the repository. Not sure about the location. R=golang-dev, r, r CC=golang-dev https://golang.org/cl/5371100
2011-11-15syscall: make windows build again after d3963c0fca78 changeAlex Brainman
R=rsc, mikioh.mikioh CC=golang-dev https://golang.org/cl/5373097