aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-10-26weekly.2011-10-25weekly.2011-10-25Andrew Gerrand
R=rsc CC=golang-dev https://golang.org/cl/5321053
2011-10-26html: improve parsing of listsAndrew Balholm
Make a <li> tag close the previous <li> element. Make a </ul> tag close <li> elements. Pass tests1.dat, test 33: <!DOCTYPE html><li>hello<li>world<ul>how<li>do</ul>you</body><!--do--> | <!DOCTYPE html> | <html> | <head> | <body> | <li> | "hello" | <li> | "world" | <ul> | "how" | <li> | "do" | "you" | <!-- do --> R=nigeltao CC=golang-dev https://golang.org/cl/5321051
2011-10-26html: improve parsing of tablesAndrew Balholm
When foster parenting, merge adjacent text nodes. Properly close table row at </tr> tag. Pass tests1.dat, test 32: <!-----><font><div>hello<table>excite!<b>me!<th><i>please!</tr><!--X--> | <!-- - --> | <html> | <head> | <body> | <font> | <div> | "helloexcite!" | <b> | "me!" | <table> | <tbody> | <tr> | <th> | <i> | "please!" | <!-- X --> R=nigeltao CC=golang-dev https://golang.org/cl/5323048
2011-10-25syscall: correct name of mksyscall script in commentIan Lance Taylor
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5310055
2011-10-25runtime: include bootstrap m in mcpu accountingHector Chu
R=rsc, dvyukov CC=golang-dev https://golang.org/cl/5307052
2011-10-24http: doc typoBrad Fitzpatrick
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5303067
2011-10-24syscall: use uintptr for Mount flags.David Anderson
R=bradfitz, rsc CC=golang-dev https://golang.org/cl/5308044
2011-10-25html: remove the Tokenizer.ReturnComments option.Nigel Tao
The original intention was to simplify the parser, in making it skip all comment tokens. However, checking that the Go html package is 100% compatible with the WebKit HTML test suite requires parsing the comments. There is no longer any real benefit for the option. R=gri, andybalholm CC=golang-dev https://golang.org/cl/5321043
2011-10-24exp/ssh: introduce Session to replace Cmd for interactive commandsDave Cheney
This CL replaces the Cmd type with a Session type representing interactive channels. This lays the foundation for supporting other kinds of channels like direct-tcpip or x11. client.go: * replace chanlist map with slice. * generalize stdout and stderr into a single type. * unexport ClientChan to clientChan. doc.go: * update ServerConfig/ServerConn documentation. * update Client example for Session. message.go: * make channelExtendedData more like channelData. session.go: * added Session which replaces Cmd. R=agl, rsc, n13m3y3r, gustavo CC=golang-dev https://golang.org/cl/5302054
2011-10-25html: dump attributes when running parser tests.Andrew Balholm
The WebKit test data shows attributes as though they were child nodes: <a X>0<b>1<a Y>2 dumps as: | <html> | <head> | <body> | <a> | x="" | "0" | <b> | "1" | <b> | <a> | y="" | "2" So we need to do the same when dumping a tree to compare with it. R=nigeltao CC=golang-dev https://golang.org/cl/5322044
2011-10-24http: add package commentBrad Fitzpatrick
Fixes #2378 R=rsc CC=golang-dev https://golang.org/cl/5312052
2011-10-24net: do not set SO_REUSEADDR for windowsAlex Brainman
Fixes #2307. R=golang-dev, mikioh.mikioh CC=golang-dev https://golang.org/cl/5306049
2011-10-23html: implement foster parentingAndrew Balholm
Implement the foster-parenting algorithm for content that is inside a table but not in a cell. Also fix a bug in reconstructing the active formatting elements. Pass test 30 in tests1.dat: <a><table><td><a><table></table><a></tr><a></table><b>X</b>C<a>Y R=nigeltao CC=golang-dev https://golang.org/cl/5309052
2011-10-22html: parse <select> tags.Nigel Tao
The additional test case in parse_test.go is: <select><b><option><select><option></b></select>X R=andybalholm CC=golang-dev https://golang.org/cl/5293051
2011-10-21big: usable zero Rat values without need for explicit initializationRobert Griesemer
- no explicit API change, but new(big.Rat) now creates a big.Rat value of 0 that is immediately usable, in sync. w/ the conventions elsewhere - various cleanups along the way R=r CC=golang-dev https://golang.org/cl/5301056
2011-10-21fmt: simplify the code some more by storing the field in the pp structure.Rob Pike
R=rsc CC=golang-dev https://golang.org/cl/5293058
2011-10-21big: implemented Rat.InvRobert Griesemer
Also: - changed semantics of return values for [Int|Rat].SetString if an error occured (returned value is nil); will expose hidden errors where return values are not checked - added more tests - various cleanups throughout Fixes #2384. R=r CC=golang-dev https://golang.org/cl/5312044
2011-10-21gotest: make it easier to get the help stringRob Pike
Because gotest's args are mingled with the tests, it's hard to get the usage message to print. This CL adds explicit support for -help, spelled several different ways. Gotest has special flags like -file that are somewhat hidden otherwise. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5298052
2011-10-21http: Transport: with TLS InsecureSkipVerify, skip hostname checkBrad Fitzpatrick
Fixes #2386 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5312045
2011-10-21exp/ssh: server cleanupsDave Cheney
server.go/channel.go: * rename Server to ServerConfig to match Client. * rename ServerConnection to ServeConn to match Client. * add Listen/Listener. * ServerConn.Handshake(), general cleanups. client.go: * fix bug where fmt.Error was not assigned to err R=rsc, agl CC=golang-dev https://golang.org/cl/5265049
2011-10-20exp/ssh: add experimental ssh clientDave Cheney
Requires CL 5285044 client.go: * add Dial, ClientConn, ClientChan, ClientConfig and Cmd. doc.go: * add Client documentation. server.go: * adjust for readVersion change. transport.go: * return an os.Error not a bool from readVersion. R=rsc, agl, n13m3y3r CC=golang-dev https://golang.org/cl/5162047
2011-10-20go/ast: use single-element map in testRobert Griesemer
Avoids test failure due to undefined map iteration order. R=rsc, iant, iant CC=golang-dev https://golang.org/cl/5297048
2011-10-20go/ast, go/token: actually run tests; fix go/ast testIan Lance Taylor
R=gri CC=golang-dev https://golang.org/cl/5292048
2011-10-20exp/winfsnotify: fix testHector Chu
R=alex.brainman, mattn.jp CC=golang-dev https://golang.org/cl/5311047
2011-10-20html: parse and render comment nodes.Nigel Tao
The first additional test case in parse_test.go is: <!--><div>--<!--> The second one is unrelated to the comment change, but also passes: <p><hr></p> R=andybalholm CC=golang-dev https://golang.org/cl/5299047
2011-10-19misc/vim: add highlighting for deleteDave Cheney
R=golang-dev, n13m3y3r CC=golang-dev https://golang.org/cl/5303050
2011-10-19fmt: don't panic formatting nil interfacesGustavo Niemeyer
R=golang-dev, r CC=golang-dev https://golang.org/cl/5296044
2011-10-19govet: check canonical dynamic method signaturesRuss Cox
Adds check that, for example, a Scan method taking a first argument of type fmt.ScanState has the correct signature to satisfy fmt.Scanner. Similarly, a ReadByte should return byte, os.Error. These are important to check because various pieces of code (fmt, gob, json, flate) do dynamic checks for these methods, so code with incorrect signatures would not be flagged at compile time. These become even more important to check when rune is introduced. R=r CC=golang-dev https://golang.org/cl/5305044
2011-10-19unicode: sort tables.goRuss Cox
Makes tables.go output consistent across maketable runs. (It was already inconsistent across architectures; the new map iteration order just make it inconsistent across runs.) R=r CC=golang-dev https://golang.org/cl/5303046
2011-10-19codereview: show LGTMs in hg pRuss Cox
Shows first line of any response that the codereview server has identified as an LGTM. Example output below. 5305046: big: update for fmt interface changes Nothing terribly interesting here. Reviewer: gri@golang.org gri: LGTM CC: golang-dev@googlegroups.com Files: src/pkg/big/int.go src/pkg/big/nat.go src/pkg/big/nat_test.go src/pkg/big/rat.go 5307044: exp/template/html: use rune Nothing terribly interesting here. Reviewer: mikesamuel@gmail.com, nigeltao@golang.org mikesamuel: I don't see a type def for rune. Assuming that's a new intrinsic, LGTM. CC: golang-dev@googlegroups.com Files: src/pkg/exp/template/html/css.go src/pkg/exp/template/html/css_test.go src/pkg/exp/template/html/html.go src/pkg/exp/template/html/js.go R=golang-dev, r CC=golang-dev https://golang.org/cl/5297045
2011-10-19gotest: use $GCFLAGS like make doesRuss Cox
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5297044
2011-10-19exp/types: fix crash in parseBasicType on unknown typeRuss Cox
R=gri CC=golang-dev https://golang.org/cl/5302044
2011-10-19crypto/x509: fix names in certificate generation.Adam Langley
I had a brain fart in af84b15fbae2 and messed up the names in generated certificates. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/5315046
2011-10-19http: comment tweaksBrad Fitzpatrick
It hasn't been primitive in a while. R=golang-dev, adg CC=golang-dev https://golang.org/cl/5287041
2011-10-19syscall: update ztypes_linux_386 for terminal changesBrad Fitzpatrick
R=golang-dev, dave, iant CC=golang-dev https://golang.org/cl/5299045
2011-10-19syscall: update ztypes_linux_arm for terminal changesDave Cheney
regenerated on a debian sid arm5 host. R=bradfitz, iant CC=golang-dev https://golang.org/cl/5298046
2011-10-19os/inotify: move to exp/inotifyMikio Hara
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5295044
2011-10-19tag weekly.2011-10-18Andrew Gerrand
R=golang-dev CC=golang-dev https://golang.org/cl/5292045
2011-10-19weekly.2011-10-18weekly.2011-10-18Andrew Gerrand
R=rsc CC=golang-dev https://golang.org/cl/5302041
2011-10-19html: fix escape_test.go for CSS escaper change 5306042.Nigel Tao
R=mikesamuel CC=golang-dev https://golang.org/cl/5313044
2011-10-18fmt: clean up after reflect.Interface change.Rob Pike
Store the reflect.Value in the internal print state. Code is simpler, cleaner, and a little faster - back to what it was before the change. R=golang-dev, iant CC=golang-dev https://golang.org/cl/5299046
2011-10-18rpc: don't panic on write error.Rob Pike
The mechanism to record the error in the call is already in place. Fixes #2382. R=golang-dev, dsymonds, bradfitz, r CC=golang-dev https://golang.org/cl/5307043
2011-10-18exp/template/html: fix bug in cssEscaperMike Samuel
cssEscaper escapes using the CSS convention: `\` + hex + optional-space It outputs the space when the escape could be followed by a hex digit to distinguish a "\na" from "\u00aa". It did not output a space when the escape is followed by a space character so did not distinguish "\n " from "\n". Currently when doing lookahead, it does not distinguish spaces that will be escaped later by the same function from ones that will not. This is correct but suboptimal. R=nigeltao CC=golang-dev https://golang.org/cl/5306042
2011-10-19http: add test for panic inside hijacked requestAndrew Gerrand
R=golang-dev, rsc, rsc CC=golang-dev https://golang.org/cl/5283052
2011-10-19html: parse raw text and RCDATA elements, such as <script> and <title>.Nigel Tao
Pass tests1.dat, test 26: #data <script><div></script></div><title><p></title><p><p> #document | <html> | <head> | <script> | "<div>" | <title> | "<p>" | <body> | <p> | <p> Thanks to Andy Balholm for driving this change. R=andybalholm CC=golang-dev https://golang.org/cl/5301042
2011-10-18ld: modify macho linkedit segment to enable OS X code signingMikkel Krautz
Move string table to the end of the __LINKEDIT segment. This change allows Apple's codesign(1) utility to successfully sign Go binaries, as long as they don't contain DWARF data (-w flag to 8l/6l). This is because codesign(1) expects the string table to be the last part of the file. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5271050
2011-10-18godoc: generate package toc in template, not in JavaScriptRuss Cox
1. Generate TOC for package pages using template, instead of using JavaScript magic. This makes the pages generated by godoc -html easier to export to other systems. 2. Make TOC one column. It's hard to do two columns portably without invoking JavaScript. 3. Since the TOC is only one column, show full type signatures for functions and methods. Many times that's all you need to see anyway. 4. Name the section after the TOC "Overview". Naming it something is important, to set it off from the TOC and so that there's a quick link to it in the TOC. For now, some illustrative examples: http://swtch.com:6060/pkg/io/ http://swtch.com:6060/pkg/strings/ http://swtch.com:6060/pkg/tabwriter/ http://swtch.com:6060/pkg/unicode/ Fixes #1982. R=gri, bradfitz, r CC=golang-dev https://golang.org/cl/5303044
2011-10-18exp/winfsnotify: filesystem watcher for WindowsHector Chu
R=rsc, alex.brainman, bradfitz CC=bsiegert, go.peter.90, golang-dev https://golang.org/cl/4188047
2011-10-185l, 6l, 8l: correct ELFRESERVE diagnosticAnthony Martin
If the length of the interpreter string pushes us over the ELFRESERVE limit, the resulting error message will be comical. I was doing some ELF tinkering with a modified version of 8l when I hit this. To be clear, the stock linkers wouldn't hit this without adding about forty more section headers. We're safe for now. ;) Also, remove a redundant call to cflush. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5268044
2011-10-186l, 8l: emit macho dwarf info before linkedit sectionMikkel Krautz
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5272050