aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-09-08weekly.2011-09-07weekly.2011-09-07Andrew Gerrand
R=dsymonds, rsc, r CC=golang-dev https://golang.org/cl/4968070
2011-09-07undo CL 4964067 / 661cb84cc6f0Robert Griesemer
API change. Needs further reflection. ««« original CL description path/filepath: Simplify Walk interface The last argument of filepath.Walk was removed, and the Visitor interface now contains an Error method that is called on errors. Fixes #2237. R=golang-dev, gri, r CC=golang-dev https://golang.org/cl/4964067 »»» R=r CC=golang-dev https://golang.org/cl/4974065
2011-09-07path/filepath: Simplify Walk interfaceGustavo Niemeyer
The last argument of filepath.Walk was removed, and the Visitor interface now contains an Error method that is called on errors. Fixes #2237. R=golang-dev, gri, r CC=golang-dev https://golang.org/cl/4964067
2011-09-07gc: add -p flag to catch import cycles earlierRuss Cox
The linker would catch them if gc succeeded, but too often the cycle manifests as making the current package and the imported copy of itself appear as different packages, which result in type signature mismatches that confuse users. As a crutch, add the -p flag to say 'if you see an import of this package, give up early'. Results in messages like (during gotest in sort): export_test.go:7: import "sort" while compiling that package (import cycle) export_test.go:7: import "container/heap": package depends on "sort" (import cycle) Fixes #2042. R=ken CC=bradfitz, dsymonds, golang-dev https://golang.org/cl/4972057
2011-09-07net: sync CIDRMask code, docRuss Cox
R=golang-dev, r CC=golang-dev https://golang.org/cl/4961069
2011-09-075a, 5c, 6a, 6c, 8a, 8c: fix Windows file pathsHector Chu
Verified with objdump -W. R=alex.brainman, rsc CC=golang-dev https://golang.org/cl/4974061
2011-09-07exp/regexp: bug fixes and RE2 testsRuss Cox
Also add exp/regexp to build (forgot before). At this point I am very confident in exp/regexp's behavior. It should be usable as a drop-in replacement for regexp now. Later CLs could introduce a CompilePOSIX to get at traditional POSIX ``extended regular expressions'' as in egrep and also an re.MatchLongest method to change the matching mode to leftmost longest instead of leftmost first. On the other hand, I expect very few people to use either. R=r, r, gustavo CC=golang-dev https://golang.org/cl/4990041
2011-09-07net: ParseCIDR returns IPNet instead of IPMaskMikio Hara
Note that this CL will break your existing code which uses ParseCIDR. This CL changes ParseCIDR("172.16.253.121/28") to return the IP address "172.16.253.121", the network implied by the network number "172.16.253.112" and mask "255.255.255.240". R=rsc, borman CC=golang-dev https://golang.org/cl/4749043
2011-09-07gc: silence Plan 9 warningsLucio De Re
R=golang-dev CC=golang-dev, rsc https://golang.org/cl/4975055
2011-09-07sort: use heapsort to bail out quicksortZiad Hatahet
See http://research.swtch.com/2008/01/killing-quicksort.html for more info. Fixes #467. R=r, rsc CC=golang-dev https://golang.org/cl/4591051
2011-09-07gopprof: regexp fixesHector Chu
Extract Windows filenames correctly. Don't remove receivers from method names. Fixes #2227. R=rsc CC=golang-dev https://golang.org/cl/4969059
2011-09-07A+C: Ziad Hatahet (individual CLA)Russ Cox
R=golang-dev, r CC=golang-dev https://golang.org/cl/4964066
2011-09-07sync/atomic: add Store functionsDmitriy Vyukov
R=rsc CC=golang-dev https://golang.org/cl/4950060
2011-09-07image/png: check zlib checksum during DecodeRuss Cox
R=nigeltao CC=golang-dev https://golang.org/cl/4987041
2011-09-07gc: treat DOTMETH like DOT in escape analysis.Luuk van Dijk
Fixes #2225 R=rsc, nigeltao, dave CC=bradfitz, golang-dev, mikioh.mikioh https://golang.org/cl/4972056
2011-09-07weekly.html: remove note about exp/template -> template move.David Symonds
It actually occurred with the previous weekly snapshot. R=golang-dev, adg CC=golang-dev https://golang.org/cl/4961066
2011-09-06cleanup: gofmt -s -w src miscRobert Griesemer
R=r CC=golang-dev https://golang.org/cl/4984052
2011-09-06template: slightly simplify the test for assignability of argumentsRob Pike
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4951066
2011-09-06template: indirect or dereference function arguments if necessary to match ↵Rob Pike
the type of the formal. Fixes #2235 R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4967056
2011-09-06go/parser: accept corner cases of signature syntaxRobert Griesemer
- func f(int,) is a legal signature - func f(...int,) is a legal signature Defer checking for correct use of "..." with last paremeter type to type checker instead of parser. R=rsc CC=golang-dev https://golang.org/cl/4973059
2011-09-06gofmt: indent multi-line signaturesRobert Griesemer
There may be more fine-tuning down the line, but this CL fixes the most pressing issue at hand. Also: gofmt -w src misc Fixes #1524. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/4975053
2011-09-06url: handle ; in ParseQueryRuss Cox
Most web frameworks allow ; as a synonym for &, following a recommendation in some versions of the HTML specification. Do the same. Remove overuse of Split. Move ParseQuery tests from package http to package url. Fixes #2210. R=golang-dev, r CC=golang-dev https://golang.org/cl/4973062
2011-09-06gc: unify stack frame layoutRuss Cox
allocparams + tempname + compactframe all knew about how to place stack variables. Now only compactframe, renamed to allocauto, does the work. Until the last minute, each PAUTO variable is in its own space and has xoffset == 0. This might break 5g. I get failures in concurrent code running under qemu and I can't tell whether it's 5g's fault or qemu's. We'll see what the real ARM builders say. R=ken2 CC=golang-dev https://golang.org/cl/4973057
2011-09-06os: use GetFileAttributesEx to implement Stat on windowsAlex Brainman
Fixes #2129. R=rsc CC=golang-dev https://golang.org/cl/4934049
2011-09-05gc: fix zero-length struct evalRuss Cox
Fixes #2232. R=ken2 CC=golang-dev https://golang.org/cl/4960054
2011-09-05exp/norm: performance improvements of quickSpanMarcel van Lohuizen
- fixed performance bug that could lead to O(n^2) behavior - performance improvement for ASCII case R=r, r CC=golang-dev https://golang.org/cl/4956060
2011-09-05runtime: fix openbsd 386 raisesigpipeJoel Sing
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4950064
2011-09-05syscall: update routing message attributes handling, fix typoMikio Hara
R=fullung, golang-dev, rsc CC=golang-dev https://golang.org/cl/4986041
2011-09-05build: clear execute bit from Go filesMike Rosset
R=golang-dev, rsc CC=golang-dev, mike.rosset https://golang.org/cl/4950062
2011-09-05runtime: add test for multiple concurrent channel consumersChristopher Wedgwood
There was a time (in the past) when this wasn't robust. R=rsc, dvyukov CC=golang-dev https://golang.org/cl/4965058
2011-09-05misc/goplay: another template fixAndrew Gerrand
Fixes #2219. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4950063
2011-09-05gobuilder: ignore _test.go files when looking for docs, more loggingAndrew Gerrand
R=n13m3y3r CC=golang-dev https://golang.org/cl/4918050
2011-09-05websocket: fix incorrect prints found by govetRobert Hencke
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4963059
2011-09-05misc/goplay: Fix template outputAndrew Gerrand
Fixes #2219. R=golang-dev, r CC=golang-dev https://golang.org/cl/4960052
2011-09-03gofix: do not convert url in field namesGustavo Niemeyer
There's some ambiguity in the U{url: url} case as it could be both a map or a struct literal, but given context it's more likely a struct, so U{url: url_} rather than U{url_: url_}. At least that was the case for me. R=golang-dev, rsc, adg CC=golang-dev https://golang.org/cl/4972052
2011-09-03runtime: implement exception handling on windows/amd64Hector Chu
Fixes #2194. R=rsc, alex.brainman, vcc.163, jp CC=golang-dev https://golang.org/cl/4977044
2011-09-03exp/template/html: string replacement refactoring.Nigel Tao
R=mikesamuel CC=golang-dev https://golang.org/cl/4968063
2011-09-02gc: introduce temp = nod+tempnameRuss Cox
R=ken2 CC=golang-dev https://golang.org/cl/4967052
2011-09-02gc: zero stack-allocated slice backing arraysRuss Cox
Fixes Han-Wen's termite bug. R=lvd CC=golang-dev https://golang.org/cl/4977052
2011-09-02godoc: minor tweaks for app-engine useRobert Griesemer
- read search index files in groutine to avoid start-up failure on app engine because reading the files takes too long - permit usage of search index files and indexer - minor cosmetic cleanups R=dsymonds CC=golang-dev https://golang.org/cl/4952050
2011-09-02exp/norm: added Reader and Writer and bug fixes to support these.Marcel van Lohuizen
Needed to ensure that finding the last boundary does not result in O(n^2)-like behavior. Now prevents lookbacks beyond 31 characters across the board (starter + 30 non-starters). composition.go: - maxCombiningCharacters now means exactly that. - Bug fix. - Small performance improvement/ made code consistent with other code. forminfo.go: - Bug fix: ccc needs to be 0 for inert runes. normalize.go: - A few bug fixes. - Limit the amount of combining characters considered in FirstBoundary. - Ditto for LastBoundary. - Changed semantics of LastBoundary to not consider trailing illegal runes a boundary as long as adding bytes might still make them legal. trie.go: - As utf8.UTFMax is 4, we should treat UTF-8 encodings of size 5 or greater as illegal. This has no impact on the normalization process, but it prevents buffer overflows where we expect at most UTFMax bytes. R=r CC=golang-dev https://golang.org/cl/4963041
2011-09-02fmt/fmt_test.go: count mallocs in a few more cases.Rob Pike
Interesting that Fprintf can do zero mallocs. (Sprintf must allocate the returned string.) R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/4977049
2011-09-02template: fix deadlock.Rob Pike
No need for lexInsideAction to loop. Fixes #2217. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/4963054
2011-09-02exp/template/html: non-semantics changing tweaks to js{,_test}.goMike Samuel
R=nigeltao CC=golang-dev https://golang.org/cl/4962049
2011-09-02goinstall: better usage messageAndrew Gerrand
Fixes #2185. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4967046
2011-09-01sync/atomic: add LoadUintptrDmitriy Vyukov
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4985041
2011-09-01gc: fix label recursion bugsRuss Cox
Was keeping a pointer to the labeled statement in n->right, which meant that generic traversals of the tree visited it twice. That combined with aggressive flattening of the block structure when possible during parsing meant that the kinds of label: code label: code label: code sequences generated by yacc were giving the recursion 2ⁿ paths through the program. Fixes #2212. R=lvd CC=golang-dev https://golang.org/cl/4960050
2011-09-01libmach: fix incorrect use of memsetDave Cheney
Fixes #2213. R=rsc CC=golang-dev https://golang.org/cl/4975047
2011-09-01tag weekly.2011-09-01Nigel Tao
R=r CC=golang-dev https://golang.org/cl/4968057
2011-09-01sudo.bash: print error/exit if problem with /usr/local/binMike Rosset
When installing profiling tools on Mac OS X print message if there is a problem with /usr/local/bin Fixes #2209. R=golang-dev, r, adg CC=golang-dev, mike.rosset https://golang.org/cl/4950057