aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-16runtime: fix stale comment in lfstackgo1.7beta2Austin Clements
Change-Id: I6ef08f6078190dc9df0b2df4f26a76456602f5e8 Reviewed-on: https://go-review.googlesource.com/24176 Reviewed-by: Rick Hudson <rlh@golang.org>
2016-06-16cmd/dist: make zosarch.go deterministicAustin Clements
Currently zosarch.go is written out in non-deterministic map order. Sort the keys and write it out in sorted order to make the generated file contents deterministic. Change-Id: Id490f0e8665a2c619c5a7a00a30f4fc64f333258 Reviewed-on: https://go-review.googlesource.com/24174 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-16internal/trace: err if binary is not supplied for old traceHana Kim
Change-Id: Id25c90993c4cbb7449d7031301b6d214a67d7633 Reviewed-on: https://go-review.googlesource.com/24134 Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Run-TryBot: Dmitry Vyukov <dvyukov@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-16runtime: remove useless loop from CgoCCodeSIGPROF test programIan Lance Taylor
I verified that the test fails if I undo the change that it tests for. Updates #14732. Change-Id: Ib30352580236adefae946450ddd6cd65a62b7cdf Reviewed-on: https://go-review.googlesource.com/24151 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
2016-06-15go/ast: fix comments misinterpreted as documentationMatthew Dempsky
The comments describing blocks of Pos/End implementations for various nodes types are being misinterpreted as documentation for BadDecl, BadExpr, BadStmt, and ImportSpec's Pos methods. Change-Id: I935b0bc38dbc13e9305f3efeb437dd3a6575d9a1 Reviewed-on: https://go-review.googlesource.com/24152 Reviewed-by: Robert Griesemer <gri@golang.org>
2016-06-15runtime: if the test program hangs, try to get a stack traceIan Lance Taylor
This is an attempt to get more information for #14809, which seems to occur rarely. Updates #14809. Change-Id: Idbeb136ceb57993644e03266622eb699d2685d02 Reviewed-on: https://go-review.googlesource.com/24110 Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by: Austin Clements <austin@google.com>
2016-06-15syscall: skip TestUnshare if kernel does not support net namespaceCherry Zhang
Fixes #16056. Change-Id: Ic3343914742713851b8ae969b101521f25e85e7b Reviewed-on: https://go-review.googlesource.com/24132 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-15net/http: pass through server side Transfer-Encoding headersAndrew Gerrand
Fixes #16063 Change-Id: I2e8695beb657b0aef067e83f086828d8857787ed Reviewed-on: https://go-review.googlesource.com/24130 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-15context: document how to release resources associated with Contexts.Sameer Ajmani
Some users don't realize that creating a Context with a CancelFunc attaches a subtree to the parent, and that that subtree is not released until the CancelFunc is called or the parent is canceled. Make this clear early in the package docs, so that people learning about this package have the right conceptual model. Change-Id: I7c77a546c19c3751dd1f3a5bc827ad106dd1afbf Reviewed-on: https://go-review.googlesource.com/24090 Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-14net: don't run TestLookupDotsWithLocalSource in short modeIan Lance Taylor
Do run it on the builders, though. Fixes #15881. Change-Id: Ie42204d553cb18547ffd6441afc261717bbd9205 Reviewed-on: https://go-review.googlesource.com/24111 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-14os: fix blockUntilWaitable on freebsd/{386,arm}Mikio Hara
The previous fix was wrong because it had two misunderstandings on freebsd32 calling convention like the following: - 32-bit id1 implies that it is the upper half of 64-bit id, indeed it depends on machine endianness. - 32-bit ARM calling convension doesn't conform to freebsd32_args, indeed it does. This change fixes the bugs and makes blockUntilWaitable work correctly on freebsd/{386,arm}. Fixes #16064. Change-Id: I820c6d01d59a43ac4f2ab381f757c03b14bca75e Reviewed-on: https://go-review.googlesource.com/24064 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-14cmd/compile, etc: handle many struct fieldsDavid Crawshaw
This adds 8 bytes of binary size to every type that has methods. It is the smallest change I could come up with for 1.7. Fixes #16037 Change-Id: Ibe15c3165854a21768596967757864b880dbfeed Reviewed-on: https://go-review.googlesource.com/24070 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-14crypto/x509: don't ignore asn1.Marshal errorIan Lance Taylor
I don't see how the call could fail, so, no test. Just a code cleanup in case it can fail in the future. Fixes #15987. Change-Id: If4af0d5e7d19cc8b13fb6a4f7661c37fb0015e83 Reviewed-on: https://go-review.googlesource.com/23860 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
2016-06-14cmd/go: include .syso files even if CGO_ENABLED=0Ian Lance Taylor
A .syso file may include information that should go into the object file that is not object code, and should be included even if not using cgo. The example in the issue is a Windows manifest file. Fixes #16050. Change-Id: I1f4f3f80bb007e84d153ca2d26e5919213ea4f8d Reviewed-on: https://go-review.googlesource.com/24032 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
2016-06-14cmd/go: remove obsolete comment referring to deleted parameterIan Lance Taylor
The dir parameter was removed in https://golang.org/cl/5732045. Fixes #15503. Change-Id: I02a6d8317233bea08633715a095ea2514822032b Reviewed-on: https://go-review.googlesource.com/24011 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <shurcool@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
2016-06-14os: fix build on freebsd/armMikio Hara
Change-Id: I21fad94ff94e342ada18e0e41ca90296d030115f Reviewed-on: https://go-review.googlesource.com/24061 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-13os: use wait6 to avoid wait/kill race on freebsdMikio Hara
This change is a followup to https://go-review.googlesource.com/23967 for FreeBSD. Updates #13987. Updates #16028. Change-Id: I0f0737372fce6df89d090fe9847305749b79eb4c Reviewed-on: https://go-review.googlesource.com/24021 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-13os: use waitid to avoid wait/kill race on darwinMikio Hara
This change is a followup to https://go-review.googlesource.com/23967 for Darwin. Updates #13987. Updates #16028. Change-Id: Ib1fb9f957fafd0f91da6fceea56620e29ad82b00 Reviewed-on: https://go-review.googlesource.com/24020 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-13runtime: collect stack trace if SIGPROF arrives on non-Go threadIan Lance Taylor
Fixes #15994. Change-Id: I5aca91ab53985ac7dcb07ce094ec15eb8ec341f8 Reviewed-on: https://go-review.googlesource.com/23891 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-13cmd/link: put padding between functions, not at the end of a functionKeith Randall
Functions should be declared to end after the last real instruction, not after the last padding byte. We achieve this by adding the padding while assembling the text section in the linker instead of adding the padding to the function symbol in the compiler. This change makes dtrace happy. TODO: check that this works with external linking Fixes #15969 Change-Id: I973e478d0cd34b61be1ddc55410552cbd645ad62 Reviewed-on: https://go-review.googlesource.com/24040 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-12cmd/compile: fix OASWB rewriting in racewalkDavid Chase
Special case for rewriting OAS inits omitted OASWB, added that and OAS2FUNC. The special case cannot be default case, that causes racewalk to fail in horrible ways. Fixes #16008. Change-Id: Ie0d2f5735fe9d8255a109597b36d196d4f86703a Reviewed-on: https://go-review.googlesource.com/23954 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-12cmd/go: remove invalid space in import comment docsDmitri Shuralyov
Generate package comment in alldocs.go using line comments rather than general comments. This scales better, general comments cannot contain the "*/" character sequence. Line comments do not have any restrictions on the comment text that can be contained. Remove the dependency on sed, which is not cross-platform, not go-gettable external command. Remove trailing whitespace from usage string in test.go. It's unnecessary. Fixes #16030. Change-Id: I3c0bc9955e7c7603c3d1fb4878218b0719d02e04 Reviewed-on: https://go-review.googlesource.com/23968 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-11runtime: aeshash, xor seed in earlierKeith Randall
Instead of doing: x = input one round of aes on x x ^= seed two rounds of aes on x Do: x = input x ^= seed three rounds of aes on x This change provides some additional seed-dependent scrambling which should help prevent collisions. Change-Id: I02c774d09c2eb6917cf861513816a1024a9b65d7 Reviewed-on: https://go-review.googlesource.com/23577 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-10os: on GNU/Linux use waitid to avoid wait/kill raceIan Lance Taylor
On systems that support the POSIX.1-2008 waitid function, we can use it to block until a wait will succeed. This avoids a possible race condition: if a program calls p.Kill/p.Signal and p.Wait from two different goroutines, then it is possible for the wait to complete just before the signal is sent. In that case, it is possible that the system will start a new process using the same PID between the wait and the signal, causing the signal to be sent to the wrong process. The Process.isdone field attempts to avoid that race, but there is a small gap of time between when wait returns and isdone is set when the race can occur. This CL avoids that race by using waitid to wait until the process has exited without actually collecting the PID. Then it sets isdone, then waits for any active signals to complete, and only then collects the PID. No test because any plausible test would require starting enough processes to recycle all the process IDs. Update #13987. Update #16028. Change-Id: Id2939431991d3b355dfb22f08793585fc0568ce8 Reviewed-on: https://go-review.googlesource.com/23967 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-10go/parser: document that parse functions need valid token.FileSetRobert Griesemer
+ panic with explicit error if no file set it provided (Not providing a file set is invalid use of the API; panic is the appropriate action rather than returning an error.) Fixes #16018. Change-Id: I207f5b2a2e318d65826bdd9522fce46d614c24ee Reviewed-on: https://go-review.googlesource.com/24010 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-10cmd/go: clarify go get documentationIan Lance Taylor
Make the documentation for `go get` match the documentation for `go install`, since `go get` essentially invokes `go install`. Update #15825. Change-Id: I374d80efd301814b6d98b86b7a4a68dd09704c92 Reviewed-on: https://go-review.googlesource.com/23925 Reviewed-by: Andrew Gerrand <adg@golang.org>
2016-06-10syscall: add a padding field to EpollEvent on s390xMichael Munday
Fixes #16021. Change-Id: I55df38bbccd2641abcb54704115002a9aa04325d Reviewed-on: https://go-review.googlesource.com/23962 Run-TryBot: Michael Munday <munday@ca.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-10encoding/csv: update doc about comments whitespaceJess Frazelle
This patch updates the doc about comments whitespace for the encoding/csv package to reflect that leading whitespace before the hash will treat the line as not a comment. Fixes #13775. Change-Id: Ia468c75b242a487b4b2b4cd3d342bfb8e07720ba Reviewed-on: https://go-review.googlesource.com/23302 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-06-09runtime: set $sp before $pc in gdb python scriptCherry Zhang
When setting $pc, gdb does a backtrace using the current value of $sp, and it may complain if $sp does not match that $pc (although the assignment went through successfully). This happens with ARM SSA backend: when setting $pc it prints > Cannot access memory at address 0x0 As well as occasionally on MIPS64: > warning: GDB can't find the start of the function at 0xc82003fe07. > ... Setting $sp before setting $pc makes it happy. Change-Id: Idd96dbef3e9b698829da553c6d71d5b4c6d492db Reviewed-on: https://go-review.googlesource.com/23940 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com>
2016-06-09cmd/compile: for tail calls in stubs, ensure args are aliveKeith Randall
The generated code for interface stubs sometimes just messes with a few of the args and then tail-calls to the target routine. The args that aren't explicitly modified appear to not be used. But they are used, by the thing we're tail calling. Fixes #16016 Change-Id: Ib9b3a8311bb714a201daee002885fcb59e0463fa Reviewed-on: https://go-review.googlesource.com/23960 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
2016-06-09cmd/cgo: fix use of unsafe argument in new deferred functionIan Lance Taylor
The combination of https://golang.org/cl/23650 and https://golang.org/cl/23675 did not work--they were tested separately but not together. The problem was that 23650 introduced deferred argument checking, and the deferred function loses the type that 23675 started requiring. The fix is to go back to using an empty interface type in a deferred argument check. No new test required--fixes broken build. Change-Id: I5ea023c5aed71d70e57b11c4551242d3ef25986d Reviewed-on: https://go-review.googlesource.com/23961 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
2016-06-09cmd/cgo: use function arg type for _cgoCheckPointerN functionIan Lance Taylor
When cgo writes a _cgoCheckPointerN function to handle unsafe.Pointer, use the function's argument type rather than interface{}. This permits type errors to be detected at build time rather than run time. Fixes #13830. Change-Id: Ic7090905e16b977e2379670e0f83640dc192b565 Reviewed-on: https://go-review.googlesource.com/23675 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
2016-06-09time: document that RFC822/1123 don't parse all RFC formatsIan Lance Taylor
Fixes #14505. Change-Id: I46196b26c9339609e6e3ef9159de38c5b50c2a1b Reviewed-on: https://go-review.googlesource.com/23922 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
2016-06-09time: genzabbrs.go skips Feb when checking monthsKenny Grant
getAbbrs looks like it is checking each month looking for a change in the time zone abbreviation, but starts in Dec of the previous year and skips the month of February because of the overflow rules for AddDate. Changing the day to 1 starts at Jan 1 and tries all months in the current year. This isn't very important or likely to change output as zones usually span several months. Discovered when looking into time.AddDate behavior when adding months. Change-Id: I685254c8d21c402ba82cc4176e9a86b64ce8f7f7 Reviewed-on: https://go-review.googlesource.com/23322 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-09crypto/subtle: expand abbreviation to eliminate confusionJason Barnett
Change-Id: I68d66fccf9cc8f7137c92b94820ce7d6f478a185 Reviewed-on: https://go-review.googlesource.com/23310 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-09os: document that the runtime can write to standard errorIan Lance Taylor
Fixes #15970. Change-Id: I3f7d8316069a69d0e3859aaa96bc1414487fead0 Reviewed-on: https://go-review.googlesource.com/23921 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
2016-06-09cmd/go: only run TestGoGetHTTPS404 where it worksIan Lance Taylor
The test TestGoGetHTTPS404 downloads a package that does not build on every OS, so change it to only run where the package builds. It's not great for the test to depend on an external package, but this is an improvement on the current situation. Fixes #15644. Change-Id: I1679cee5ab1e61a5b26f4ad39dc8a397fbc0da69 Reviewed-on: https://go-review.googlesource.com/23920 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
2016-06-08cmd/compile: nilcheck interface value in go/defer interface call for SSACherry Zhang
This matches the behavior of the legacy backend. Fixes #15975 (if this is the intended behavior) Change-Id: Id277959069b8b8bf9958fa8f2cbc762c752a1a19 Reviewed-on: https://go-review.googlesource.com/23820 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-08runtime/cgo: restore the g pointer correctly in crosscall_s390xMichael Munday
R13 needs to be set to g because C code may have clobbered R13. Fixes #16006. Change-Id: I66311fe28440e85e589a1695fa1c42416583b4c6 Reviewed-on: https://go-review.googlesource.com/23910 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-08misc/android: make the exec wrapper exit code parsing more robustElias Naur
Before, the Android exec wrapper expected the trailing exit code output on its own line, like this: PASS exitcode=0 However, some tests can sometimes squeeze in some output after the test harness outputs "PASS" and the newline. The TestWriteHeapDumpFinalizers test is particularly prone to this, since its finalizers println to standard out. When it happens, the output looks like this: PASS finalizedexitcode=0 Two recent failures caused by this race: https://build.golang.org/log/185605e1b936142c22350eef22d20e982be53c29 https://build.golang.org/log/e61cf6a050551d10360bd90be3c5f58c3eb07605 Since the "exitcode=" string is always echoed after the test output, the fix is simple: instead of looking for the last newline in the output, look for the last exitcode string instead. Change-Id: Icd6e53855eeba60b982ad3108289d92549328b86 Reviewed-on: https://go-review.googlesource.com/23750 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
2016-06-08misc/cgo/testsanitizers: don't run some TSAN tests on GCC < 7Ian Lance Taylor
Before GCC 7 defined __SANITIZE_THREAD__ when using TSAN, runtime/cgo/libcgo.h could not determine reliably whether TSAN was in use when using GCC. Fixes #15983. Change-Id: I5581c9f88e1cde1974c280008b2230fe5e971f44 Reviewed-on: https://go-review.googlesource.com/23833 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
2016-06-08net/http: update bundled http2Andrew Gerrand
Updates x/net/http2 to git rev 313cf39 for CLs 23812 and 23880: http2: GotFirstResponseByte hook should only fire once http2: fix data race on pipe Fixes #16000 Change-Id: I9c3f1b2528bbd99968aa5a0529ae9c5295979d1d Reviewed-on: https://go-review.googlesource.com/23881 Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
2016-06-08cmd/compile: cgen_append can handle complex targetsKeith Randall
Post-liveness fix, the slices on both sides can now be indirects of & variables. The cgen code handles those cases just fine. Fixes #15988 Change-Id: I378ad1d5121587e6107a9879c167291a70bbb9e4 Reviewed-on: https://go-review.googlesource.com/23863 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
2016-06-07cmd/compile: fix heap dump test on androidKeith Randall
go_android_exec is looking for "exitcode=" to decide the result of running a test. The heap dump test nondeterministically prints "finalized" right at the end of the test. When the timing is just right, we print "finalizedexitcode=0" and confuse go_android_exec. This failure happens occasionally on the android builders. Change-Id: I4f73a4db05d8f40047ecd3ef3a881a4ae3741e26 Reviewed-on: https://go-review.googlesource.com/23861 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
2016-06-07cmd/compile: use fake package for allocating autosKeith Randall
Make sure auto names don't conflict with function names. Before this CL, we confused name a.len (the len field of the slice a) with a.len (the function len declared on a). Fixes #15961 Change-Id: I14913de697b521fb35db9a1b10ba201f25d552bb Reviewed-on: https://go-review.googlesource.com/23789 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-07cmd/dist: use "set" instead of "export" in diagnostic messageAndrew Gerrand
On Windows, "export" doesn't mean anything, but Windows users are the most likely to see this message. Fixes #15977 Change-Id: Ib09ca08a7580713cacb65d0cdc43730765c377a8 Reviewed-on: https://go-review.googlesource.com/23840 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-06net/http: send StatusOK on empty body with TimeoutHandlerAndrew Gerrand
Fixes #15948 Change-Id: Idd79859b3e98d61cd4e3ef9caa5d3b2524fd026a Reviewed-on: https://go-review.googlesource.com/23810 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-06time: warn about correct use of a Timer's Stop/Reset methodsAndrew Gerrand
Updates #14038 Fixes #14383 Change-Id: Icf6acb7c5d13ff1d3145084544c030a778482a38 Reviewed-on: https://go-review.googlesource.com/23575 Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-06net/http: send one Transfer-Encoding header when "chunked" set manuallyAndrew Gerrand
Fixes #15960 Change-Id: I7503f6ede33e6a1a93cee811d40f7b297edf47bc Reviewed-on: https://go-review.googlesource.com/23811 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-06-05runtime: fix typoKeith Randall
Fixes #15962 Change-Id: I1949e0787f6c2b1e19b9f9d3af2f712606a6d4cf Reviewed-on: https://go-review.googlesource.com/23786 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion