aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-04-21strings: fix off-by-one error in testgo1.3beta1Rui Ueyama
Previously it would panic because of out-of-bound access if s1 is longer than s2. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/90110043
2014-04-21math/big: fix Int.ExpRobert Griesemer
Fixes #7814. LGTM=agl, adonovan R=agl, adonovan CC=golang-codereviews https://golang.org/cl/90080043
2014-04-21net: extend TestVariousDeadlines1Proc timeoutJosh Bleecher Snyder
TestVariousDeadlines1Proc was flaky on my system, failing on about 5% of runs. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/89830045
2014-04-21runtime: fix typo in error messageMark Zavislak
LGTM=robert.hencke, iant R=golang-codereviews, robert.hencke, iant CC=golang-codereviews https://golang.org/cl/89760043
2014-04-21runtime/race: add test for issue 7561.Rémy Oudompheng
LGTM=dvyukov R=rsc, iant, khr, dvyukov CC=golang-codereviews https://golang.org/cl/76520045
2014-04-21cmd/nm: do not fail TestNM if symbol has less then 3 columns in nm outputAlex Brainman
Fixes #7829 LGTM=dave R=golang-codereviews, aram, dave CC=golang-codereviews https://golang.org/cl/89830043
2014-04-21cmd/nm: disable TestNM on darwin, linux and solarisAlex Brainman
Update #7829 LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/89810043
2014-04-21cmd/ld: correct addresses in windows pe symbol tableAlex Brainman
This should have been part of 36eb4a62fbb6, but I later discovered that addresses are all wrong. Appropriate test added now. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/89470043
2014-04-21runtime, go/build: re-enable cgo on FreeBSD.Shenghou Ma
Fixes #7331. LGTM=dave, iant R=golang-codereviews, dave, gobot, iant CC=golang-codereviews https://golang.org/cl/89150043
2014-04-21runtime, cmd/ld, cmd/5l, run.bash: enable external linking on FreeBSD/ARM.Shenghou Ma
Update #7331 LGTM=dave, iant R=golang-codereviews, dave, gobot, iant CC=golang-codereviews https://golang.org/cl/89520043
2014-04-21lib9: restore argv0 initialization code.Shenghou Ma
`GOARCH=arm go tool 6c` used to give "<prog>: cannot use 6c with GOARCH=arm" LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/89330043
2014-04-21cmd/go: handle -ccflags in 'go test'Shenghou Ma
CL 89050043 only allows -ccflags for 'go test', this CL really handles the flag like the other -??flags. Many thanks to Dobrosław Żybort for pointing this out. Fixes #7810 (again). LGTM=iant, matrixik R=golang-codereviews, iant, matrixik CC=golang-codereviews https://golang.org/cl/89230044
2014-04-20doc/go1.3.html: fix Goexit linkDavid du Colombier
LGTM=minux.ma R=r, minux.ma CC=golang-codereviews https://golang.org/cl/89710043
2014-04-20cmd/gc: avoid %L in error messageJan Ziak
Fixes #7783 LGTM=minux.ma R=rsc, minux.ma CC=golang-codereviews https://golang.org/cl/89290043
2014-04-19include/plan9: make mklibc.rc compatible with 9atomDavid du Colombier
Since there is no Runemask constant in UTF-8 enum in 9atom, removing the other constants leads to an empty enum, which is illegal. Thus, we remove enum entirely. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/82660044
2014-04-19cmd/nm: print symbol sizes for windows pe executablesAlex Brainman
Fixes #6973 LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/88820043
2014-04-18cmd/ld: don't delete output binary if not "ordinary" file (redux).Mike Andrews
following on CL https://golang.org/cl/76810045 and issue 7563, i now see there's another "remove(outfile)" a few dozen lines down that also needs fixing. LGTM=iant R=golang-codereviews, iant CC=0intro, golang-codereviews, r https://golang.org/cl/89030043
2014-04-18doc/go1.3.html: Plan 9 supportDavid du Colombier
LGTM=aram, r R=r, aram, bradfitz CC=golang-codereviews, rsc https://golang.org/cl/89130045
2014-04-18doc/go1.3.html: go test always buildsRob Pike
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/89370043
2014-04-18pkg/reflect/value.go: Correction in comment, the argument is "typ", not "t".Lucio De Re
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/89270043
2014-04-18doc/go1.3.html: new package debug/plan9objDavid du Colombier
LGTM=r R=r CC=golang-codereviews, rsc https://golang.org/cl/86180046
2014-04-17os: change return variable name for Getwd to avoid confusionShenghou Ma
changed (pwd string) to (dir string), as some think pwd means passwd. Fixes #7811. LGTM=iant R=golang-codereviews, iant, bradfitz CC=golang-codereviews https://golang.org/cl/89100043
2014-04-17cmd/go: support -ccflags in 'go test'Shenghou Ma
Fixes #7810. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/89050043
2014-04-17net/http/httputil: include Content-Length in DumpResponse outputBrad Fitzpatrick
Fixes #5357 LGTM=nigeltao R=nigeltao CC=golang-codereviews https://golang.org/cl/87910050
2014-04-17net: fix probabilities in DNS SRV shuffleByWeightBrad Fitzpatrick
Patch from msolo. Just moving it to a CL. The test fails before and passes with the fix. Fixes #7098 LGTM=msolo, rsc R=rsc, iant, msolo CC=golang-codereviews https://golang.org/cl/88900044
2014-04-17cmd/pack: avoid ./ import in test (fix Windows build)Russ Cox
It is possible to use ./ imports on Windows but it requires some extra command-line work ('go build' does this automatically, but we can't use 'go build' here). Instead, use an ordinary import and -I/-L, which are easier to use. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/89040043
2014-04-17cmd/pack: handle very long lines in pkgdefIan Lance Taylor
LGTM=rsc, bradfitz R=golang-codereviews, rsc, bradfitz CC=golang-codereviews https://golang.org/cl/88170049
2014-04-16net/http: allow commas and spaces in cookie valuesVolker Dobler
According to RFC 6265 a cookie value may contain neither commas nor spaces but such values are very common in the wild and browsers handle them very well so we'll allow both commas and spaces. Values starting or ending in a comma or a space are sent in the quoted form to prevent missinterpetations. RFC 6265 conforming values are handled as before and semicolons, backslashes and double-quotes are still disallowed. Fixes #7243 LGTM=nigeltao R=nigeltao CC=bradfitz, golang-codereviews https://golang.org/cl/86050045
2014-04-17doc/effective_go: mention that b.Write is a shorthand for (&b).Write when b ↵Shenghou Ma
is addressable. The rewrite is due to Rob. LGTM=r, bradfitz, josharian R=golang-codereviews, bradfitz, r, josharian CC=golang-codereviews https://golang.org/cl/87410043
2014-04-16cmd/ld: don't pass -rdynamic to external linker if -static is usedIan Lance Taylor
Fixes #7800. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/87790051
2014-04-16cmd/gc: fix segfault in isgoconst.Shenghou Ma
Variables declared with 'var' have no sym->def. Fixes #7794. LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/88360043
2014-04-16test: demo for issue 7695Russ Cox
Cgo writes C function declarations pretending every arg is a pointer. If the C function is deferred, it does not inhibit stack copying on split. The stack copying code believes the C declaration, possibly misinterpreting integers as pointers. Probably the right fix for Go 1.3 is to make deferred C functions inhibit stack copying. For Go 1.4 and beyond we probably need to make cgo generate Go code for 6g here, not C code for 6c. Update #7695 LGTM=khr R=khr CC=golang-codereviews https://golang.org/cl/83820043
2014-04-16compress/gzip: add Reset method to ReaderRobert Daniel Kortschak
Fixes #6364. LGTM=rsc R=golang-codereviews, bradfitz, rsc, gobot CC=golang-codereviews https://golang.org/cl/13512052
2014-04-16encoding/json: document Encoder will terminate each JSON value with '\n'Shenghou Ma
Fixes #7767. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/87420043
2014-04-16cmd/gc: fewer errors for wrong argument countJan Ziak
Fixes #7675 LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/85040044
2014-04-16cmd/ld: restore the call graph dumpAnthony Martin
Before the switch to liblink, the linkers accepted the -c flag to print the call graph. This change restores the functionality. This came in handy when I was trying to audit the use of SSE instructions inside the Plan 9 note handler. LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/73990043
2014-04-16cmd/go: reapply doc change from CL 60590044.Russ Cox
https://golang.org/cl/60590044 edited doc.go without editing the file it is generated from. The edit was lost at the next mkdoc.sh. Make the change in help.go and rerun mkdoc.sh. Pointed out in the review of CL 68580043. TBR=iant CC=golang-codereviews https://golang.org/cl/88760043
2014-04-16cmd/ld: populate pe symbol table with Go symbolsAlex Brainman
Fixes #6936 LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/87770048
2014-04-16cmd/nm: windows pe handling fixesAlex Brainman
- output absolute addresses, not relative; - accept negative section numbers. Update #6936 Fixes #7738 LGTM=rsc R=golang-codereviews, bradfitz, ruiu, rsc CC=golang-codereviews https://golang.org/cl/85240046
2014-04-16debug/pe: add optional header to FileAlex Brainman
This information is required by cmd/nm to calculate absolute symbol addresses. Update #6936 Update #7738 LGTM=rsc R=golang-codereviews, bradfitz, gobot, rsc CC=golang-codereviews https://golang.org/cl/87500043
2014-04-16liblink, cmd/ld: reenable nosplit checking and testRuss Cox
The new code is adapted from the Go 1.2 nosplit code, but it does not have the bug reported in issue 7623: g% go run nosplit.go g% go1.2 run nosplit.go BUG rejected incorrectly: main 0 call f; f 120 linker output: # _/tmp/go-test-nosplit021064539 main.main: nosplit stack overflow 120 guaranteed after split check in main.main 112 on entry to main.f -8 after main.f uses 120 g% Fixes #6931. Fixes #7623. LGTM=iant R=golang-codereviews, iant, ality CC=golang-codereviews, r https://golang.org/cl/88190043
2014-04-16encoding/xml: document NewDecoder bufferingBrad Fitzpatrick
Fixes #7225 LGTM=r R=golang-codereviews, r CC=golang-codereviews, rsc https://golang.org/cl/88710043
2014-04-16flag: document that Bool also accepts "T" and "F"Rob Pike
Fixes #7752. LGTM=bradfitz, ruiu R=golang-codereviews, bradfitz, ruiu CC=golang-codereviews https://golang.org/cl/88690043
2014-04-16all: fix typosRui Ueyama
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/88670043
2014-04-16liblink, cmd/gc, cmd/{5,6,8}{a,c}: rename linkwriteobj to writeobjIan Lance Taylor
The name linkwriteobj is misleading because it implies that the function has something to do with the linker, which it does not. The name is historical: the function performs an operation that was previously performed by the linker, but no longer is. LGTM=rsc R=rsc, minux.ma CC=golang-codereviews https://golang.org/cl/88210045
2014-04-16liblink: add leaf bit to object file formatRuss Cox
Without the leaf bit, the linker cannot record the correct frame size in the symbol table, and then stack traces get mangled. (Only for ARM.) Fixes #7338. Fixes #7347. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/88550043
2014-04-16go/scanner: interpret //line directives sans filename sensibly, second try.Alan Donovan
A //line directive without a filename now denotes the empty filename, not the current directory (the Go 1.2 behaviour) nor the previous //line's filename (the behaviour since CL 86990044). They should never appear (but they do, e.g. due to a bug in godoc). Fixes #7765 LGTM=gri, rsc R=rsc, gri CC=golang-codereviews https://golang.org/cl/88160050
2014-04-16doc/go1.3.html: fix id anchor for FreeBSDEmil Hessman
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/88000047
2014-04-16go/scanner: interpret //line directives sans filename sensiblyAlan Donovan
A //line directive without a filename now denotes the same filename as the previous line (as in C). Previously it denoted the file's directory (!). Fixes #7765 LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/86990044
2014-04-16encoding/base64: don't lose a byte of output when encountering trailing garbageBrad Fitzpatrick
Fixes #7733 LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews, nigeltao, r, rsc https://golang.org/cl/88330044
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion