aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-24[release-branch.go1.15] go1.15rc1go1.15rc1Alexander Rakoczy
Change-Id: I660c4655dfa0914dbe09a68921e102d06d9a2ed1 Reviewed-on: https://go-review.googlesource.com/c/go/+/244761 Run-TryBot: Alexander Rakoczy <alex@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-23doc/go1.15: announce GO386=387 deprecationAustin Clements
For #40255. Updates #37419. Change-Id: If9210c855cc2eea079e7e469463d4203888748f7 Reviewed-on: https://go-review.googlesource.com/c/go/+/243137 Reviewed-by: Andrew Bonventre <andybons@golang.org>
2020-07-22runtime: don't mlock on Ubuntu 5.4 systemsIan Lance Taylor
For #35777 For #37436 Fixes #40184 Change-Id: I68561497d9258e994d1c6c48d4fb41ac6130ee3a Reviewed-on: https://go-review.googlesource.com/c/go/+/244059 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
2020-07-20cmd/compile: add test for fixed ICE on untyped conversionAlberto Donizetti
The ICE reported as #33308 was fixed by a related CL; this change adds a regression test with the crasher. Fixes #33308 Change-Id: I3260075dbe3823b56b8825e6269e57a0fad185a6 Reviewed-on: https://go-review.googlesource.com/c/go/+/243458 Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2020-07-17doc/go1.15: add release notes for math/cmplxBrian Kessler
Updates #37419 Change-Id: Id7c9aba518c826c1a6fccbbf82210072bd3346f3 Reviewed-on: https://go-review.googlesource.com/c/go/+/242903 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Griesemer <gri@golang.org>
2020-07-17go/printer: remove exported StdFormat flagDmitri Shuralyov
The StdFormat flag was added as part of CL 231461, where the primary aim was to fix the bug #37476. It's expected that the existing printer modes only adjust spacing but do not change any of the code text itself. A new printing flag served as a way for cmd/gofmt and go/format to delegate a part of formatting work to the printer—where it's more more convenient and efficient to perform—while maintaining current low-level printing behavior of go/printer unmodified. We already have cmd/gofmt and the go/format API that implement standard formatting of Go source code, so there isn't a need to expose StdFormat flag to the world, as it can only cause confusion. Consider that to format source in canonical gofmt style completely it may require tasks A, B, C to be done. In one version of Go, the printer may do both A and B, while cmd/gofmt and go/format will do the remaining task C. In another version, the printer may take on doing just A, while cmd/gofmt and go/format will perform B and C. This makes it hard to add a gofmt-like mode to the printer without compromising on above fluidity. This change prefers to shift back some complexity to the implementation of the standard library, allowing us to avoid creating the new exported printing flag just for the internal needs of gofmt and go/format today. We may still want to re-think the API and consider if something better should be added, but unfortunately there isn't time for Go 1.15. We are not adding new APIs now, so we can defer this decision until Go 1.16 or later, when there is more time. For #37476. For #37453. For #39489. For #37419. Change-Id: I0bb07156dca852b043487099dcf05c5350b29e20 Reviewed-on: https://go-review.googlesource.com/c/go/+/240683 Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2020-07-16compress/flate: fix another deflate Reset inconsistencyRuss Cox
While investigating #34121, fixed by CL 193605, I discovered another case where Reset was not quite resetting enough. This specific case is not a problem in Reset itself but rather that the Huffman bit writer in one code path is using uninitialized memory left over from a previous block, making the compression not choose the optimal compression method. Fixes #34121. Change-Id: I29245b28214d924e382f91e2c56b4b8a9b7da13d Reviewed-on: https://go-review.googlesource.com/c/go/+/243140 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
2020-07-16compress/flate: fix deflate Reset consistencyKlaus Post
Modify the overflow detection logic to shuffle the contents of the table to a lower offset to avoid leaking the effects of a previous use of compress.Writer past Reset calls. Fixes #34121 Change-Id: I9963eadfa5482881e7b7adbad4c2cae146b669ab GitHub-Last-Rev: 8b35798cdd4d5a901d6422647b12984d7e500ba3 GitHub-Pull-Request: golang/go#34128 Reviewed-on: https://go-review.googlesource.com/c/go/+/193605 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com> Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-15cmd/link: skip TestOldLink if the old linker does not existCherry Zhang
We don't ship the old linker in binary releases. Skip the test if we cannot find the old linker. Fixes #39509. Change-Id: I1af5552bc56aff5314a384bcb5f3717b725d68e5 Reviewed-on: https://go-review.googlesource.com/c/go/+/242604 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2020-07-14net/http: synchronize "100 Continue" write and Handler writesRuss Cox
The expectContinueReader writes to the connection on the first Request.Body read. Since a Handler might be doing a read in parallel or before a write, expectContinueReader needs to synchronize with the ResponseWriter, and abort if a response already went out. The tests will land in a separate CL. Fixes #34902 Fixes CVE-2020-15586 Change-Id: Icdd8dd539f45e8863762bd378194bb4741e875fc Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/793350 Reviewed-by: Filippo Valsorda <valsorda@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/242598 Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-14crypto/x509: respect VerifyOptions.KeyUsages on WindowsFilippo Valsorda
When using the platform verifier on Windows (because Roots is nil) we were always enforcing server auth EKUs if DNSName was set, and none otherwise. If an application was setting KeyUsages, they were not being respected. Started correctly surfacing IncompatibleUsage errors from the system verifier, as those are the ones applications will see if they are affected by this change. Also refactored verify_test.go to make it easier to add tests for this, and replaced the EKULeaf chain with a new one that doesn't have a SHA-1 signature. Thanks to Niall Newman for reporting this. Fixes #39360 Fixes CVE-2020-14039 Change-Id: If5c00d615f2944f7d57007891aae1307f9571c32 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/774414 Reviewed-by: Katie Hockman <katiehockman@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/242597 Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-14html/template: add tests from text/templateRuss Cox
Copy and adapt tests from text/template, to exercise more of html/template's copy. Various differences in behavior are flagged with NOTE comments or t.Skip and documented in #40075. Many of them are probably bugs. One clarifying test case added to both text/template and html/template. No changes to the package itself. Change-Id: Ifefad83d647db846040d24c2741a0244b00ade82 Reviewed-on: https://go-review.googlesource.com/c/go/+/241084 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
2020-07-13cmd/go: include GOMODCACHE in 'go help environment'Jay Conrod
Updates #34527 Fixes #40089 Change-Id: Ie9c8573536e5c31e874d755f4d888ffc805b796f Reviewed-on: https://go-review.googlesource.com/c/go/+/241275 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>
2020-07-10net: hangup TCP connection after Dial timeout in Plan 9Fazlul Shahriar
After Dial timeout, force close the TCP connection by writing "hangup" to the control file. This unblocks the "connect" command if the connection is taking too long to establish, and frees up the control file FD. Fixes #40118 Change-Id: I1cef8539cd9fe0793e32b49c9d0ef636b4b26e1d Reviewed-on: https://go-review.googlesource.com/c/go/+/241638 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David du Colombier <0intro@gmail.com>
2020-07-09doc/go1.15: fix TODO about -buildmode=pieAustin Clements
Updates #37419. Change-Id: If77067eb348de47a4b101325de8a43502383b6d3 Reviewed-on: https://go-review.googlesource.com/c/go/+/241740 Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-07-09net/textproto: correct documentation of empty line handlingNorman B. Lancaster
Fixes #32493 Change-Id: I9c93791c4cc5c0c14556802733066407de3181ca Reviewed-on: https://go-review.googlesource.com/c/go/+/185542 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-07-09doc/go1.15: add line for testing streaming changeJean de Klerk
Updates #37419. Updates #38458. Updates #24929. Change-Id: I793bb20fa9db4432fc3a5b69956b7108e4695081 Reviewed-on: https://go-review.googlesource.com/c/go/+/241660 Run-TryBot: Jean de Klerk <deklerk@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2020-07-08crypto/x509/internal/macos: rename package to lowercaseFilippo Valsorda
Also add a test to lock in this policy. Fixes #40065 Change-Id: Iedc4586f2f5598046d84132a8f3bba8f2e93ddc2 Reviewed-on: https://go-review.googlesource.com/c/go/+/241274 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-07-08runtime: mark OpenBSD raise function nosplitIan Lance Taylor
It is called by the signal handler before switching to gsignal (sigtrampgo -> sigfwdgo -> dieFromSignal -> raise) which means that it must not split the stack. All other instances of raise are already marked nosplit. Fixes #40076 Change-Id: I4794491331af48c46d0d8ebc82d34c6483f0e6cd Reviewed-on: https://go-review.googlesource.com/c/go/+/241121 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-07-08os: fix regression with handling of nil *FileJoe Tsai
Use of a nil *File as an argument should not result in a panic, but result in the ErrInvalid error being returned. Fix the copy_file_range implementation to preserve this semantic. Fixes #40115 Change-Id: Iad5ac39664a3efb7964cf55685be636940a8db13 Reviewed-on: https://go-review.googlesource.com/c/go/+/241417 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-08crypto: fix PKCS space in docsKatie Hockman
Change-Id: Iee53acb963a889410f8c6daaa9a7841f1b12c6fb Reviewed-on: https://go-review.googlesource.com/c/go/+/241497 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
2020-07-08doc/editors.html: update VS Code Go extension urlHana (Hyang-Ah) Kim
Change-Id: I7aa73861de053db6b424f113733de9caba19145b Reviewed-on: https://go-review.googlesource.com/c/go/+/241086 Reviewed-by: Andrew Bonventre <andybons@golang.org>
2020-07-08A+C: add Kush Patel (corporate CLA for Hootsuite Inc)Kush Patel
I'm from Hootsuite. We're a Canadian tech company who provides products and services to businesses, organizations and individuals to really help them succeed on social. We have leveraged Go in our stack for the past 4+ years. I am super happy to give back to Go on behalf of Hootsuite through a small contribution to pkgsite (with a few more in the works). We love this project and we love open source :) Hopefully we can give back more in the future! Kush Change-Id: Id534a41d78e17e1fa48a8ddecd1ca110cf812388 GitHub-Last-Rev: 297b8b06e75c3ce485f62677ce4591c5cabe8008 GitHub-Pull-Request: golang/go#40088 Reviewed-on: https://go-review.googlesource.com/c/go/+/241218 Reviewed-by: Julie Qiu <julie@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-07-07crypto/tls: relax the docs of InsecureSkipVerifyFilippo Valsorda
Fixes #39074 Change-Id: I72ec95f4b190253bb82d52a03a769b0399170b93 Reviewed-on: https://go-review.googlesource.com/c/go/+/239746 Reviewed-by: Katie Hockman <katie@golang.org>
2020-07-07net: correct address when listening on IPv4zero tcp4/udp4 on Plan 9Fazlul Shahriar
Since Plan 9 doesn't allow us to listen on 0.0.0.0, the Listener address that's read in from /net is the IPv6 address ::. Convert this address to 0.0.0.0 when the network is tcp4 or udp4. Fixes #40045 Change-Id: Icfb69b823e5b80603742d23c3762a812996fe43f Reviewed-on: https://go-review.googlesource.com/c/go/+/240918 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David du Colombier <0intro@gmail.com>
2020-07-07crypto/x509/pkix: print non-standard parsed Names at the endFilippo Valsorda
This doesn't change how ExtraNames are printed, so as not to cause unnecessary churn of current outputs. Switched the ExtraNames check to a nil check as we are checking for just-parsed values. Fixes #39924 Fixes #39873 Change-Id: Ifa07cfc1a057d73643710a774ef8a154222db187 Reviewed-on: https://go-review.googlesource.com/c/go/+/240543 Run-TryBot: Filippo Valsorda <filippo@golang.org> Reviewed-by: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-07doc/go1.15: add html/template and text/template docsFilippo Valsorda
Updates #37419 Change-Id: I23abfeabc6be704aad9da2649bbbe7c8e237dfab Reviewed-on: https://go-review.googlesource.com/c/go/+/240546 Reviewed-by: Carlos Amedee <carlos@golang.org>
2020-07-07go/build: rewrite TestDependencies to be cleaner, more correctRuss Cox
TestDependencies defines the dependency policy (what can depend on what) for the standard library. The standard library has outgrown the idea of writing the policy as a plain map literal. Also, the checker was ignoring vendored packages, which makes it miss real problems. This commit adds a little language for describing partial orders and rewrites the policy in that language. It also changes the checker to look inside vendored packages and adds those to the policy as well. This turned up one important problem: net is depending on fmt, unicode via golang.org/x/net/dns/dnsmessage, filed as #40070. This is a test-only change, so it should be appropriate even for the release freeze, especially since it identified a real bug. Change-Id: I9b79f30761f167b8587204c959baa973583e39f2 Reviewed-on: https://go-review.googlesource.com/c/go/+/241078 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-07-07all: go get golang.org/x/net@ab3426394381Russ Cox
Pull in dns/dnsmessage fix to drop fmt dependency. Also pulled in minor bug fix in x/crypto (dep of net). Change-Id: I0f618e81a24ac24a5adae00af34b728b243dfdbb Reviewed-on: https://go-review.googlesource.com/c/go/+/241257 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2020-07-07doc/go1.15: update Go 1.15 release notes using relnoteCarlos Amedee
The additions were generated using golang.org/x/build/cmd/relnote. Updates #37419 Change-Id: I99e934377e4bb511c44908039ad6d3bfd3ee35ce Reviewed-on: https://go-review.googlesource.com/c/go/+/241065 Run-TryBot: Carlos Amedee <carlos@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-07path/filepath: add explicit comment marking elided errorsRuss Cox
The errors on these lines are meant to be discarded. Add a comment to make that extra clear. Change-Id: I38f72af6dfbb0e86677087baf47780b3cc6e7d40 Reviewed-on: https://go-review.googlesource.com/c/go/+/241083 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-07-06cmd/go: display test binary output if invoked with -helpIan Lance Taylor
Fixes #39997 Change-Id: I87ea616bac809b96fcd40f3bbdbbf1c603b9d00e Reviewed-on: https://go-review.googlesource.com/c/go/+/240878 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
2020-07-06cmd/oldlink: port bug fixes to old linkerCherry Zhang
This CL ports CL 234105 and CL 240621 to the old linker, which fix critical bugs (runtime crashes). Updates #39049. Updates #39927. Change-Id: I47afc84349119e320d2e60d64b7188a410835d2b Reviewed-on: https://go-review.googlesource.com/c/go/+/241087 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Jeremy Faller <jeremy@golang.org>
2020-07-06go/build: remove use of package logRuss Cox
package log does not belong here, even for an impossible condition. Change-Id: I6180a4f7766a8e5759db4f33d03703d0b678d0b4 Reviewed-on: https://go-review.googlesource.com/c/go/+/241077 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-05doc/go1.15: fix wording in a few placesAlberto Donizetti
Change-Id: I1dc6871bdab7f3048eacd6738fdcfa64b8700c8a Reviewed-on: https://go-review.googlesource.com/c/go/+/240998 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-07-03crypto/tls: create certs w/o KeyEncipherment KU for non-RSA keys in ↵Daniel
generate_cert.go Summary The crypto/tls/generate_cert.go utility should only set the template x509.Certificate's KeyUsage field to a value with the x509.KeyUsageKeyEncipherment bits set when the certificate subject public key is an RSA public key, not an ECDSA or ED25519 public key. Background RFC 5480 describes the usage of ECDSA elliptic curve subject keys with X.509. Unfortunately while Section 3 "Key Usages Bits" indicates which key usage bits MAY be used with a certificate that indicates id-ecPublicKey in the SubjectPublicKeyInfo field it doesn't provide guidance on which usages should *not* be included (e.g. the keyEncipherment bit, which is particular to RSA key exchange). The same problem is present in RFC 8410 Section 5 describing Key Usage Bits for ED25519 elliptic curve subject keys. There's an update to RFC 5480 in last call stage within the IETF LAMPS WG, draft-ietf-lamps-5480-ku-clarifications-00. This update is meant to clarify the allowed Key Usages extension values for certificates with ECDSA subject public keys by adding: > If the keyUsage extension is present in a certificate that indicates > id-ecPublicKey as algorithm of AlgorithmIdentifier [RFC2986] in > SubjectPublicKeyInfo, then following values MUST NOT be present: > > keyEncipherment; and > dataEncipherment. I don't believe there is an update for RFC 8410 in the works but I suspect it will be clarified similarly in the future. This commit updates generate_cert.go to ensure when the certificate public key is ECDSA or ED25519 the generated certificate has the x509.Certificate.KeyUsage field set to a value that doesn't include KUs specific to RSA. For ECDSA keys this will adhere to the updated RFC 5480 language. Fixes #36499 Change-Id: Ib1b0757c039b7fe97fc6d1e826fe6b88856c1964 GitHub-Last-Rev: a8f34fb33dde90e09b6f9a27b2598a82b3023abb GitHub-Pull-Request: golang/go#36500 Reviewed-on: https://go-review.googlesource.com/c/go/+/214337 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-02Revert "encoding/json: don't reuse slice elements when decoding"Daniel Martí
This reverts https://golang.org/cl/191783. Reason for revert: Broke too many programs which depended on the previous behavior, even when it was the opposite of what the documentation said. We can attempt to fix the original issue again for 1.16, while keeping those programs in mind. Fixes #39427. Change-Id: I7a7f24b2a594c597ef625aeff04fff29aaa88fc6 Reviewed-on: https://go-review.googlesource.com/c/go/+/240657 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-07-01cmd/link: skip fallocate test if not supported, and adjust allocation size ↵Cherry Zhang
on darwin On Linux, the linker uses fallocate to preallocate the output file storage. The underlying file system may not support fallocate, causing the test to fail. Skip the test in this case. On darwin, apparently F_PREALLOCATE allocates from the end of the allocation instead of the logical end of the file. Adjust the size calculation. Fixes #39905. Change-Id: I01e676737fd2619ebbdba05c7cf7f424ec27de35 Reviewed-on: https://go-review.googlesource.com/c/go/+/240618 Reviewed-by: Than McIntosh <thanm@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-01cmd/link: fix GC data reading from shared library (attempt 2)Cherry Zhang
When linking against a Go shared library, when a global variable in the main module has a type defined in the shared library, the linker needs to pull the GC data from the shared library to build the GC program for the global variable. Currently, this fails silently, as the shared library file is closed too early and the read failed (with no error check), causing a zero GC map emitted for the variable, which in turn causes the runtime to treat the variable as pointerless. For now, fix this by keeping the file open. In the future we may want to use mmap to read from the shared library instead. Also add error checking. And fix a (mostly harmless) mistake in size caluculation. Also remove an erroneous condition for ARM64. ARM64 used to have a special case to get the addend from the relocation on the gcdata field. That was removed, but the new code accidentally returned 0 unconditionally. It's no longer necessary to have any special case, since the addend is now applied directly to the gcdata field on ARM64, like on all the other platforms. Fixes #39927. This is the second attempt of CL 240462. And this reverts CL 240616. Change-Id: I01c82422b9f67e872d833336885935bc509bc91b Reviewed-on: https://go-review.googlesource.com/c/go/+/240621 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
2020-07-01cmd/link: mark special symbols reachableCherry Zhang
The special symbols are linker-created symbols for special purposes, therefore reachable (otherwise the linker won't create them). Mark them so, so they get converted to sym.Symbols when we convert to old symbol representation. In particular, the failure for building shared library on PPC64 is due to .TOC. symbol not being converted to sym.Symbol, but referenced in addmoduledata. Change-Id: Iaf5d145ffa5d15122e86a6e6983514e56dd5d456 Reviewed-on: https://go-review.googlesource.com/c/go/+/240620 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
2020-07-01doc: add riscv64 to ports listTobias Klauser
Mention support for the 64-bit RISC-V instruction set (GOARCH=riscv64) in the "Installing Go from source" document. Also sort the list of supported instruction sets alphabetically. Updates #27532 Change-Id: I07a443044a41a803853978dd7f7446de89ecceb5 Reviewed-on: https://go-review.googlesource.com/c/go/+/240377 Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
2020-06-30Revert "cmd/link: fix GC data reading from shared library"Cherry Zhang
This reverts CL 240462. Reason for revert: test fails on PPC64LE. Updates #39927. Change-Id: I4f14fd0c36e604a80ae9f2f86d1e643e28945e93 Reviewed-on: https://go-review.googlesource.com/c/go/+/240616 Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
2020-06-30cmd/link: fix GC data reading from shared libraryCherry Zhang
When linking against a Go shared library, when a global variable in the main module has a type defined in the shared library, the linker needs to pull the GC data from the shared library to build the GC program for the global variable. Currently, this fails silently, as the shared library file is closed too early and the read failed (with no error check), causing a zero GC map emitted for the variable, which in turn causes the runtime to treat the variable as pointerless. For now, fix this by keeping the file open. In the future we may want to use mmap to read from the shared library instead. Also add error checking. And fix a (mostly harmless) mistake in size caluculation. Also remove an erroneous condition for ARM64. ARM64 used to have a special case to get the addend from the relocation on the gcdata field. That was removed, but the new code accidentally returned 0 unconditionally. It's no longer necessary to have any special case, since the addend is now applied directly to the gcdata field on ARM64, like on all the other platforms. Fixes #39927. Change-Id: Iecd32315b326c7059587fdc190e2fa99426e497e Reviewed-on: https://go-review.googlesource.com/c/go/+/240462 Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Austin Clements <austin@google.com>
2020-06-30doc/go1.15: add encoding/asn1 note about minimal encodingRoland Shoemaker
Also fix missing <code> tags in the other encoding/asn1 note. Updates #37419 Change-Id: Ic0e9131016b44ed864629aa8d0a7fddb57146d21 Reviewed-on: https://go-review.googlesource.com/c/go/+/240518 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2020-06-30net: fix TestDialerLocalAddr on Plan 9Fazlul Shahriar
We cannot use "0.0.0.0" (IPv4) or "::" (IPv6) for local address, so don't use those addresses in the control message. Alternatively, we could've used "*" instead. Fixes #39931 Change-Id: Ib2dcbb1a0c648296c3ecaddbe938053a569b1f1b Reviewed-on: https://go-review.googlesource.com/c/go/+/240464 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David du Colombier <0intro@gmail.com>
2020-06-30doc: add note about missing lock in sample codeFerenc Szabo
The sample code in 'Interfaces and methods' section contains a data race. Handlers are served concurrently. The handler does write and read operations; `go test -race` would fail (with concurrent requests). Since the doc is frozen and the code remains less cluttered without locks/atomic, don't change the sample code. Change-Id: I654b324d2f0b7f48497822751907c7d39e2f0e3d Reviewed-on: https://go-review.googlesource.com/c/go/+/239877 Reviewed-by: Rob Pike <r@golang.org>
2020-06-29doc/go1.15: remove encoding/xml docIan Lance Taylor
The change is rolled back in CL 240179. For #35151 For #39876 Change-Id: Id26ccbdb482772ac31c642156a9900102397b043 Reviewed-on: https://go-review.googlesource.com/c/go/+/240012 Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2020-06-29Revert "encoding/xml: fix reserved namespace check to be case-insensitive"Ian Lance Taylor
This reverts CL 203417. Reason for revert: This change changes uses of tags like "XMLSchema-instance" without any recourse. For #35151 Fixes #39876 Change-Id: I4c85c8267a46b3748664b5078794dafffb42aa26 Reviewed-on: https://go-review.googlesource.com/c/go/+/240179 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Andrew Bonventre <andybons@golang.org>
2020-06-29doc: add alt attribute to gopher image in help.htmlAlexander Nohe
This adds an alt tag for accessibility. The alt text is a visual description of the text that is read out loud to users using a screen reader. The HTML specifications indicate that alt tags for decorative images should be left blank. Fixes #39861 Change-Id: I76c39a461ceabe685826aa46e4f26ad893d50634 Reviewed-on: https://go-review.googlesource.com/c/go/+/240258 Reviewed-by: Alexander Nohe <alex.nohe427@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2020-06-29doc/go1.15: add release note for encoding/asn1Roland Shoemaker
Updates #37419 Change-Id: I05368efbedd8c7e0b50cd691559491699c3a0945 Reviewed-on: https://go-review.googlesource.com/c/go/+/240201 Reviewed-by: Filippo Valsorda <filippo@golang.org>
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion