aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-11[dev.tls] dev.tls: remove sentinel filedev.tlsRuss Cox
Now that we're branched in the history we don't need this anymore. Change-Id: I0655b2496e273aec87e77557bc4baa06bbc8cfcf Reviewed-on: https://go-review.googlesource.com/33109 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2016-11-11[dev.tls] dev.tls: new branch for TLS 1.3Russ Cox
Change-Id: If08e41a7aa5fa21c6c56a9c9814a305291cf2c27 Reviewed-on: https://go-review.googlesource.com/33115 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-11-11cmd/link: use plugin path in visibility analysisDavid Crawshaw
CL 32355 switched from using the output file as a plugin prefix to the full package path. The linker dead code analysis was not updated. Updates #17821 Change-Id: I13fc45e0264b425d28524ec54c829e2c3e895b0b Reviewed-on: https://go-review.googlesource.com/32916 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10cmd/cgo: don't depend on runtime/cgo if !CgoEnabledIan Lance Taylor
Fixes the build when CGO_ENABLED=0. Change-Id: I7f3c67d61e156e69536558fda0a0a4b429b82bbd Reviewed-on: https://go-review.googlesource.com/33104 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-10cmd/gofmt: don't overwrite read-only filesRobert Griesemer
This reverts the changes from https://golang.org/cl/33018: Instead of writing the result of gofmt to a tmp file and then rename that to the original (which doesn't preserve the original file's perm bits, uid, gid, and possibly other properties because it is hard to do in a platform-independent way - see #17869), use the original code that simply overwrites the processed file if gofmt was able to create a backup first. Upon success, the backup is removed, otherwise it remains. Fixes #17873. For #8984. Change-Id: Ifcf2bf1f84f730e6060f3517d63b45eb16215ae1 Reviewed-on: https://go-review.googlesource.com/33098 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-10net/http: update bundled http2 for ErrAbortHandler support, document it moreBrad Fitzpatrick
Updates http2 to x/net/http2 git rev 0e2717d for: http2: conditionally log stacks from panics in Server Handlers like net/http https://golang.org/cl/33102 Fixes #17790 Change-Id: Idd3f0c65540398d41b412a33f1d80de3f7f31409 Reviewed-on: https://go-review.googlesource.com/33103 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
2016-11-10net/http: deflake TestClientTimeoutBrad Fitzpatrick
This test was only enabled by default today so it hasn't been hardened by build.golang.org. Welcome to the ring, TestClientTimeout. Change-Id: I1967f6c825699f13f6c659dc14d3c3c22b965272 Reviewed-on: https://go-review.googlesource.com/33101 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
2016-11-10net/http: update Transport doc example to not disable http2Brad Fitzpatrick
The old Transport example ended up disabling HTTP/2. Use a better example. Fixes #17051 Fixes #17296 Change-Id: I6feca168744131916e8bf56c829b4d4b50e304ee Reviewed-on: https://go-review.googlesource.com/33094 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10net/http: update bundled http2Brad Fitzpatrick
Updates http2 to x/net/http2 git rev 9ef22118 for: http2: fix CloseNotify data race https://golang.org/cl/33013 http2: don't overflow stream IDs in server push https://golang.org/cl/32488 http2: disable server push on receiving a GOAWAY https://golang.org/cl/32887 http2: fix state tracking for pushed streams https://golang.org/cl/32755 Change-Id: Ie7d675857423c102c9ec164d3c943093c749c7cf Reviewed-on: https://go-review.googlesource.com/33100 Reviewed-by: Tom Bergan <tombergan@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-10net/http: add ErrAbortHandler, make Server quiet if used as panic valueBrad Fitzpatrick
Add an explicit way for Handlers to abort their response to the client and also not spam their error log with stack traces. panic(nil) also worked in the past (for http1 at least), so continue to make that work (and test it). But ErrAbortHandler is more explicit. Updates #17790 (needs http2 updates also) Change-Id: Ib1456905b27e2ae8cf04c0983dc73e314a4a751e Reviewed-on: https://go-review.googlesource.com/33099 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-10net/http: document that Server.Close and Shutdown don't track hijacked connsBrad Fitzpatrick
Fixes #17721 Change-Id: I19fd81c9909a22b01a4dc9c75f3f0e069c8608ca Reviewed-on: https://go-review.googlesource.com/33095 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10debug/elf: SPARC64 relocation type is only 8 bitsIan Lance Taylor
https://docs.oracle.com/cd/E53394_01/html/E54813/chapter6-54839.html#OSLLGchapter6-24: "For 64–bit SPARC Elf64_Rela structures, the r_info field is further broken down into an 8–bit type identifier and a 24–bit type dependent data field. For the existing relocation types, the data field is zero. New relocation types, however, might make use of the data bits. #define ELF64_R_TYPE_ID(info) (((Elf64_Xword)(info)<<56)>>56) " No test for this because the only test would be an invalid object file. Change-Id: I5052ca3bfaf0759e920f9a24a16fd97543b24486 Reviewed-on: https://go-review.googlesource.com/33091 Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
2016-11-10net/http: document and deprecate type and errors of type ProtocolErrorBrad Fitzpatrick
Clean up & document the ProtocolError gunk. Fixes #17558 Change-Id: I5e54c25257907c9cac7433f7a5bdfb176e8c3eee Reviewed-on: https://go-review.googlesource.com/33096 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10cmd/go: remove "x" in TestImportMainIan Lance Taylor
Interestingly, this only became a problem when CL 32850 marked TestImportMain as parallel. Before that, "x" was overwritten and remove in a later test, TestGoBuildOutput. The latter test is not marked as parallel, so now it is run first. It is rather fragile for two tests to compete over the same filename, but this change is correct regardless. Change-Id: I1db7929c0bc20a2fd0cc6a02999bef2dca9e0cc0 Reviewed-on: https://go-review.googlesource.com/33092 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-11-10net/http: fix documentation on Server.TLSNextProto controlling http2Brad Fitzpatrick
Server.TLSNextProto being nil is necessary but not sufficient but http2 being automatically enabled. Fixes #16588 Change-Id: I5b18690582f9b12ef05b58235e1eaa52483be285 Reviewed-on: https://go-review.googlesource.com/33090 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10runtime/pprof: output CPU profiles in pprof protobuf formatMichael Matloob
This change buffers the entire profile and converts in one shot in the profile writer, and could use more memory than necessary to output protocol buffer formatted profiles. It should be possible to convert each chunk in a stream (maybe maintaining some minimal state to output in the end) which could save on memory usage. Fixes #16093 Change-Id: I946c6a2b044ae644c72c8bb2d3bd82c415b1a847 Reviewed-on: https://go-review.googlesource.com/33071 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2016-11-10net/http: don't wrap request cancellation errors in timeoutsEmmanuel Odeke
Based on Filippo Valsorda's https://golang.org/cl/24230 Fixes #16094 Change-Id: Ie39b0834e220f0a0f4fbfb3bbb271e70837718c3 Reviewed-on: https://go-review.googlesource.com/32478 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-10cmd/vet: detect defer resp.Body.Close() before error checkFrancesc Campoy
This check detects the code resp, err := http.Get("http://foo.com") defer resp.Body.Close() if err != nil { ... } For every call to a function on the net/http package or any method on http.Client that returns (*http.Response, error), it checks whether the next line is a defer statement that calls on the response. Fixes #17780. Change-Id: I9d70edcbfa2bad205bf7f45281597d074c795977 Reviewed-on: https://go-review.googlesource.com/32911 Reviewed-by: Rob Pike <r@golang.org>
2016-11-10A+C: update for Go 1.8Brad Fitzpatrick
Add Albert Nigmatzianov (individual CLA) Add Alex Browne (individual CLA) Add Alex Carol (individual CLA) Add Alexander Döring (individual CLA) Add Allan Simon (individual CLA) Add Alok Menghrajani (individual CLA) Add Andreas Auernhammer (individual CLA) Add Andreas Litt (individual CLA) Add Andrew Pogrebnoy (individual CLA) Add Antonio Murdaca (corporate CLA for Red Hat, Inc.) Add Atin Malaviya (individual CLA) Add Billy Lynch (corporate CLA for Google Inc.) Add Blixt (individual CLA) Add Boris Nagaev (corporate CLA for Google Inc.) Add Braden Bassingthwaite (corporate CLA for Vendasta) Add Brian Kennedy (individual CLA) Add Bryan Alexander (individual CLA) Add Carl Johnson (individual CLA) Add Cixtor (individual CLA) Add Cyrill Schumacher (individual CLA) Add Daniel Martí (individual CLA) Add Daria Kolistratova (corporate CLA for Intel Corporation) Add David Hubbard (corporate CLA for Google Inc.) Add David Stainton (individual CLA) Add Deepak Jois (individual CLA) Add Denis Nagorny (corporate CLA for Intel Corporation) Add Dhaivat Pandit (individual CLA) Add Dhananjay Nakrani (corporate CLA for Google Inc.) Add Dmitri Popov (individual CLA) Add Erik Staab (corporate CLA for Google Inc.) Add Ethan Miller (corporate CLA for IBM) Add Faiyaz Ahmed (individual CLA) Add Fedor Indutny (individual CLA) Add Gabriel Russell (individual CLA) Add Gareth Paul Jones (individual CLA) Add Geoffroy Lorieux (individual CLA) Add Gleb Stepanov (individual CLA) Add Henrik Hodne (individual CLA) Add Ivan Babrou (individual CLA) Add Jack Lindamood (corporate CLA for Amazon.com, Inc) Add James Clarke (individual CLA) Add Jamie Beverly (individual CLA) Add Jason Smale (individual CLA) Add Jean-Nicolas Moal (individual CLA) Add Jeroen Bobbeldijk (individual CLA) Add Jim Kingdon (corporate CLA for Bolt) Add Jirka Daněk (individual CLA) Add Jon Chen (corporate CLA for Amazon.com, Inc) Add Joonas Kuorilehto (individual CLA) Add Josh Chorlton (individual CLA) Add Joshua Boelter (corporate CLA for Intel Corporation) Add Justyn Temme (individual CLA) Add Kale Blankenship (individual CLA) Add LE Manh Cuong (individual CLA) Add Luigi Riefolo (individual CLA) Add Manfred Touron (individual CLA) Add Martin Bertschler (individual CLA) Add Martin Hamrle (individual CLA) Add Matthew Denton (individual CLA) Add Matthieu Hauglustaine (individual CLA) Add Michael Darakananda (corporate CLA for Google Inc.) Add Mike Appleby (individual CLA) Add Mike Houston (individual CLA) Add Mike Strosaker (corporate CLA for IBM) Add Miroslav Genov (individual CLA) Add Momchil Velikov (individual CLA) Add Nick Harper (corporate CLA for Google Inc.) Add Oleg Vakheta (individual CLA) Add Parker Moore (individual CLA) Add Prasanna Swaminathan (corporate CLA for MediaMath, Inc) Add Radu Berinde (individual CLA) Add Ramesh Dharan (corporate CLA for Google Inc.) Add Richard Gibson (individual CLA) Add Samuel Tan (corporate CLA for Google Inc.) Add Samuele Pedroni (individual CLA) Add Sarah Adams (corporate CLA for Google Inc.) Add Sean Rees (individual CLA) Add Simon Rawet (individual CLA) Add Sina Siadat (individual CLA) Add Song Gao (individual CLA) Add Suyash (individual CLA) Add Sven Blumenstein (corporate CLA for Google Inc.) Add Syohei YOSHIDA (individual CLA) Add Terrel Shumway (individual CLA) Add Than McIntosh (corporate CLA for Google Inc.) Add Thomas de Zeeuw (individual CLA) Add Tim Henderson (individual CLA) Add Tom Wilkie (corporate CLA for Weaveworks) Add Trey Lawrence (individual CLA) Add Tristan Ooohry (individual CLA) Add Tuo Shan (corporate CLA for Google Inc.) Add Victor Chudnovsky (corporate CLA for Google Inc.) Add Vitor De Mario (individual CLA) Add Vladimir Mihailenco (individual CLA) Add Vladimir Stefanovic (individual CLA) Add Walter Poupore (corporate CLA for Google Inc.) Add Xuyang Kang (individual CLA) Add Zev Goldstein (individual CLA) Updates #12042 Change-Id: I28d63babe225683b88f3f1501e529aed636c9ead Reviewed-on: https://go-review.googlesource.com/33028 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10lib/time: update tzdata to 2016iBrad Fitzpatrick
Fixes #17678 Change-Id: I01d12a827e6106efed1ec024f736c640b86906b4 Reviewed-on: https://go-review.googlesource.com/33029 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10cmd/go: -ldflags=-linkmode=external requires runtime/cgoIan Lance Taylor
We add runtime/cgo to the list of import paths for various cases that imply external linking mode, but before this change we did not add for an explicit request of external linking mode. This fixes the case where you are using a non-default buildmode that implies a different compilation option (for example, -buildmode=pie implies -shared) and the runtime/cgo package for that option is stale. No test, as I'm not sure how to write one. It would require forcing a stale runtime/cgo. Change-Id: Id0409c7274ce67fe15d910baf587d3220cb53d83 Reviewed-on: https://go-review.googlesource.com/33070 Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
2016-11-10go/printer: don't drop required semi/linebreak after /*-commentRobert Griesemer
For details, see the issues. Fixes #11274. Fixes #15137. Change-Id: Ia11e71a054b3195e3007f490418a9c53a7e9cdf1 Reviewed-on: https://go-review.googlesource.com/33016 Reviewed-by: Alan Donovan <adonovan@google.com>
2016-11-10net/http: fix Server.Close double LockBrad Fitzpatrick
Fixes #17878 Change-Id: I062ac514239068c58175c9ee7964b3590f956a82 Reviewed-on: https://go-review.googlesource.com/33026 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10reflect: unexported fields are tied to a packageDavid Crawshaw
An unexported field of a struct is not visible outside of the package that defines it, so the package path is implicitly part of the definition of any struct with an unexported field. Change-Id: I17c6aac822bd0c24188ab8ba1cc406d6b5d82771 Reviewed-on: https://go-review.googlesource.com/32820 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-10sync: add example for PoolKevin Burke
It was a little tricky to figure out how to go from the documentation to figuring out the best way to implement a Pool, so I thought I'd try to provide a simple example. The implementation is mostly taken from the fmt package. I'm not happy with the verbosity of the calls to WriteString() etc, but I wanted to provide a non-trivial example. Change-Id: Id33a8b6cbf8eb278f71e1f78e20205b436578606 Reviewed-on: https://go-review.googlesource.com/24371 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-10cmd/gofmt: don't leave tmp file if -w failedRobert Griesemer
Follow-up on https://golang.org/cl/33018. For #8984. Change-Id: I6655a5537a60d4ea3ee13029a56a75b150f8c8f8 Reviewed-on: https://go-review.googlesource.com/33020 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-11-10cmd/gofmt: don't eat source if -w failsRobert Griesemer
Write output to a temp file first and only upon success rename that file to source file name. Fixes #8984. Change-Id: Ie40e49d2a4eb3c9462fe769ccbf055b4366eceb0 Reviewed-on: https://go-review.googlesource.com/33018 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-11-10go/types: remove unused alias-related testdata filesRobert Griesemer
They interfere with gofmt -w across this directory. Follow-up on https://go-review.googlesource.com/32819. For #16339 (comment). Change-Id: I4298b6117d89517d4fe6addce3942d950d821817 Reviewed-on: https://go-review.googlesource.com/33019 Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2016-11-09net/http: deflake TestIdleConnH2CrashBrad Fitzpatrick
Fixes #17838 Change-Id: Ifafb4542a0ed6f2e29c9a83e30842e2fc18d6546 Reviewed-on: https://go-review.googlesource.com/33015 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com> Reviewed-by: Michael Munday <munday@ca.ibm.com>
2016-11-09syscall: use 32-bit setuid/setgid syscalls on linux/{386,arm}Brad Fitzpatrick
Fixes #17092 Change-Id: Ib14e4db13116ebbe4d72c414fb979d27a06d6174 Reviewed-on: https://go-review.googlesource.com/33011 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-09encoding/xml: check type when unmarshaling innerxml fieldQuentin Smith
We only support unmarshaling into a string or a []byte, but we previously would try (and panic while) setting a slice of a different type. The docs say ",innerxml" is ignored if the type is not string or []byte, so do that for other slices as well. Fixes #15600. Change-Id: Ia64815945a14c3d04a0a45ccf413e38b58a69416 Reviewed-on: https://go-review.googlesource.com/32919 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2016-11-09runtime/pprof/internal/protopprof: skip TestTranslateCPUProfileWithSamples ↵Michael Munday
if < 2 mappings A Go binary may only have 1 executable memory region if it has been linked using internal linking. This change means that the test will be skipped if this is the case, rather than fail. Fixes #17852. Change-Id: I59459a0f90ae8963aeb9908e5cb9fb64d7d0e0f4 Reviewed-on: https://go-review.googlesource.com/32920 Run-TryBot: Michael Munday <munday@ca.ibm.com> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>
2016-11-09cmd/compile/internal/syntax: fix error handling for Read/Parse callsRobert Griesemer
- define syntax.Error for cleaner error reporting - abort parsing after first error if no error handler is installed - make sure to always report the first error, if any - document behavior of API calls - while at it: rename ReadXXX -> ParseXXX (clearer) - adjust cmd/compile noder.go accordingly Fixes #17774. Change-Id: I7893eedea454a64acd753e32f7a8bf811ddbb03c Reviewed-on: https://go-review.googlesource.com/32950 Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2016-11-09cmd/cgo: delete unused variable in log statementJosh Bleecher Snyder
visit is just a func, and there's no formatting verb for it, and it's on an internal-error path. It has been thus many years, unchanged and unexecuted. Change-Id: I4c2e2673ee9996218c24143bcc3be3eb4abdff25 Reviewed-on: https://go-review.googlesource.com/32970 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-09C: add Martin Möhrmann's google.com email (Google CLA)Martin Möhrmann
Change-Id: Ia439c4a3c873ef24f60f8ee54a74f767fdaafd29 Reviewed-on: https://go-review.googlesource.com/32799 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-09cmd/compile: ensure that knownFormats is up to dateJosh Bleecher Snyder
Change-Id: I4febdddfe5be569a8bba0a4cddf52dec7f1be1bf Reviewed-on: https://go-review.googlesource.com/32930 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-08os: on Windows, don't fix long paths that aren't longBrad Fitzpatrick
Notably, don't allocate. Follow-up to https://golang.org/cl/32451 which added long path cleaning. Updates #3358 Change-Id: I89c59cbd660d0a030f31b6acd070fa9f3250683b Reviewed-on: https://go-review.googlesource.com/32886 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2016-11-08cmd/link: add support for GOARCH=mips{,le}Vladimir Stefanovic
Only internal linking without cgo is supported for now. Change-Id: I772d2ba496a613c78bee7e93f29e9538e6407bdc Reviewed-on: https://go-review.googlesource.com/31481 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
2016-11-08cmd/compile: add support for GOARCH=mips{,le}Vladimir Stefanovic
Change-Id: Ib489dc847787aaab7ba1be96792f885469e346ae Reviewed-on: https://go-review.googlesource.com/31479 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
2016-11-08cmd/compile/internal/ssa: add support for GOARCH=mips{,le}Vladimir Stefanovic
Change-Id: I632d4aef7295778ba5018d98bcb06a68bcf07ce1 Reviewed-on: https://go-review.googlesource.com/31478 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
2016-11-08runtime/pprof/internal: add package protopprofMichael Matloob
This change adds code, originally written by Russ Cox <rsc@golang.org> and open-sourced by Google, that converts from the "legacy" binary pprof profile format to a struct representation of the new protocol buffer pprof profile format. This code reads the entire binary format for conversion to the protobuf format. In a future change, we will update the code to incrementally read and convert segments of the binary format, so that the entire profile does not need to be stored in memory. This change also contains contributions by Daria Kolistratova <daria.kolistratova@intel.com> from the rolled-back change golang.org/cl/30556 adapting the code to be used by the package runtime/pprof. This code also appeared in the change golang.org/cl/32257, which was based on Daria Kolistratova's change, but was also rolled back. Updates #16093 Change-Id: I5c768b1134bc15408d80a3ccc7ed867db9a1c63d Reviewed-on: https://go-review.googlesource.com/32811 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2016-11-08path: document that filepath is recommended to manipulate filename pathsJaana Burcu Dogan
Fixes #17690. Change-Id: Ifd300980aa4c11498ed7c083d08bcdd23f5b307a Reviewed-on: https://go-review.googlesource.com/32423 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-11-08doc: add a CL to go1.8.txt mentioned by Alberto DonizettiBrad Fitzpatrick
Change-Id: I43617e6dfd5b8227a8ef907dc22c00188de87b94 Reviewed-on: https://go-review.googlesource.com/32915 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-11-08doc: reference go1.4-bootstrap-20161024.tar.gzBrad Fitzpatrick
Updates #16352 Change-Id: I214c87579ef21ced8d0ba94aa170dd7780afec4b Reviewed-on: https://go-review.googlesource.com/32312 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-08cmd/asm: add support for GOARCH=mips{,le}Vladimir Stefanovic
Change-Id: I6a5256a42f895bb93ac56764e91ade1861c00e04 Reviewed-on: https://go-review.googlesource.com/31476 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
2016-11-08net/http: deflake TestClientRedirectsBrad Fitzpatrick
Fix another case of a parallel test relying on a global variable (DefaultTransport) implicitly. Use the private Transport already in scope instead. It's closed at the end, instead of randomly via another test. Change-Id: I95e51926177ad19a766cabbb306782ded1bbb59b Reviewed-on: https://go-review.googlesource.com/32913 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-08crypto/elliptic: add s390x assembly implementation of NIST P-256 CurveVolodymyr Paprotski
A paranoid go at constant time implementation of P256 curve. This code relies on z13 SIMD instruction set. For zEC12 and below, the fallback is the existing P256 implementation. To facilitate this fallback mode, I've refactored the code so that implementations can be picked at run-time. Its 'slightly' difficult to grok, but there is ASCII art.. name old time/op new time/op delta BaseMultP256 419µs ± 3% 27µs ± 1% -93.65% (p=0.000 n=10+8) ScalarMultP256 1.05ms ±10% 0.09ms ± 1% -90.94% (p=0.000 n=10+8) Change-Id: Ic1ded898a2ceab055b1c69570c03179c4b85b177 Reviewed-on: https://go-review.googlesource.com/31231 Run-TryBot: Michael Munday <munday@ca.ibm.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Michael Munday <munday@ca.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-11-08cmd/internal/obj/mips: add support for GOARCH=mips{,le}Vladimir Stefanovic
Implements subset of MIPS32(r1) instruction set. Change-Id: Iba017350f6c2763de05d4d1bc2f123e8eb76d0ff Reviewed-on: https://go-review.googlesource.com/31475 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
2016-11-08syscall: fix name of prlimit parametersBrad Fitzpatrick
Fixes #17606 Change-Id: I040c7621cef265d44b58f16556e6d58660a2245d Reviewed-on: https://go-review.googlesource.com/32889 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-11-08os: cleanup directories created by TestLongPathMohit Agarwal
Add tmpdir as a parameter to the closure otherwise the subsequent modifications to tmpdir causes only the last subdirectory to be removed. Additionally, add the missing argument for the t.Fatalf call. Change-Id: I3df53f9051f7ea40cf3f846d47d9cefe445e9b9d Reviewed-on: https://go-review.googlesource.com/32892 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion