diff options
| -rw-r--r-- | src/cmd/compile/internal/gc/subr.go | 2 | ||||
| -rw-r--r-- | test/fixedbugs/issue28688.go | 31 |
2 files changed, 1 insertions, 32 deletions
diff --git a/src/cmd/compile/internal/gc/subr.go b/src/cmd/compile/internal/gc/subr.go index eee5a37ad0..e0925dc7f2 100644 --- a/src/cmd/compile/internal/gc/subr.go +++ b/src/cmd/compile/internal/gc/subr.go @@ -1168,7 +1168,7 @@ func calcHasCall(n *Node) bool { // When using soft-float, these ops might be rewritten to function calls // so we ensure they are evaluated first. - case OADD, OSUB, OMINUS, OMUL: + case OADD, OSUB, OMINUS: if thearch.SoftFloat && (isFloat[n.Type.Etype] || isComplex[n.Type.Etype]) { return true } diff --git a/test/fixedbugs/issue28688.go b/test/fixedbugs/issue28688.go deleted file mode 100644 index 0d2000e149..0000000000 --- a/test/fixedbugs/issue28688.go +++ /dev/null @@ -1,31 +0,0 @@ -// run -gcflags=-d=softfloat - -// Copyright 2018 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. - -package main - -import ( - "fmt" -) - -// When using soft-float, OMUL might be rewritten to function -// call so we should ensure it was evaluated first. Stack frame -// setup for "test" function call should happen after call to runtime.fmul32 - -var x int32 = 1 - -func main() { - var y float32 = 1.0 - test(x, y*y) -} - -//go:noinline -func test(id int32, a float32) { - - if id != x { - fmt.Printf("got: %d, want: %d\n", id, x) - panic("FAIL") - } -} |