aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorDan Scales <danscales@google.com>2021-07-07 11:49:57 -0700
committerDan Scales <danscales@google.com>2021-07-08 18:45:25 +0000
commitd4f6d161e439b3c2a56a4583d4b5acebe3fdeeee (patch)
treefc6d7f663f5cd6730d2fb106063486c749c5e95e /test
parent18135150b0ce945735d242eb6259ffc9b5c767d0 (diff)
downloadgo-d4f6d161e439b3c2a56a4583d4b5acebe3fdeeee.tar.gz
go-d4f6d161e439b3c2a56a4583d4b5acebe3fdeeee.zip
[dev.typeparams] cmd/compile: fix bunch of -G=3 bugs for test cases in test/typeparams/mdempsky
1.go, 12.go: similar to calculating type sizes, we delay computing instantiations during import until we get up to a top-level type, in order to make sure recursive types are complete. But we should always delay calculating sizes when we delay instantiating types, since otherwise we may try to calculate the size of an incomplete type. So, needed to add Defer/ResumeCheckSize in (*importReader).typ where we also defer instantiations. (iimport.go) 2.go: when doing type substition, we have to handle named, parameterized basic types i.e. the type has a type parameter even though the underlying type is a basic type that doesn't depend on the parameter. (subr.go) 3.go: for go 1.18, we allow arbitrary types in interfaces. We had already allowed union types and tilde types, but didn't allow regular non-interface types in Go 1.17 for compatibility. Just skip an error in the case of 1.18. (size.go) 5.go: types2 and types1 differ in how they print out interfaces. types1 puts a space between "interface" and "{", types2 does not. So, since some typenames come from types2 and some from types1, we need to remove the space when printing out type arguments. (iimport.go/subr.go) 9.go: in subst.node(), we were missing the KeyExpr case where a node has no type. The assertion is just there, to make sure we understand all the cases where there is no type to translate. We could just remove the whole error check. (stencil.go) 13.go: in subst.node(), missed handling the case where a method expression is immediate called (which of course, is quite unusual, since then there's no real reason to have used the method expression syntax in that case). Just needed to add ir.OMETHEXPR in the OCALL switch statement. (stencil.go) Change-Id: I202cbe9541dfafe740e3b84b44982d6181738ea0 Reviewed-on: https://go-review.googlesource.com/c/go/+/333165 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'test')
-rw-r--r--test/run.go11
1 files changed, 2 insertions, 9 deletions
diff --git a/test/run.go b/test/run.go
index 0251dc1c6a..90861786df 100644
--- a/test/run.go
+++ b/test/run.go
@@ -2204,15 +2204,8 @@ var g3Failures = setOf(
"typeparam/nested.go", // -G=3 doesn't support function-local types with generics
- "typeparam/mdempsky/1.go",
- "typeparam/mdempsky/2.go",
- "typeparam/mdempsky/3.go",
- "typeparam/mdempsky/4.go",
- "typeparam/mdempsky/5.go",
- "typeparam/mdempsky/9.go",
- "typeparam/mdempsky/11.go",
- "typeparam/mdempsky/12.go",
- "typeparam/mdempsky/13.go",
+ "typeparam/mdempsky/4.go", // -G=3 can't export functions with labeled breaks in loops
+ "typeparam/mdempsky/11.go", // types2/noder2 should give conversion error, because of "notinheap" mismatch
)
var unifiedFailures = setOf(