diff options
| author | Dan Scales <danscales@google.com> | 2021-07-08 12:07:01 -0700 |
|---|---|---|
| committer | Dan Scales <danscales@google.com> | 2021-07-09 16:14:34 +0000 |
| commit | 04acb8a7b9fc0212687cc25aa2598d12f6aceb74 (patch) | |
| tree | f0dc8d7577cad2527cf7abc9261f519350199c54 /test | |
| parent | 2b1d70a137481c0b9f652950f1ac3570f24f68b8 (diff) | |
| download | go-04acb8a7b9fc0212687cc25aa2598d12f6aceb74.tar.gz go-04acb8a7b9fc0212687cc25aa2598d12f6aceb74.zip | |
[dev.typeparams] cmd/compile: report mismatch between types because of //go:notinheap
types2 currently ignores pragmas, so it does not catch a conversion
error when converting a pointer to a type which is NOT marked notinheap
to a pointer to a convertible type, but which is marked notinheap.
So, we specifically check for this error in transformConv() and report
it during noder2.
Change-Id: I6e9c9ee29f53fa5e490c1ac8306e2191db59eeb4
Reviewed-on: https://go-review.googlesource.com/c/go/+/333369
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/run.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/test/run.go b/test/run.go index 90861786df..d6209c2591 100644 --- a/test/run.go +++ b/test/run.go @@ -2204,8 +2204,7 @@ var g3Failures = setOf( "typeparam/nested.go", // -G=3 doesn't support function-local types with generics - "typeparam/mdempsky/4.go", // -G=3 can't export functions with labeled breaks in loops - "typeparam/mdempsky/11.go", // types2/noder2 should give conversion error, because of "notinheap" mismatch + "typeparam/mdempsky/4.go", // -G=3 can't export functions with labeled breaks in loops ) var unifiedFailures = setOf( |