diff options
| author | Dan Scales <danscales@google.com> | 2021-08-22 13:34:22 -0700 |
|---|---|---|
| committer | Dan Scales <danscales@google.com> | 2021-08-23 16:57:27 +0000 |
| commit | f457ecc7f096c7e6b225003b583b989384ef0fcb (patch) | |
| tree | 5462a743116a6264ae55e5b64b63ed71c2a987b5 /test | |
| parent | f1d8ea1da3ef814ea57b545fc967865640a868ab (diff) | |
| download | go-f457ecc7f096c7e6b225003b583b989384ef0fcb.tar.gz go-f457ecc7f096c7e6b225003b583b989384ef0fcb.zip | |
cmd/compile: fixing 15.go for -G=3
Required two changes:
- avoid creating a closure in the case where the actual receiver of an
embedded method is not generic even though the base operand of the
selector is generic. This is similar to the test suggested by wayne
zuo - I thought it was clear in buildClosure, and easier to comment.
- Propagate //go:nointerface to base generic methods and then to
instantiations.
Change-Id: If30c834e4223c2639b7f7e74d44e6087aa9ccd76
Reviewed-on: https://go-review.googlesource.com/c/go/+/344251
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Wayne Zuo <wdvxdr1123@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/run.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/test/run.go b/test/run.go index 22e94b767c..3759059c95 100644 --- a/test/run.go +++ b/test/run.go @@ -2185,8 +2185,7 @@ var g3Failures = setOf( "typeparam/nested.go", // -G=3 doesn't support function-local types with generics - "typeparam/mdempsky/4.go", // -G=3 can't export functions with labeled breaks in loops - "typeparam/mdempsky/15.go", // ICE in (*irgen).buildClosure + "typeparam/mdempsky/4.go", // -G=3 can't export functions with labeled breaks in loops ) var unifiedFailures = setOf( |