diff options
| author | Cherry Mui <cherryyz@google.com> | 2021-06-09 20:14:15 -0400 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2021-08-03 16:14:24 +0000 |
| commit | 656f0888b7de3b96792c1444bc15fe2e586ab5ef (patch) | |
| tree | f66c00ad712779af9fe91bec830fdecf428fada0 /test | |
| parent | 1b193598b3a4ad3138626ca97bca752e9e63b21c (diff) | |
| download | go-656f0888b7de3b96792c1444bc15fe2e586ab5ef.tar.gz go-656f0888b7de3b96792c1444bc15fe2e586ab5ef.zip | |
[dev.typeparams] cmd/compile: make softfloat mode work with register ABI
Previously, softfloat mode does not work with register ABI, mainly
because the compiler doesn't know how to pass floating point
arguments and results. According to the ABI it should be passed in
FP registers, but there isn't any in softfloat mode.
This CL makes it work. When softfloat is used, we define the ABI
as having 0 floating point registers (because there aren't any).
The integer registers are unchanged. So floating point arguments
and results are passed in memory.
Another option is to pass (the bit representation of) floating
point values in integer registers. But this complicates things
because it'd need to reorder integer argument registers.
Change-Id: Ibecbeccb658c10a868fa7f2dcf75138f719cc809
Reviewed-on: https://go-review.googlesource.com/c/go/+/327274
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/fixedbugs/issue26163.go | 2 | ||||
| -rw-r--r-- | test/fixedbugs/issue28688.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/fixedbugs/issue26163.go b/test/fixedbugs/issue26163.go index d141a2797d..3f3d77859d 100644 --- a/test/fixedbugs/issue26163.go +++ b/test/fixedbugs/issue26163.go @@ -1,4 +1,4 @@ -// compile -N -d=softfloat -goexperiment noregabiargs +// compile -N -d=softfloat // Copyright 2018 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style diff --git a/test/fixedbugs/issue28688.go b/test/fixedbugs/issue28688.go index 8ef0802812..0d2000e149 100644 --- a/test/fixedbugs/issue28688.go +++ b/test/fixedbugs/issue28688.go @@ -1,4 +1,4 @@ -// run -gcflags=-d=softfloat -goexperiment noregabiargs +// run -gcflags=-d=softfloat // Copyright 2018 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style |