diff options
author | Austin Clements <austin@google.com> | 2020-04-30 01:40:37 +0000 |
---|---|---|
committer | Bryan C. Mills <bcmills@google.com> | 2020-04-30 02:29:55 +0000 |
commit | eda6fe3572b2fb02c2a8c87892744d04fea87691 (patch) | |
tree | 1d5b4dbcd897708364d7b31dceafdec5a87f7ceb /test | |
parent | 4f7053c87f9ebf3acab7669d380f53bdfba0566b (diff) | |
download | go-eda6fe3572b2fb02c2a8c87892744d04fea87691.tar.gz go-eda6fe3572b2fb02c2a8c87892744d04fea87691.zip |
Revert "cmd/compile: omit file:pos for non-existent, permission errors"
This reverts commit 4f7053c87f9ebf3acab7669d380f53bdfba0566b.
Reason for revert: Newly added test is failing on several builders.
Change-Id: I22dcbfebf2f57735b2f479886bbeb623f95b132f
Reviewed-on: https://go-review.googlesource.com/c/go/+/231043
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'test')
-rw-r--r-- | test/fixedbugs/issue36437.go | 69 |
1 files changed, 0 insertions, 69 deletions
diff --git a/test/fixedbugs/issue36437.go b/test/fixedbugs/issue36437.go deleted file mode 100644 index 356d0160795..00000000000 --- a/test/fixedbugs/issue36437.go +++ /dev/null @@ -1,69 +0,0 @@ -// run - -// +build !nacl,!js - -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. - -// Tests that when non-existent files are passed to the -// compiler, such as in: -// go tool compile foo -// we don't print the beginning position: -// foo:0: open foo: no such file or directory -// but instead omit it and print out: -// open foo: no such file or directory - -package main - -import ( - "fmt" - "io/ioutil" - "os" - "os/exec" - "path/filepath" - "runtime" -) - -func main() { - tmpDir, err := ioutil.TempDir("", "issue36437") - if err != nil { - panic(err) - } - defer os.RemoveAll(tmpDir) - - msgOrErr := func(msg []byte, err error) string { - if len(msg) == 0 && err != nil { - return err.Error() - } - return string(msg) - } - - // 1. Pass in a non-existent file. - output, err := exec.Command("go", "tool", "compile", "x.go").CombinedOutput() - want := "open x.go: no such file or directory\n" - if got := msgOrErr(output, err); got != want { - fmt.Printf("Expected an error, but got:\n\t%q\nwant:\n\t%q", got, want) - return - } - - if runtime.GOOS == "linux" && runtime.GOARCH == "amd64" { - // The Go Linux builders seem to be running under root, thus - // linux-amd64 doesn't seem to be respecting 0222 file permissions, - // and reads files with -W-*-W-*-W- permissions. - // Filed bug: https://golang.org/issues/38608 - return - } - - // 2. Invoke the compiler with a file that we don't have read permissions to. - path := filepath.Join(tmpDir, "p.go") - if err := ioutil.WriteFile(path, []byte("package p"), 0222); err != nil { - panic(err) - } - output, err = exec.Command("go", "tool", "compile", path).CombinedOutput() - want = fmt.Sprintf("open %s: permission denied\n", path) - if got := msgOrErr(output, err); got != want { - fmt.Printf("Expected an error, but got:\n\t%q\nwant:\n\t%q", got, want) - return - } -} |