diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2019-09-04 15:16:25 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2019-09-10 23:01:30 +0000 |
| commit | b9704872d11ae224ca96a1bd2fab0da10ce806d7 (patch) | |
| tree | afc06d5970df320f91082b47c1c30fbd1c19dc8c /test/uintptrescapes2.go | |
| parent | 68a653684823b6d63286bef785ab3a2df09ec552 (diff) | |
| download | go-b9704872d11ae224ca96a1bd2fab0da10ce806d7.tar.gz go-b9704872d11ae224ca96a1bd2fab0da10ce806d7.zip | |
cmd/compile: better integrate parameter tagging with escape.go
This CL moves parameter tagging to before escape analysis is complete,
so we still have access to EscLocation. This will be useful once
EscLocation starts tracking higher-fidelity escape details.
Notably, this CL stops using n.Esc to record parameter escape analysis
details. Now escape analysis only ever sets n.Esc to EscNone or
EscHeap. (It still defaults to EscUnknown, and is set to EscNever in
some places though.)
Passes toolstash-check.
Updates #33981.
Change-Id: I50a91ea1e38c442092de6cd14e20b211f8f818c9
Reviewed-on: https://go-review.googlesource.com/c/go/+/193178
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'test/uintptrescapes2.go')
| -rw-r--r-- | test/uintptrescapes2.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/uintptrescapes2.go b/test/uintptrescapes2.go index b8117b857b..866efd94d8 100644 --- a/test/uintptrescapes2.go +++ b/test/uintptrescapes2.go @@ -18,7 +18,7 @@ func F1(a uintptr) {} // ERROR "escaping uintptr" //go:uintptrescapes //go:noinline -func F2(a ...uintptr) {} // ERROR "escaping ...uintptr" "a does not escape" +func F2(a ...uintptr) {} // ERROR "escaping ...uintptr" //go:uintptrescapes //go:noinline |