diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-06-15 21:40:49 +0700 |
|---|---|---|
| committer | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-06-16 06:05:23 +0000 |
| commit | 785a8f677fbba9432ee67b14d41004ba7fd35ddb (patch) | |
| tree | 61983c6c5dd15729d7a2531f3abc358742d10fe1 /test/run.go | |
| parent | a752bc07462f01a4c1ee1940c3ea316b270af146 (diff) | |
| download | go-785a8f677fbba9432ee67b14d41004ba7fd35ddb.tar.gz go-785a8f677fbba9432ee67b14d41004ba7fd35ddb.zip | |
cmd/compile: better error message for invalid untyped operation
For typed vs un-typed operation, the compiler do the conversion
un-conditionally, so if the operation is invalid, the error report is
pointed to the conversion, instead of the invalid operation itself.
To fix this, only do the conversion when the operations are valid
for both types.
Fixes #46749
Change-Id: Ib71c7bcd3ed5454e6df55b6a8db4e0f189259ba7
Reviewed-on: https://go-review.googlesource.com/c/go/+/328050
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'test/run.go')
| -rw-r--r-- | test/run.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/run.go b/test/run.go index 5e60de7624..d7f5d02391 100644 --- a/test/run.go +++ b/test/run.go @@ -2002,4 +2002,5 @@ var excluded = map[string]bool{ "fixedbugs/issue7525c.go": true, // types2 reports init cycle error on different line - ok otherwise "fixedbugs/issue7525d.go": true, // types2 reports init cycle error on different line - ok otherwise "fixedbugs/issue7525e.go": true, // types2 reports init cycle error on different line - ok otherwise + "fixedbugs/issue46749.go": true, // types2 reports can not convert error instead of type mismatched } |